From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmaengine-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7A749C636C9
	for <dmaengine@archiver.kernel.org>; Sat, 17 Jul 2021 17:39:31 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 6118661026
	for <dmaengine@archiver.kernel.org>; Sat, 17 Jul 2021 17:39:31 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233751AbhGQRm1 (ORCPT <rfc822;dmaengine@archiver.kernel.org>);
        Sat, 17 Jul 2021 13:42:27 -0400
Received: from mail.kernel.org ([198.145.29.99]:37888 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233702AbhGQRmZ (ORCPT <rfc822;dmaengine@vger.kernel.org>);
        Sat, 17 Jul 2021 13:42:25 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2EF3B608FE;
        Sat, 17 Jul 2021 17:39:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1626543567;
        bh=Q+2bkD5WfuZSmFgsqVWfw6pshTe4O9qGgeLkE8FzIks=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=aSUX4iwQlT4MAMXCc0u9QSoN+8U4sRTlIEbQc2QCVHXZ5lmIUGBRnEa7kduKrOZvQ
         5l5fSwyTJbeE6tTv6KBaOJvQ02+pQ21s5OJ/QB9q9KZhaix6rPWkTQKZ8HN0pBIDqu
         ODYgs6tTVN1u58YXt7MjFlsxuepek94iQNJVzmX4=
Date:   Sat, 17 Jul 2021 19:39:21 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Kelvin Cheung <keguang.zhang@gmail.com>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5] dmaengine: Loongson1: Add Loongson1 dmaengine driver
Message-ID: <YPMVyYoBojHYsMbJ@kroah.com>
References: <20210704153314.6995-1-keguang.zhang@gmail.com>
 <YO5yo8v/tRZLGEdo@matsya>
 <CAJhJPsUNCSK4VYv9Z4ZNDxC03F4CxQoAXCCf+TJmmbdUe4XNNA@mail.gmail.com>
 <YPLrsXEmmHPtbZ+N@matsya>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YPLrsXEmmHPtbZ+N@matsya>
Precedence: bulk
List-ID: <dmaengine.vger.kernel.org>
X-Mailing-List: dmaengine@vger.kernel.org

On Sat, Jul 17, 2021 at 08:09:45PM +0530, Vinod Koul wrote:
> On 17-07-21, 18:57, Kelvin Cheung wrote:
> > Vinod Koul <vkoul@kernel.org> 于2021年7月14日周三 下午1:14写道：
> > >
> > > On 04-07-21, 23:33, Keguang Zhang wrote:
> > >
> > > > +static struct platform_driver ls1x_dma_driver = {
> > > > +     .probe  = ls1x_dma_probe,
> > > > +     .remove = ls1x_dma_remove,
> > > > +     .driver = {
> > > > +             .name   = "ls1x-dma",
> > > > +     },
> > > > +};
> > > > +
> > > > +module_platform_driver(ls1x_dma_driver);
> > >
> > > so my comment was left unanswered, who creates this device!
> > 
> > Sorry!
> > This patch will create the device: https://patchwork.kernel.org/patch/12281691
> 
> Greg, looks like the above patch creates platform devices in mips, is
> that the right way..?

I do not understand, what exactly is the question?

thanks,

greg k-h