From: Vinod Koul <vkoul@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Kelvin Cheung <keguang.zhang@gmail.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5] dmaengine: Loongson1: Add Loongson1 dmaengine driver
Date: Tue, 20 Jul 2021 17:13:53 +0530 [thread overview]
Message-ID: <YPa2+TsdL0PrR3hR@matsya> (raw)
In-Reply-To: <YPMVyYoBojHYsMbJ@kroah.com>
On 17-07-21, 19:39, Greg KH wrote:
> On Sat, Jul 17, 2021 at 08:09:45PM +0530, Vinod Koul wrote:
> > On 17-07-21, 18:57, Kelvin Cheung wrote:
> > > Vinod Koul <vkoul@kernel.org> 于2021年7月14日周三 下午1:14写道:
> > > >
> > > > On 04-07-21, 23:33, Keguang Zhang wrote:
> > > >
> > > > > +static struct platform_driver ls1x_dma_driver = {
> > > > > + .probe = ls1x_dma_probe,
> > > > > + .remove = ls1x_dma_remove,
> > > > > + .driver = {
> > > > > + .name = "ls1x-dma",
> > > > > + },
> > > > > +};
> > > > > +
> > > > > +module_platform_driver(ls1x_dma_driver);
> > > >
> > > > so my comment was left unanswered, who creates this device!
> > >
> > > Sorry!
> > > This patch will create the device: https://patchwork.kernel.org/patch/12281691
> >
> > Greg, looks like the above patch creates platform devices in mips, is
> > that the right way..?
>
> I do not understand, what exactly is the question?
So this patch was adding Loongson1 dmaengine driver which is a platform
device. I asked about the platform device and was told that [1] creates
the platform device. I am not sure if that is the recommended way given
that you have been asking people to not use platform devices.
[1]: https://patchwork.kernel.org/patch/12281691
So is [1] the correct approach or should this be fixed?
--
~Vinod
next prev parent reply other threads:[~2021-07-20 11:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 15:33 [PATCH V5] dmaengine: Loongson1: Add Loongson1 dmaengine driver Keguang Zhang
2021-07-14 5:14 ` Vinod Koul
2021-07-17 10:52 ` Kelvin Cheung
2021-07-17 10:57 ` Kelvin Cheung
2021-07-17 14:39 ` Vinod Koul
2021-07-17 17:39 ` Greg KH
2021-07-20 11:43 ` Vinod Koul [this message]
2021-07-20 11:48 ` Greg KH
2021-07-20 12:18 ` Vinod Koul
2021-07-21 12:22 ` Kelvin Cheung
2021-08-11 7:18 ` Kelvin Cheung
2021-08-25 14:26 ` Vinod Koul
2021-08-29 13:43 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPa2+TsdL0PrR3hR@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.