From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98159C432BE for ; Sun, 25 Jul 2021 04:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C71C60F25 for ; Sun, 25 Jul 2021 04:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbhGYD1n (ORCPT ); Sat, 24 Jul 2021 23:27:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbhGYD1m (ORCPT ); Sat, 24 Jul 2021 23:27:42 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 890FAC061757 for ; Sat, 24 Jul 2021 21:08:12 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id o20so6813292oiw.12 for ; Sat, 24 Jul 2021 21:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VMaB3vY2dufbHq4l3p72oIac6AlNtvIq05CVprUMmII=; b=p7mTtrsn+eU1+Xe9EUhFCAN3TifiVNSH7Ikny4Cl5I9RPHw1Ow4Ufh9ysP4r3e9VC8 S1E0yz2Qts+9Zefyyj3nc+eV7bOGn65dFktOFSQYbS2SKVHY2n4qMLKRk7mLcgrMZXUw gr36j5GIBtzfXfB2datfx59ILOoPKjMPPirFgjeio/fxAGxzkmdRa9EfUONwxzNOZvv8 ANJhkjXeIrpyoXVZHpicXS3A9DfcYVE26j8I0sWHuIs3kL7wjivBSALkFToBr9a/v1PU C0+dpKdxQJ06dMrVFbY4+RG4pg1x88NMg/aJ5gEMN0QUnZbxfZxt2w7iLbA5I5NA4CqX SBLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VMaB3vY2dufbHq4l3p72oIac6AlNtvIq05CVprUMmII=; b=J8/YzqID95GCw4/oeSKBCVJxciIdBUCXnMK1yHZECekz1dmWTCK4O9m2OSZusTBBaC 7kUK6HyjKe9EAayWpR5I8VyYBBVs5Rchng7c5OXnXhSO/k/uAlaS3D02Peu/MmcTA4oU xnE+ObAqLqs0eny2Zed935vY3Oa2d6YRJ9xIHu49jFgDA9L0L53ez4+sjSanESKwfg1X kPeveGtaIdScVg2bBdMaQXuIrY2KaYGaZH5wxnNpwpz+JCYK+ir+h9bIEQ5PlzFYdaQM vPdRWqGjGRK29RPUC0D20oAKKyg6MThSjfOSMw26ujoQnQdqK6AzzBDmJnP3mONn67RW L7xw== X-Gm-Message-State: AOAM533DHUrr9cs1SMmRuRvjgmkAFLa3ytopUOZHmSLhrcz/PMDYAmpf vlNVYJW5VX86CH9FZrr1GoPsVw== X-Google-Smtp-Source: ABdhPJyES/Xh7ilkq1oDNnPV7WeA0Q9JIif9yMQxTMwm78l+CsYTi6M0FP1UUnJH73UCZSxPUHJ0CQ== X-Received: by 2002:aca:1215:: with SMTP id 21mr13005806ois.37.1627186091976; Sat, 24 Jul 2021 21:08:11 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x31sm6593605ota.24.2021.07.24.21.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 21:08:11 -0700 (PDT) Date: Sat, 24 Jul 2021 23:08:09 -0500 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Rob Clark , Sean Paul , Abhinav Kumar , Jonathan Marek , Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v4 5/7] drm/msm/dp: stop calling set_encoder_mode callback Message-ID: References: <20210717124016.316020-1-dmitry.baryshkov@linaro.org> <20210717124016.316020-6-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210717124016.316020-6-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > None of the display drivers now implement set_encoder_mode callback. > Stop calling it from the modeset init code. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/dp/dp_display.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 051c1be1de7e..70b319a8fe83 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -102,8 +102,6 @@ struct dp_display_private { > struct dp_display_mode dp_mode; > struct msm_dp dp_display; > > - bool encoder_mode_set; > - > /* wait for audio signaling */ > struct completion audio_comp; > > @@ -283,20 +281,6 @@ static void dp_display_send_hpd_event(struct msm_dp *dp_display) > } > > > -static void dp_display_set_encoder_mode(struct dp_display_private *dp) > -{ > - struct msm_drm_private *priv = dp->dp_display.drm_dev->dev_private; > - struct msm_kms *kms = priv->kms; > - > - if (!dp->encoder_mode_set && dp->dp_display.encoder && > - kms->funcs->set_encoder_mode) { > - kms->funcs->set_encoder_mode(kms, > - dp->dp_display.encoder, false); > - > - dp->encoder_mode_set = true; > - } > -} > - > static int dp_display_send_hpd_notification(struct dp_display_private *dp, > bool hpd) > { > @@ -369,8 +353,6 @@ static void dp_display_host_init(struct dp_display_private *dp, int reset) > if (dp->usbpd->orientation == ORIENTATION_CC2) > flip = true; > > - dp_display_set_encoder_mode(dp); > - > dp_power_init(dp->power, flip); > dp_ctrl_host_init(dp->ctrl, flip, reset); > dp_aux_init(dp->aux); > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B73C4338F for ; Sun, 25 Jul 2021 04:08:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E62CB60F13 for ; Sun, 25 Jul 2021 04:08:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E62CB60F13 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B83C737F1; Sun, 25 Jul 2021 04:08:13 +0000 (UTC) Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F826737F1 for ; Sun, 25 Jul 2021 04:08:12 +0000 (UTC) Received: by mail-oi1-x22a.google.com with SMTP id z26so6833745oih.10 for ; Sat, 24 Jul 2021 21:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VMaB3vY2dufbHq4l3p72oIac6AlNtvIq05CVprUMmII=; b=p7mTtrsn+eU1+Xe9EUhFCAN3TifiVNSH7Ikny4Cl5I9RPHw1Ow4Ufh9ysP4r3e9VC8 S1E0yz2Qts+9Zefyyj3nc+eV7bOGn65dFktOFSQYbS2SKVHY2n4qMLKRk7mLcgrMZXUw gr36j5GIBtzfXfB2datfx59ILOoPKjMPPirFgjeio/fxAGxzkmdRa9EfUONwxzNOZvv8 ANJhkjXeIrpyoXVZHpicXS3A9DfcYVE26j8I0sWHuIs3kL7wjivBSALkFToBr9a/v1PU C0+dpKdxQJ06dMrVFbY4+RG4pg1x88NMg/aJ5gEMN0QUnZbxfZxt2w7iLbA5I5NA4CqX SBLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VMaB3vY2dufbHq4l3p72oIac6AlNtvIq05CVprUMmII=; b=GcdIUOGDJN/srDXKXuyCeCN8CxYZ6SMrESKLMjLxtXqbIZnMvGWkustkHOB/8Qgksu hOPGfdEcynIZ2iMe8ca7EXU5AotJnW5P5s5kVeeiqeNNHBAjAqGm95nSWDvhpeF965MY xSfiGBAp+0UJ8jbFw7K3onLcbCeC5nO21uY0fcMI6LgoB1ru4Xvh4IoVbfHwoYcOm+Xb WmJ8VEzQg9/Ce2YqCBOqCBe5TW/JrU7J/XgbPZKDYcUP/LXWCkiSuV0hxEBPatqDD1yY gi5e8xqi5Paobrua9keIz6Oy563huZ7P94Y4sJqlXdNeFcUHo8OpD2AtPh32bsZ9QQRB vXAA== X-Gm-Message-State: AOAM532D+65bP9yJD8S7wMSwoghoWx8nsyvpLsxQzjg4yzQhWEsM79hu SHE+A2RD64+Bksmno7Cc6tEYyg== X-Google-Smtp-Source: ABdhPJyES/Xh7ilkq1oDNnPV7WeA0Q9JIif9yMQxTMwm78l+CsYTi6M0FP1UUnJH73UCZSxPUHJ0CQ== X-Received: by 2002:aca:1215:: with SMTP id 21mr13005806ois.37.1627186091976; Sat, 24 Jul 2021 21:08:11 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id x31sm6593605ota.24.2021.07.24.21.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 21:08:11 -0700 (PDT) Date: Sat, 24 Jul 2021 23:08:09 -0500 From: Bjorn Andersson To: Dmitry Baryshkov Subject: Re: [PATCH v4 5/7] drm/msm/dp: stop calling set_encoder_mode callback Message-ID: References: <20210717124016.316020-1-dmitry.baryshkov@linaro.org> <20210717124016.316020-6-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210717124016.316020-6-dmitry.baryshkov@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Jonathan Marek , Stephen Boyd , linux-arm-msm@vger.kernel.org, Abhinav Kumar , David Airlie , dri-devel@lists.freedesktop.org, Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > None of the display drivers now implement set_encoder_mode callback. > Stop calling it from the modeset init code. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/gpu/drm/msm/dp/dp_display.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 051c1be1de7e..70b319a8fe83 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -102,8 +102,6 @@ struct dp_display_private { > struct dp_display_mode dp_mode; > struct msm_dp dp_display; > > - bool encoder_mode_set; > - > /* wait for audio signaling */ > struct completion audio_comp; > > @@ -283,20 +281,6 @@ static void dp_display_send_hpd_event(struct msm_dp *dp_display) > } > > > -static void dp_display_set_encoder_mode(struct dp_display_private *dp) > -{ > - struct msm_drm_private *priv = dp->dp_display.drm_dev->dev_private; > - struct msm_kms *kms = priv->kms; > - > - if (!dp->encoder_mode_set && dp->dp_display.encoder && > - kms->funcs->set_encoder_mode) { > - kms->funcs->set_encoder_mode(kms, > - dp->dp_display.encoder, false); > - > - dp->encoder_mode_set = true; > - } > -} > - > static int dp_display_send_hpd_notification(struct dp_display_private *dp, > bool hpd) > { > @@ -369,8 +353,6 @@ static void dp_display_host_init(struct dp_display_private *dp, int reset) > if (dp->usbpd->orientation == ORIENTATION_CC2) > flip = true; > > - dp_display_set_encoder_mode(dp); > - > dp_power_init(dp->power, flip); > dp_ctrl_host_init(dp->ctrl, flip, reset); > dp_aux_init(dp->aux); > -- > 2.30.2 >