From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08786C433EF for ; Mon, 13 Sep 2021 08:11:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC1FA60FBF for ; Mon, 13 Sep 2021 08:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237838AbhIMIMU (ORCPT ); Mon, 13 Sep 2021 04:12:20 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:58032 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234684AbhIMIMT (ORCPT ); Mon, 13 Sep 2021 04:12:19 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D559D21FA6; Mon, 13 Sep 2021 08:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1631520662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TqgJzUE+9F845jwNISUetj2Rzh0zRQ8LjCewshk/MlE=; b=q7U/4fqRf+vvcwcLH/cGJZbSxdXFmACu4zKTAtMqHeUYILWWUbut1J3M/qc4kQg+l1Ff2A KHznSxQ/VzSQnjEGvOuVpHVN8nrVEsTzb5lbDPMplK61IuexNH2RmMvWa9WI4t16EsG196 lkGjYg8EGC73rqRhy7ZNuR06um/8cQ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1631520662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TqgJzUE+9F845jwNISUetj2Rzh0zRQ8LjCewshk/MlE=; b=emCtZzuWGiaaOkzBFF1C9h9c/GQhJMDxuPoCjZuN17pMQRJat6t6GsOJkXV5H25PC3mfly OmO921G4ZXfr1nCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE84213A09; Mon, 13 Sep 2021 08:11:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lEpFLpYHP2EFQAAAMHmgww (envelope-from ); Mon, 13 Sep 2021 08:11:02 +0000 Date: Mon, 13 Sep 2021 10:11:22 +0200 From: Cyril Hrubis To: kernel test robot Cc: Chi Wu , Miklos Szeredi , Jan Kara , lkp@intel.com, lkp@lists.01.org, LKML , Jens Axboe , Sedat Dilek , Tejun Heo , Andrew Morton , Linus Torvalds , ltp@lists.linux.it Subject: Re: [LTP] [mm/page] ab19939a6a: ltp.msync04.fail Message-ID: References: <20210912123429.GA25450@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210912123429.GA25450@xsang-OptiPlex-9020> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > FYI, we noticed the following commit (built with gcc-9): > > commit: ab19939a6a5010cba4e9cb04dd8bee03c72edcbd ("mm/page-writeback: Fix performance when BDI's share of ratio is 0.") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > > in testcase: ltp > version: ltp-x86_64-14c1f76-1_20210907 > with following parameters: > > disk: 1HDD > fs: xfs > test: syscalls-03 > ucode: 0xe2 > > test-description: The LTP testsuite contains a collection of tools for testing the Linux kernel and related features. > test-url: http://linux-test-project.github.io/ The msync04 test formats a device with a diffrent filesystems, for each filesystem it maps a file, writes to the mapped page and the checks a dirty bit in /proc/kpageflags before and after msync() on that page. This seems to be broken after this patch for ntfs over FUSE and it looks like the page does not have a dirty bit set right after it has been written to. Also I guess that we should increase the number of the pages we dirty or attempt to retry since a single page may be flushed to the storage if we are unlucky and the process is preempted between the write and the initial check for the dirty bit. -- Cyril Hrubis chrubis@suse.cz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D755C433EF for ; Mon, 13 Sep 2021 08:11:17 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F02260FDA for ; Mon, 13 Sep 2021 08:11:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F02260FDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 2ACE43C8A19 for ; Mon, 13 Sep 2021 10:11:14 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 560E53C1DCC for ; Mon, 13 Sep 2021 10:11:04 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id AA0861000A29 for ; Mon, 13 Sep 2021 10:11:03 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D559D21FA6; Mon, 13 Sep 2021 08:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1631520662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TqgJzUE+9F845jwNISUetj2Rzh0zRQ8LjCewshk/MlE=; b=q7U/4fqRf+vvcwcLH/cGJZbSxdXFmACu4zKTAtMqHeUYILWWUbut1J3M/qc4kQg+l1Ff2A KHznSxQ/VzSQnjEGvOuVpHVN8nrVEsTzb5lbDPMplK61IuexNH2RmMvWa9WI4t16EsG196 lkGjYg8EGC73rqRhy7ZNuR06um/8cQ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1631520662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TqgJzUE+9F845jwNISUetj2Rzh0zRQ8LjCewshk/MlE=; b=emCtZzuWGiaaOkzBFF1C9h9c/GQhJMDxuPoCjZuN17pMQRJat6t6GsOJkXV5H25PC3mfly OmO921G4ZXfr1nCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE84213A09; Mon, 13 Sep 2021 08:11:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lEpFLpYHP2EFQAAAMHmgww (envelope-from ); Mon, 13 Sep 2021 08:11:02 +0000 Date: Mon, 13 Sep 2021 10:11:22 +0200 From: Cyril Hrubis To: kernel test robot Message-ID: References: <20210912123429.GA25450@xsang-OptiPlex-9020> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210912123429.GA25450@xsang-OptiPlex-9020> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [mm/page] ab19939a6a: ltp.msync04.fail X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miklos Szeredi , Jan Kara , lkp@intel.com, Chi Wu , LKML , Jens Axboe , lkp@lists.01.org, Sedat Dilek , Tejun Heo , Andrew Morton , Linus Torvalds , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Message-ID: <20210913081122.cgo1XsREb9ECPB2CeJPcrTLICQHkoEdNg_jZwC-uZYQ@z> Hi! > FYI, we noticed the following commit (built with gcc-9): > > commit: ab19939a6a5010cba4e9cb04dd8bee03c72edcbd ("mm/page-writeback: Fix performance when BDI's share of ratio is 0.") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > > in testcase: ltp > version: ltp-x86_64-14c1f76-1_20210907 > with following parameters: > > disk: 1HDD > fs: xfs > test: syscalls-03 > ucode: 0xe2 > > test-description: The LTP testsuite contains a collection of tools for testing the Linux kernel and related features. > test-url: http://linux-test-project.github.io/ The msync04 test formats a device with a diffrent filesystems, for each filesystem it maps a file, writes to the mapped page and the checks a dirty bit in /proc/kpageflags before and after msync() on that page. This seems to be broken after this patch for ntfs over FUSE and it looks like the page does not have a dirty bit set right after it has been written to. Also I guess that we should increase the number of the pages we dirty or attempt to retry since a single page may be flushed to the storage if we are unlucky and the process is preempted between the write and the initial check for the dirty bit. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5286866627445482707==" MIME-Version: 1.0 From: Cyril Hrubis To: lkp@lists.01.org Subject: Re: [LTP] [mm/page] ab19939a6a: ltp.msync04.fail Date: Mon, 13 Sep 2021 10:11:22 +0200 Message-ID: In-Reply-To: <20210912123429.GA25450@xsang-OptiPlex-9020> List-Id: --===============5286866627445482707== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi! > FYI, we noticed the following commit (built with gcc-9): > = > commit: ab19939a6a5010cba4e9cb04dd8bee03c72edcbd ("mm/page-writeback: Fix= performance when BDI's share of ratio is 0.") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > = > = > in testcase: ltp > version: ltp-x86_64-14c1f76-1_20210907 > with following parameters: > = > disk: 1HDD > fs: xfs > test: syscalls-03 > ucode: 0xe2 > = > test-description: The LTP testsuite contains a collection of tools for te= sting the Linux kernel and related features. > test-url: http://linux-test-project.github.io/ The msync04 test formats a device with a diffrent filesystems, for each filesystem it maps a file, writes to the mapped page and the checks a dirty bit in /proc/kpageflags before and after msync() on that page. This seems to be broken after this patch for ntfs over FUSE and it looks like the page does not have a dirty bit set right after it has been written to. Also I guess that we should increase the number of the pages we dirty or attempt to retry since a single page may be flushed to the storage if we are unlucky and the process is preempted between the write and the initial check for the dirty bit. -- = Cyril Hrubis chrubis(a)suse.cz --===============5286866627445482707==--