From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2237CC433F5 for ; Fri, 3 Sep 2021 19:49:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B1CC60FD7 for ; Fri, 3 Sep 2021 19:49:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236004AbhICTux (ORCPT ); Fri, 3 Sep 2021 15:50:53 -0400 Received: from mail-oo1-f48.google.com ([209.85.161.48]:35431 "EHLO mail-oo1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234588AbhICTux (ORCPT ); Fri, 3 Sep 2021 15:50:53 -0400 Received: by mail-oo1-f48.google.com with SMTP id y3-20020a4ab403000000b00290e2a52c71so24046oon.2; Fri, 03 Sep 2021 12:49:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=grquTj9le7LyKwa10qtUsy6uhDA/Og3HGD4G7QWDUb4=; b=XAspmNGbVMjLw7N0oCcgv5jYCaIOtX7WwPdUY5ACqHintGBLOOEbt++nSI/Ui53+4p trUbKJKMrTEV3Z/K8pNWHF1MUPaiuHv4eLqvL4JE+Av+WmLKPjHilPo82Z4S5QVFfGqM cSZMraa6yS1qww8C6vudS2ssRAMF/NTsTgoV6uNFNz40ZxzlRa6c/lT6MAWMmlqGBZrA 1TLdyBnYX7FKsio74Go6knBnF/K0M592T4znNZuh+xzHojpRDK/nvtVdvnxhvH0ZpmiL WaYC6HVeSWEloZuas9zqVcw7A3RUKScABRW/I3Uga3wu5cLCJLSffNGXPA46W67O8MXK xhYw== X-Gm-Message-State: AOAM531pc3/FLZ2uhJmpEUCYNAkAo3b8XuLOyd/qtIqbJUqSHctTZZXX ZXOvjgCKkAjTihdggTWDdFqmvEdVVA== X-Google-Smtp-Source: ABdhPJzE4B+wXlgP6ywfh4wkKs8nUK6ytNyELJgMM6mJAhKo1xm4kn1xnsFaeB53y4uB+huAG1XsjA== X-Received: by 2002:a4a:bd17:: with SMTP id n23mr4344751oop.54.1630698592341; Fri, 03 Sep 2021 12:49:52 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id 14sm66624otl.50.2021.09.03.12.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 12:49:51 -0700 (PDT) Received: (nullmailer pid 3345524 invoked by uid 1000); Fri, 03 Sep 2021 19:49:50 -0000 Date: Fri, 3 Sep 2021 14:49:50 -0500 From: Rob Herring To: Felipe Balbi Cc: Maxime Ripard , devicetree@vger.kernel.org, Frank Rowand , Chen-Yu Tsai , Jernej =?utf-8?Q?=C5=A0krabec?= , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH v2 37/52] dt-bindings: usb: dwc3: Fix usb-phy check Message-ID: References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-38-maxime@cerno.tech> <87a6kwcvzb.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a6kwcvzb.fsf@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Sep 01, 2021 at 03:36:35PM +0300, Felipe Balbi wrote: > > Maxime Ripard writes: > > > The original binding was allowing any combination of usb2-phy and > > usb3-phy in the phys and phy-names properties. > > > > However, the current binding enforces that those properties must be a > > list of usb2-phy and usb3-phy, with exactly one element, effectively > > making usb2-phy the only value being valid. > > > > Let's rework the properties description to allow either one or two > > element picked with values either usb2-phy or usb3-phy. The rest of the > > tooling makes sure that we don't get any duplicate value, so this should > > be what we want. > > > > Cc: Felipe Balbi > > Cc: Greg Kroah-Hartman > > Cc: linux-usb@vger.kernel.org > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > index 078fb7889593..c1c970073681 100644 > > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > @@ -73,15 +73,15 @@ properties: > > > > phys: > > minItems: 1 > > - items: > > - - description: USB2/HS PHY > > - - description: USB3/SS PHY > > + maxItems: 2 > > I'm not sure you should enforce a maximum of 2 PHYs. Some systems may > use more than one USB2 PHY to take care of different parts of the USB > link. It was already limited to 2. This change doesn't change that. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75F51C433EF for ; Fri, 3 Sep 2021 19:51:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49B2E60FD7 for ; Fri, 3 Sep 2021 19:51:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 49B2E60FD7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GlCbh/6VW0/3J3h7QNAhb3VsJCWOZUGywZa3R7RpcNg=; b=ECnRj45J2Fu7Cn LUoab0vCrqCilixIPQFRtEyEV2+jkEQACBmOlAPq5Z6263zB8cnavU+jGkZ8XmfBTtqeAOerhaUky fH5awX0PSELaDM7LENOu7QXWj6F5UvA/t4hDL/hKtG2q8JeFT+KJub8B3w+nH24fKctUspnOPO9WV gvVvBqMI0RkAiD9fdXtNZOZWKQW4q6GPgXTX9o+DXH0DRWy7rykkXizIOoXcE1yKrOrndr6S7+QCr z2QTBnZgT26GjWTdwcO3+ecd2WN0ecindeL08Bfle6wLrMD3YP7RbhhmSwBqsnX9MBkOwfMSnLnXM Aa1js72yHibUYQMne0xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMFCH-00Co63-3S; Fri, 03 Sep 2021 19:49:57 +0000 Received: from mail-oo1-f43.google.com ([209.85.161.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMFCD-00Co4z-5d for linux-arm-kernel@lists.infradead.org; Fri, 03 Sep 2021 19:49:55 +0000 Received: by mail-oo1-f43.google.com with SMTP id k18-20020a4abd92000000b002915ed21fb8so15395oop.11 for ; Fri, 03 Sep 2021 12:49:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=grquTj9le7LyKwa10qtUsy6uhDA/Og3HGD4G7QWDUb4=; b=eZ0fQRq+2cTePLyAGNSzQmR2jDmzUzY+FHNosEVZzFhoNX4L9WtL+9zqbD89ilDTRX 0Rfj+Lifv9Tks2Q0qrFRVHPyss2UAEGiO0/xhCNYC3b+PWVWjG3hzkxWnloMwE0x7n+8 YAITAF/w+a8m8kpM2oh/48r264HfeRgzp1mJ6wtAaeYtTnYQL35ijnMNTZZdAabjV9wJ ezGicbWMnD9/ITysQjEvqZNX4pHB3ETJbUICKljl0IcCo6tihtivy8NIHfHgw9IczmA3 /EcVR05KlsVRii6Mry5Bfm40L8RuyNHDo4f+vrTFM81BEiZalNvipcfw/Yn6PTJ7iUj3 0oRg== X-Gm-Message-State: AOAM533t8kQ874kJr7l2UMuirA/5p5r5otN9vHzWpbD23XmUIIoYLjk/ U+YlI4DUnbcu/43SP1nUnA== X-Google-Smtp-Source: ABdhPJzE4B+wXlgP6ywfh4wkKs8nUK6ytNyELJgMM6mJAhKo1xm4kn1xnsFaeB53y4uB+huAG1XsjA== X-Received: by 2002:a4a:bd17:: with SMTP id n23mr4344751oop.54.1630698592341; Fri, 03 Sep 2021 12:49:52 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id 14sm66624otl.50.2021.09.03.12.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 12:49:51 -0700 (PDT) Received: (nullmailer pid 3345524 invoked by uid 1000); Fri, 03 Sep 2021 19:49:50 -0000 Date: Fri, 3 Sep 2021 14:49:50 -0500 From: Rob Herring To: Felipe Balbi Cc: Maxime Ripard , devicetree@vger.kernel.org, Frank Rowand , Chen-Yu Tsai , Jernej =?utf-8?Q?=C5=A0krabec?= , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH v2 37/52] dt-bindings: usb: dwc3: Fix usb-phy check Message-ID: References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-38-maxime@cerno.tech> <87a6kwcvzb.fsf@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87a6kwcvzb.fsf@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210903_124953_300223_1DCF3A89 X-CRM114-Status: GOOD ( 23.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 01, 2021 at 03:36:35PM +0300, Felipe Balbi wrote: > > Maxime Ripard writes: > > > The original binding was allowing any combination of usb2-phy and > > usb3-phy in the phys and phy-names properties. > > > > However, the current binding enforces that those properties must be a > > list of usb2-phy and usb3-phy, with exactly one element, effectively > > making usb2-phy the only value being valid. > > > > Let's rework the properties description to allow either one or two > > element picked with values either usb2-phy or usb3-phy. The rest of the > > tooling makes sure that we don't get any duplicate value, so this should > > be what we want. > > > > Cc: Felipe Balbi > > Cc: Greg Kroah-Hartman > > Cc: linux-usb@vger.kernel.org > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > index 078fb7889593..c1c970073681 100644 > > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > @@ -73,15 +73,15 @@ properties: > > > > phys: > > minItems: 1 > > - items: > > - - description: USB2/HS PHY > > - - description: USB3/SS PHY > > + maxItems: 2 > > I'm not sure you should enforce a maximum of 2 PHYs. Some systems may > use more than one USB2 PHY to take care of different parts of the USB > link. It was already limited to 2. This change doesn't change that. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel