Re: [PATCH] memory: renesas-rpc-if: Avoid unaligned bus access for HyperFlash

From: Wolfram Sang <wsa@kernel.org>
To: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Sergei Shtylyov <sergei.shtylyov@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] memory: renesas-rpc-if: Avoid unaligned bus access for HyperFlash
Date: Sat, 25 Sep 2021 11:54:57 +0200	[thread overview]
Message-ID: <YU7x8cabSsQiUJuE@kunai> (raw)
In-Reply-To: <20210922184830.29147-1-andrew_gabbasov@mentor.com>

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

Hi Andrew,

thanks for this patch!

> +	const int maxw = (IS_ENABLED(CONFIG_64BIT)) ? 8 : 4;
> +	u8 buf[2];

I could imagine the code becomes more readable if we make use of
something like:

	unsigned long from_ul = from;

and then use it throughout the function?

> +#ifdef CONFIG_64BIT
> +		*(u64 *)to = __raw_readq(from);
> +#else
> +		*(u32 *)to = __raw_readl(from);
> +#endif

To keep the ifdeffery minimal:

	if (maxw == 8)
		*(u64 *)to = __raw_readq(from);
	else
 		*(u32 *)to = __raw_readl(from);

and let the compiler do its job.

I wondered if this could be a helper function somewhere instead of open
coded in this driver. However, I did not find any similar code in the
kernel yet, so it might be too early to make this a helper. Have you
looked for similar code? I might have just missed it.

Happy hacking,

   Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]