From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBB1D29CA for ; Tue, 28 Sep 2021 07:34:37 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 55B3260F46; Tue, 28 Sep 2021 07:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632814477; bh=FXJERLSoyhfMGBS0Hs/ca2OK7+EwhV8+7CAGiyuQIzY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZSwnW/QW1ziVb2vzzIm0dinkQLg5zL3yk9PfEAZFaIEmOg226d2BPPpWXSaqORNNS 5iMkLIFVYp91weFGz7NIiFMOmKgcnFxffLtJl11liVApDjMrdqMRVvT9QqoFkU3lTp d2wQVS/d/smxOIfP91V8Cn+NbJqxwFcY5x0irbvzigSS00/fCBmml+RjRVo7wS6c82 5PBebINtZ63yzWPnrGihAiLXryw97K9WlZ4sBH+zxu0QHwXFC7OyOyvdYwYHPfwKuO vnJ2hsRiQIyufQ9c3HgNrKhM1G3rz8XHjfusYz69BxP/1Cr+muDTkBkK3yofoFZZu/ zmgkPZnJOrU7A== Date: Tue, 28 Sep 2021 10:34:33 +0300 From: Leon Romanovsky To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , Alexandre Belloni , Andrew Lunn , Ariel Elior , Bin Luo , Claudiu Manoil , Coiby Xu , Derek Chickles , drivers@pensando.io, Felix Manlunas , Florian Fainelli , Geetha sowjanya , Greg Kroah-Hartman , GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com, hariprasad , Ido Schimmel , Intel Corporation , intel-wired-lan@lists.osuosl.org, Ioana Ciornei , Jerin Jacob , Jesse Brandeburg , Jiri Pirko , Jonathan Lemon , Linu Cherian , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev, Loic Poulain , Manish Chopra , M Chetan Kumar , Michael Chan , Michael Guralnik , netdev@vger.kernel.org, oss-drivers@corigine.com, Richard Cochran , Saeed Mahameed , Satanand Burla , Sergey Ryazanov , Shannon Nelson , Simon Horman , Subbaraya Sundeep , Sunil Goutham , Taras Chornyi , Tariq Toukan , Tony Nguyen , UNGLinuxDriver@microchip.com, Vadym Kochan , Vivien Didelot , Vladimir Oltean Subject: Re: [PATCH net-next v1 01/21] devlink: Notify users when objects are accessible Message-ID: References: <0f7f201a059b24c96eac837e1f424e2483254e1c.1632565508.git.leonro@nvidia.com> <97c1ba9d-52b9-5689-19ab-ad4a82e55ae2@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <97c1ba9d-52b9-5689-19ab-ad4a82e55ae2@gmail.com> On Mon, Sep 27, 2021 at 07:49:18PM -0700, Eric Dumazet wrote: > > > On 9/25/21 4:22 AM, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The devlink core code notified users about add/remove objects without > > relation if this object can be accessible or not. In this patch we unify > > such user visible notifications in one place. > > > > Signed-off-by: Leon Romanovsky > > --- > > net/core/devlink.c | 107 +++++++++++++++++++++++++++++++++++++++------ > > 1 file changed, 93 insertions(+), 14 deletions(-) <...> > > static void devlink_rate_notify(struct devlink_rate *devlink_rate, > > enum devlink_command cmd) > > { > > + struct devlink *devlink = devlink_rate->devlink; > > struct sk_buff *msg; > > int err; > > > > WARN_ON(cmd != DEVLINK_CMD_RATE_NEW && cmd != DEVLINK_CMD_RATE_DEL); > > + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED)); > > > FYI, this new warning was triggered by syzbot : Thanks for the report, it is combination of my rebase error and missing loop of devlink_rate_notify in the devlink_notify_register() function. I'll fix and resubmit. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Date: Tue, 28 Sep 2021 10:34:33 +0300 Subject: [Intel-wired-lan] [PATCH net-next v1 01/21] devlink: Notify users when objects are accessible In-Reply-To: <97c1ba9d-52b9-5689-19ab-ad4a82e55ae2@gmail.com> References: <0f7f201a059b24c96eac837e1f424e2483254e1c.1632565508.git.leonro@nvidia.com> <97c1ba9d-52b9-5689-19ab-ad4a82e55ae2@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Mon, Sep 27, 2021 at 07:49:18PM -0700, Eric Dumazet wrote: > > > On 9/25/21 4:22 AM, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The devlink core code notified users about add/remove objects without > > relation if this object can be accessible or not. In this patch we unify > > such user visible notifications in one place. > > > > Signed-off-by: Leon Romanovsky > > --- > > net/core/devlink.c | 107 +++++++++++++++++++++++++++++++++++++++------ > > 1 file changed, 93 insertions(+), 14 deletions(-) <...> > > static void devlink_rate_notify(struct devlink_rate *devlink_rate, > > enum devlink_command cmd) > > { > > + struct devlink *devlink = devlink_rate->devlink; > > struct sk_buff *msg; > > int err; > > > > WARN_ON(cmd != DEVLINK_CMD_RATE_NEW && cmd != DEVLINK_CMD_RATE_DEL); > > + WARN_ON(!xa_get_mark(&devlinks, devlink->index, DEVLINK_REGISTERED)); > > > FYI, this new warning was triggered by syzbot : Thanks for the report, it is combination of my rebase error and missing loop of devlink_rate_notify in the devlink_notify_register() function. I'll fix and resubmit. Thanks