On Fri, Oct 01, 2021 at 01:50:58PM +0800, Herbert Xu wrote: > On Tue, Sep 28, 2021 at 11:32:09AM -0700, Nathan Chancellor wrote: > > > > This patch as commit 3cefb01905df ("crypto: api - Fix built-in testing > > dependency failures") in -next (along with the follow up fix) causes the > > following depmod error: > > > > $ make -skj"$(nproc)" ARCH=powerpc CROSS_COMPILE=powerpc-linux- INSTALL_MOD_PATH=rootfs ppc44x_defconfig all modules_install > > depmod: ERROR: Cycle detected: crypto -> crypto_algapi -> crypto > > depmod: ERROR: Found 2 modules in dependency cycles! > > make: *** [Makefile:1946: modules_install] Error 1 > > > > Initially reported on our CI: > > > > https://github.com/ClangBuiltLinux/continuous-integration2/runs/3732847295?check_suite_focus=true > > That's weird, I can't reproduce this. Where can I find your Kconfig > file? Alternatively, can you identify exactly what is in algapi that > is being depended on by crypto? I have attached the Kconfig file that I used to reproduce it. It is still reproducible for me at your latest commit in cryptodev (e42dff467ee688fe6b5a083f1837d06e3b27d8c0) with that exact command that I gave you. It is possible that it could be crypto_boot_test_finished? Cheers, Nathan