All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Zhaolong Zhang <zhangzl2013@126.com>
Cc: Tony Luck <tony.luck@intel.com>,
	x86@kernel.org, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH] x86/mce: drop cpu_missing since we have more capable mce_missing_cpus
Date: Mon, 8 Nov 2021 10:31:52 +0100	[thread overview]
Message-ID: <YYjuiHN1wKt82fjs@zn.tnic> (raw)
In-Reply-To: <20211108082832.142436-1-zhangzl2013@126.com>

On Mon, Nov 08, 2021 at 04:28:32PM +0800, Zhaolong Zhang wrote:
> move mce_missing_cpus checking into mce_panic() as well, because we don't want
> to lose the cpu missing information in case mca_cfg.tolerant > 1 and there is
> no_way_out.
> 
> Signed-off-by: Zhaolong Zhang <zhangzl2013@126.com>
> ---
>  arch/x86/kernel/cpu/mce/core.c | 38 ++++++++++++++++++++--------------
>  1 file changed, 22 insertions(+), 16 deletions(-)

I was actually expecting to see something like this:

diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 6ed365337a3b..30de00fe0d7a 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -99,7 +99,6 @@ struct mca_config mca_cfg __read_mostly = {
 
 static DEFINE_PER_CPU(struct mce, mces_seen);
 static unsigned long mce_need_notify;
-static int cpu_missing;
 
 /*
  * MCA banks polled by the period polling timer for corrected events.
@@ -314,8 +313,6 @@ static void mce_panic(const char *msg, struct mce *final, char *exp)
 		if (!apei_err)
 			apei_err = apei_write_mce(final);
 	}
-	if (cpu_missing)
-		pr_emerg(HW_ERR "Some CPUs didn't answer in synchronization\n");
 	if (exp)
 		pr_emerg(HW_ERR "Machine check: %s\n", exp);
 	if (!fake_panic) {
@@ -891,7 +888,6 @@ static int mce_timed_out(u64 *t, const char *msg)
 					 cpumask_pr_args(&mce_missing_cpus));
 			mce_panic(msg, NULL, NULL);
 		}
-		cpu_missing = 1;
 		return 1;
 	}
 	*t -= SPINUNIT;
@@ -2702,7 +2698,6 @@ struct dentry *mce_get_debugfs_dir(void)
 
 static void mce_reset(void)
 {
-	cpu_missing = 0;
 	atomic_set(&mce_fake_panicked, 0);
 	atomic_set(&mce_executing, 0);
 	atomic_set(&mce_callin, 0);

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2021-11-08  9:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04  7:44 [PATCH] x86/mce: correct cpu_missing reporting in mce_timed_out Zhaolong Zhang
2021-11-04  9:13 ` Borislav Petkov
2021-11-04 15:47   ` Luck, Tony
2021-11-04 18:02     ` Borislav Petkov
2021-11-05  2:19       ` Zhaolong Zhang
2021-11-08  8:28         ` [PATCH] x86/mce: drop cpu_missing since we have more capable mce_missing_cpus Zhaolong Zhang
2021-11-08  9:31           ` Borislav Petkov [this message]
2021-11-08 10:13             ` Zhaolong Zhang
2021-11-08 10:31               ` Borislav Petkov
2021-11-08 12:47                 ` Zhaolong Zhang
2021-11-09  8:31                   ` Zhaolong Zhang
2021-11-09  8:35                     ` [PATCH] x86/mce: Get rid of cpu_missing Zhaolong Zhang
2021-11-09  9:15                       ` Borislav Petkov
2021-11-09 14:19                         ` Zhaolong Zhang
2021-11-09  9:07                     ` [PATCH] x86/mce: drop cpu_missing since we have more capable mce_missing_cpus Borislav Petkov
2021-11-09 16:06                       ` Luck, Tony
2021-11-09 19:48                         ` Borislav Petkov
2021-11-09 19:50                           ` Luck, Tony
2021-11-09 20:21                             ` Borislav Petkov
2021-11-09 20:44                               ` Luck, Tony
2021-11-09 21:30                                 ` Borislav Petkov
2021-12-20 20:43                                   ` [PATCH] x86/mce: Remove the tolerance level control Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYjuiHN1wKt82fjs@zn.tnic \
    --to=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=zhangzl2013@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.