From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32C02C433FE for ; Mon, 8 Nov 2021 23:55:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18A9C610F7 for ; Mon, 8 Nov 2021 23:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241059AbhKHX6Z (ORCPT ); Mon, 8 Nov 2021 18:58:25 -0500 Received: from mail-lf1-f44.google.com ([209.85.167.44]:45044 "EHLO mail-lf1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238960AbhKHX6Y (ORCPT ); Mon, 8 Nov 2021 18:58:24 -0500 Received: by mail-lf1-f44.google.com with SMTP id y26so40004890lfa.11; Mon, 08 Nov 2021 15:55:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4CObGnDxrsjK7sTGFat7Zks+uHyi7ssYo0SjQ3zRggg=; b=gzsMerwGaPJDiyUAqTqq5Xn/NDL+5DGNMCe4sKO7hL4qYVmJLLcEv0KbrYXT5L/fir 6aBOOEtp0ixS+gWqbq87MAFoEizenSZYlgbpZvgg21p1PqtB+5tS92IDW+jmNOgrQs8u 2NI7rwxauQK+J05mct39W0k3vR2tYRyZB5SBI671g4dng8wQk7TCMLAUZ7uNRtQonIil SsegP22JmTuI4/L0nn7sp0mkyI4uwqf3lvAUTxY0chmJMkwomGBzqli27n1vPY992H1V khNvKf5gdVqjzSKeOv6SUhYXkVXQsf0OeTXogbsPTCceSuoKrWlgeJljwqpqgJzFh66W IHow== X-Gm-Message-State: AOAM530DS3MsrhGNXFBBFER1rDE69h3ljLkq129lrLStlVSqScjM++0W q4UGtSvVFziRXf+WZwIgr3o= X-Google-Smtp-Source: ABdhPJyBWbQ4bYNqx4D5Qjh1mgT+vdR6DFZ0Qz3rPz0NaYb7fGBGV/aU2B/9sLpgP791scUISjxZ5w== X-Received: by 2002:a05:6512:4012:: with SMTP id br18mr2989138lfb.674.1636415737667; Mon, 08 Nov 2021 15:55:37 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id l10sm288823lfg.125.2021.11.08.15.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 15:55:37 -0800 (PST) Date: Tue, 9 Nov 2021 00:55:36 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Florian Fainelli Cc: Christophe JAILLET , nsaenz@kernel.org, jim2101024@gmail.com, bcm-kernel-feedback-list@broadcom.com, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' Message-ID: References: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, [...] > >>>> Jim, Florian and Lorenzo - is this something that would be OK with you, > >>>> or you would rather keep things as they were? > >>> > >>> I would be tempted to leave the code as-is, but if we do we are probably > >>> bound to seeing patches like Christophe's in the future to address the > >> > >> Even if I don't find this report in the Coverity database, it should from > >> around April 2018. > >> So, if you have not already received several patches for that, I doubt that > >> you will receive many in the future. > >> > >> > >> My own feeling is that using a long (and not a long *) as a bitmap, and > >> accessing it with &long may look spurious to a reader. > >> That said, it works. > >> > >> So, I let you decide if the patch is of any use. Should I need to tweak or > >> resend it, let me know. > > > > I would be pro taking it, not only to addresses the Coverity complaint, but > > also to align the code with other drivers a little bit more. Only if > > the driver maintainers have no objection, that is. > > Driver consistency is a strong argument, fine with me then. Thank you! Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34AF4C433EF for ; Mon, 8 Nov 2021 23:56:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFEE9610EA for ; Mon, 8 Nov 2021 23:56:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DFEE9610EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qfzbZtT7Ia+cbRIlc+GJNETm40k6DXEVUeIzWz2hZ+A=; b=DKVpE0jTs8rLc2 nZWMY/tPs0z0kmF3Fry3FP6HwnFvPz5HO4x/JiQlpMAXxRoD9DCPBVyrmfwlDum7PGXk1drpPjVbi jFBhoAP0SU57commylj/CeFKy/KsqBypqhmkCNgvgN0wQOy5UPqFWP/SbMwKS4vIHp8cbbdMUO5FL w0Pqw0H6UwqnJXhBSF/g5D/ez6FzydvmdllGTTDJlrSKoLC5nczSUlU7OEVlh0fAz/iowkcjlWFpK k0Sbscp7bm6OrLX3xQ8oryLydtSvud5SZR1A/DUejpq3clZuDQJHoqWJfpY1y0/PTL4le/IJeht01 lm7PZChq0bjlCmJgu3NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkEUK-0001tC-Jy; Mon, 08 Nov 2021 23:55:44 +0000 Received: from mail-lf1-f44.google.com ([209.85.167.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkEUG-0001rm-Kk; Mon, 08 Nov 2021 23:55:41 +0000 Received: by mail-lf1-f44.google.com with SMTP id j2so40100871lfg.3; Mon, 08 Nov 2021 15:55:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4CObGnDxrsjK7sTGFat7Zks+uHyi7ssYo0SjQ3zRggg=; b=CKppF4hrGwHXeNLQyj7TNjyoGdF9cm7jQUK1dDpqIg845akUE7QD5EYVsEYJQXh4x9 py6qmSIsHZEYneGm/DJat0fXmKH0J7OZxMqXO3JtAnKiMr0loeLpMs0na1A4TWNcAvo+ DIqjY1CPBgIMVnA5iP3i6k6JLhZnYLfXby+RDYvP/1KvAot2mjYwhQY7J5ggE+3pF5hM cYpSLg/GnIGNSZHZhIn2LpY1nQuJkbdrdvUjL8cLRq32jsG1c2FzS85jgQxylWrxUBPV uw1ENn0OimMpo6T/zP7tTmEhiZZBlD/nhLbQWfh+yY6JWgHSuo/4ZMR2CTrIHrrVfAmR TeLA== X-Gm-Message-State: AOAM5315ntUBhTJe0jWjAwMaUtzTP0SSHCXALXZz1DtGE60msau7BJWW ohdwg8xvzP87aIfq7ID+uWM= X-Google-Smtp-Source: ABdhPJyBWbQ4bYNqx4D5Qjh1mgT+vdR6DFZ0Qz3rPz0NaYb7fGBGV/aU2B/9sLpgP791scUISjxZ5w== X-Received: by 2002:a05:6512:4012:: with SMTP id br18mr2989138lfb.674.1636415737667; Mon, 08 Nov 2021 15:55:37 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id l10sm288823lfg.125.2021.11.08.15.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 15:55:37 -0800 (PST) Date: Tue, 9 Nov 2021 00:55:36 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Florian Fainelli Cc: Christophe JAILLET , nsaenz@kernel.org, jim2101024@gmail.com, bcm-kernel-feedback-list@broadcom.com, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' Message-ID: References: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_155540_728469_E32BBDB8 X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Florian, [...] > >>>> Jim, Florian and Lorenzo - is this something that would be OK with you, > >>>> or you would rather keep things as they were? > >>> > >>> I would be tempted to leave the code as-is, but if we do we are probably > >>> bound to seeing patches like Christophe's in the future to address the > >> > >> Even if I don't find this report in the Coverity database, it should from > >> around April 2018. > >> So, if you have not already received several patches for that, I doubt that > >> you will receive many in the future. > >> > >> > >> My own feeling is that using a long (and not a long *) as a bitmap, and > >> accessing it with &long may look spurious to a reader. > >> That said, it works. > >> > >> So, I let you decide if the patch is of any use. Should I need to tweak or > >> resend it, let me know. > > > > I would be pro taking it, not only to addresses the Coverity complaint, but > > also to align the code with other drivers a little bit more. Only if > > the driver maintainers have no objection, that is. > > Driver consistency is a strong argument, fine with me then. Thank you! Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel