From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AA51C4332F for ; Mon, 8 Nov 2021 23:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C54761350 for ; Mon, 8 Nov 2021 23:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240956AbhKHXdO (ORCPT ); Mon, 8 Nov 2021 18:33:14 -0500 Received: from mail-ed1-f49.google.com ([209.85.208.49]:43536 "EHLO mail-ed1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240747AbhKHXdJ (ORCPT ); Mon, 8 Nov 2021 18:33:09 -0500 Received: by mail-ed1-f49.google.com with SMTP id w1so69562396edd.10; Mon, 08 Nov 2021 15:30:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4c9jRVTiEOAT2G+TczrZz0JB2x25zxtUp6Iq9kweQdk=; b=XmnaINPhvFwQe0hdIzoMH5JuVuPLEN3oN1qoAPQcfUzRnBMWr6wMiFVaSBr/BC2ovE lgfnTR+RyXnfaivM1ppGPHTujCsU4TAWifwRQMj8r+gNNQj4sPOIdtq8eS6TSGl32ZLc MG4Tguo5Kf1eRojD55/5mUwe1kDVFdgjynJSadhrBvNCSJs7xJOr0b10s2w18DdKISiU OvHPtxY6+jCrDnXQJ6ord0pRRtggTC/NUHQxR1wGjbLu52XP6+QV1m21sthdAJXTG1y5 Z2zA2MW0F2BXMDB+ndXstJetld8YBVqvMo3FFMSQcS/ghesysvckOh7NeatW6EvQJKLE rDlw== X-Gm-Message-State: AOAM533GKlr15oWE4+GXWVZZWOuivv06vHB89MrxptRiPNWNHDPKgkYI ADsmm2lGbKUA2x2XMJE+7v8= X-Google-Smtp-Source: ABdhPJys8NT5dfq5Lddj/S7xPCmtxJrgTHYB2WWsp3uqzbIbw1reXNcrnC9CFA6c4kiJhWpEA+oZzg== X-Received: by 2002:a17:906:12d0:: with SMTP id l16mr3561291ejb.415.1636414223297; Mon, 08 Nov 2021 15:30:23 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id hq37sm9073999ejc.116.2021.11.08.15.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 15:30:22 -0800 (PST) Date: Tue, 9 Nov 2021 00:30:21 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Christophe JAILLET Cc: Florian Fainelli , nsaenz@kernel.org, jim2101024@gmail.com, bcm-kernel-feedback-list@broadcom.com, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' Message-ID: References: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, [...] > > > Jim, Florian and Lorenzo - is this something that would be OK with you, > > > or you would rather keep things as they were? > > > > I would be tempted to leave the code as-is, but if we do we are probably > > bound to seeing patches like Christophe's in the future to address the > > Even if I don't find this report in the Coverity database, it should from > around April 2018. > So, if you have not already received several patches for that, I doubt that > you will receive many in the future. > > > My own feeling is that using a long (and not a long *) as a bitmap, and > accessing it with &long may look spurious to a reader. > That said, it works. > > So, I let you decide if the patch is of any use. Should I need to tweak or > resend it, let me know. I would be pro taking it, not only to addresses the Coverity complaint, but also to align the code with other drivers a little bit more. Only if the driver maintainers have no objection, that is. Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5455DC433EF for ; Mon, 8 Nov 2021 23:31:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C94A61167 for ; Mon, 8 Nov 2021 23:31:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C94A61167 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=umbV2ZHo5A8kERdS8iMn38zVau6y5y57p5FW/1YjWBg=; b=vcCOo99VAWAmSM AP//GgnDOFkdMuhAYGb6JcDu7sY10lLjylQv4E3O4gBUON5JNUChRlj3cBHL+OkRYEKgakb48W5cC W6gbmlIWlUJ6zd5zHMSsOujekL4x/PeN90mNchytxUhiUdyV6O7CzFAWWcCzlUSpI3t8YkxifAcf3 cCkLWXof/POYKXlcTpMCM0wfWMm+x14dfcSP846Ko8y2YKy9sZ6VR+pN218ut5/XsCbXPvlrl+bf1 dX4XwfASCkobREjzfwlSA5BuaK34lp6ZzYIWZiJ1A5DZ3EaFz8wmkoEl7lr9O3aMLyyUoo2AaDBQ8 t8OSBRSupne3WsV1ZPEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkE5v-00HajL-C1; Mon, 08 Nov 2021 23:30:31 +0000 Received: from mail-ed1-f45.google.com ([209.85.208.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkE5q-00Haiq-Lr; Mon, 08 Nov 2021 23:30:27 +0000 Received: by mail-ed1-f45.google.com with SMTP id o8so69031246edc.3; Mon, 08 Nov 2021 15:30:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4c9jRVTiEOAT2G+TczrZz0JB2x25zxtUp6Iq9kweQdk=; b=sn34ZhJ3f6FLQ6zMupdaYHR6PebRxchK+ZTNaK07x0Bi0MJhGlERTJfbO3l/bdyfLx RQORGiHYUSort+5DTmULqNztBLjdbCMm2ACWOhFqcRw+kDn/p/2706RDy8FosEWriNrh g/960L9LvX78HOb0GBP+H3u1KnmSoDLVpG9+s5VBweMC226k7hkuyKn0OTsqtx7S6FfK HcI2XEpuvwazLcnbP6872DQrASIFxE/nZCoM27hG490QvX/WmyTK9EvxiQzjqoe0SiRC VY3KihJ2Jy73DAMyyZFc+2QqoaGyKUeIfWbitlGl+FOyt3VNhw21YJRJnWUcHsYRXTcG 7cwQ== X-Gm-Message-State: AOAM532fiYN8VPNZnVLts1IpK/mxTWsQDxOr9aozSqn+p5fnC8hm1jXy gNqkSwdkYHNSX2Q3eHmYSk8= X-Google-Smtp-Source: ABdhPJys8NT5dfq5Lddj/S7xPCmtxJrgTHYB2WWsp3uqzbIbw1reXNcrnC9CFA6c4kiJhWpEA+oZzg== X-Received: by 2002:a17:906:12d0:: with SMTP id l16mr3561291ejb.415.1636414223297; Mon, 08 Nov 2021 15:30:23 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id hq37sm9073999ejc.116.2021.11.08.15.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 15:30:22 -0800 (PST) Date: Tue, 9 Nov 2021 00:30:21 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Christophe JAILLET Cc: Florian Fainelli , nsaenz@kernel.org, jim2101024@gmail.com, bcm-kernel-feedback-list@broadcom.com, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' Message-ID: References: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_153026_737417_5A687392 X-CRM114-Status: GOOD ( 19.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, [...] > > > Jim, Florian and Lorenzo - is this something that would be OK with you, > > > or you would rather keep things as they were? > > > > I would be tempted to leave the code as-is, but if we do we are probably > > bound to seeing patches like Christophe's in the future to address the > > Even if I don't find this report in the Coverity database, it should from > around April 2018. > So, if you have not already received several patches for that, I doubt that > you will receive many in the future. > > > My own feeling is that using a long (and not a long *) as a bitmap, and > accessing it with &long may look spurious to a reader. > That said, it works. > > So, I let you decide if the patch is of any use. Should I need to tweak or > resend it, let me know. I would be pro taking it, not only to addresses the Coverity complaint, but also to align the code with other drivers a little bit more. Only if the driver maintainers have no objection, that is. Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel