From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net
Subject: Re: [PATCH net 2/2] net: phylink: Force retrigger in case of latched link-fail indicator
Date: Tue, 23 Nov 2021 11:21:37 +0000 [thread overview]
Message-ID: <YZzOwfkkdDVHr+jc@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211122235154.6392-3-kabel@kernel.org>
On Tue, Nov 23, 2021 at 12:51:54AM +0100, Marek Behún wrote:
> On mv88e6xxx 1G/2.5G PCS, the SerDes register 4.2001.2 has the following
> description:
> This register bit indicates when link was lost since the last
> read. For the current link status, read this register
> back-to-back.
>
> Thus to get current link state, we need to read the register twice.
>
> But doing that in the link change interrupt handler would lead to
> potentially ignoring link down events, which we really want to avoid.
>
> Thus this needs to be solved in phylink's resolve, by retriggering
> another resolve in the event when PCS reports link down and previous
> link was up.
>
> The wrong value is read when phylink requests change from sgmii to
> 2500base-x mode, and link won't come up. This fixes the bug.
>
> Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Marek Behún <kabel@kernel.org>
Same issue with this patch wrt authorship vs sign-off.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-11-23 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 23:51 [PATCH net 0/2] Marek Behún
2021-11-22 23:51 ` [PATCH net 1/2] net: phylink: Force link down and retrigger resolve on interface change Marek Behún
2021-11-23 11:20 ` Russell King (Oracle)
2021-11-23 12:12 ` Marek Behún
2021-11-22 23:51 ` [PATCH net 2/2] net: phylink: Force retrigger in case of latched link-fail indicator Marek Behún
2021-11-23 11:21 ` Russell King (Oracle) [this message]
2021-11-23 11:40 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZzOwfkkdDVHr+jc@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.