From: Peter Xu <peterx@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 2/2] intel_iommu: Only allow interrupt remapping to be enabled if it's supported
Date: Fri, 3 Dec 2021 15:42:14 +0800 [thread overview]
Message-ID: <YanKVrNFRq/BO5Ew@xz-m1.local> (raw)
In-Reply-To: <CACGkMEvtrVX8uWciiVfYpBNsaAwRAfP_P4Ja3T4Axvn47WdzNw@mail.gmail.com>
On Thu, Dec 02, 2021 at 11:53:25AM +0800, Jason Wang wrote:
> On Thu, Dec 2, 2021 at 4:58 AM David Woodhouse <dwmw2@infradead.org> wrote:
> >
> > From: David Woodhouse <dwmw@amazon.co.uk>
> >
> > We should probably check if we were meant to be exposing IR, before
> > letting the guest turn the IRE bit on.
>
> This looks correct, but it's a change of guest noticeable behaviour.
> It's probably fine since we don't expect a guest that enable IR
> without checking ecap.
Agreed.
>
> So
>
> Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2021-12-03 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 20:51 [PATCH 1/2] intel_iommu: Support IR-only mode without DMA translation David Woodhouse
2021-12-01 20:51 ` [PATCH 2/2] intel_iommu: Only allow interrupt remapping to be enabled if it's supported David Woodhouse
2021-12-02 3:53 ` Jason Wang
2021-12-03 7:42 ` Peter Xu [this message]
2021-12-02 3:49 ` [PATCH 1/2] intel_iommu: Support IR-only mode without DMA translation Jason Wang
2021-12-03 7:38 ` Peter Xu
2021-12-03 10:46 ` David Woodhouse
2021-12-03 12:14 ` Peter Xu
2021-12-06 6:49 ` Jason Wang
-- strict thread matches above, loose matches on Subject: below --
2020-10-15 18:34 David Woodhouse
2020-10-15 18:34 ` [PATCH 2/2] intel_iommu: Only allow interrupt remapping to be enabled if it's supported David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YanKVrNFRq/BO5Ew@xz-m1.local \
--to=peterx@redhat.com \
--cc=dwmw2@infradead.org \
--cc=ehabkost@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.