From: Eric Biggers <ebiggers@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
linux-doc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 6/8] docs: sysfs-block: document virt_boundary_mask
Date: Wed, 8 Dec 2021 14:38:26 -0800 [thread overview]
Message-ID: <YbEz4pq2xMfAufwJ@gmail.com> (raw)
In-Reply-To: <13462e59-82f3-d6fc-a84e-2cf3083e0cc7@acm.org>
On Wed, Dec 08, 2021 at 10:33:19AM -0800, Bart Van Assche wrote:
> On 12/7/21 4:56 PM, Eric Biggers wrote:
> > +What: /sys/block/<disk>/queue/virt_boundary_mask
> > +Date: April 2021
> > +Contact: linux-block@vger.kernel.org
> > +Description:
> > + [RO] This file shows the I/O segment alignment mask for the
> > + block device. I/O requests to this device will be split between
> > + segments wherever either the end of the previous segment or the
> > + beginning of the current segment is not aligned to
> > + virt_boundary_mask + 1 bytes.
>
> "I/O segment alignment" looks confusing to me. My understanding is that this
> attribute refers to the alignment of the internal data buffer boundaries and not
> to the alignment of the offset on the storage medium. The name "virt_boundary"
> refers to the property that if all internal boundaries are a multiple of
> (virt_boundary_mask + 1) then an MMU with page size (virt_boundary_mask + 1) can
> map the entire data buffer onto a contiguous range of virtual addresses. E.g.
> RDMA adapters have an MMU that can do this. Several drivers that set this
> attribute support a storage controller that does not have an internal MMU. As an
> example, the NVMe core sets this mask since the NVMe specification requires that
> only the first element in a PRP list has a non-zero offset. From the NVMe
> specification: "PRP entries contained within a PRP List shall have a memory page
> offset of 0h. If a second PRP entry is present within a command, it shall have a
> memory page offset of 0h. In both cases, the entries are memory".
Sure, I meant for it to be talking about the memory addresses. How about this:
[RO] This file shows the I/O segment memory alignment mask for
the block device. I/O requests to this device will be split
between segments wherever either the memory address of the end
of the previous segment or the memory address of the beginning
of the current segment is not aligned to virt_boundary_mask + 1
bytes.
- Eric
next prev parent reply other threads:[~2021-12-08 22:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 0:56 [PATCH v2 0/8] docs: consolidate sysfs-block into Documentation/ABI/ Eric Biggers
2021-12-08 0:56 ` [PATCH v2 1/8] docs: sysfs-block: move to stable directory Eric Biggers
2021-12-08 0:56 ` [PATCH v2 2/8] docs: sysfs-block: sort alphabetically Eric Biggers
2021-12-08 0:56 ` [PATCH v2 3/8] docs: sysfs-block: add contact for nomerges Eric Biggers
2021-12-08 0:56 ` [PATCH v2 4/8] docs: sysfs-block: fill in missing documentation from queue-sysfs.rst Eric Biggers
2021-12-08 0:56 ` [PATCH v2 5/8] docs: sysfs-block: document stable_writes Eric Biggers
2021-12-08 18:01 ` Bart Van Assche
2021-12-08 22:34 ` Eric Biggers
2021-12-08 22:59 ` Bart Van Assche
2021-12-08 0:56 ` [PATCH v2 6/8] docs: sysfs-block: document virt_boundary_mask Eric Biggers
2021-12-08 18:33 ` Bart Van Assche
2021-12-08 22:38 ` Eric Biggers [this message]
2021-12-08 22:59 ` Bart Van Assche
2021-12-08 0:56 ` [PATCH v2 7/8] docs: block: remove queue-sysfs.rst Eric Biggers
2021-12-08 0:56 ` [PATCH v2 8/8] MAINTAINERS: add entries for block layer documentation Eric Biggers
2021-12-08 3:01 ` [PATCH v2 0/8] docs: consolidate sysfs-block into Documentation/ABI/ Martin K. Petersen
2021-12-08 18:35 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbEz4pq2xMfAufwJ@gmail.com \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.