From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "open list:THUNDERBOLT DRIVER" <linux-usb@vger.kernel.org>,
linux-kernel@vger.kernel.org, Sanju.Mehta@amd.com
Subject: Re: [PATCH 2/5] drivers/thunderbolt: don't resume switches without uid set
Date: Thu, 3 Mar 2022 09:43:38 +0200 [thread overview]
Message-ID: <YiBxqkG9iB9x8SMW@lahna> (raw)
In-Reply-To: <20220302220709.3138846-2-mario.limonciello@amd.com>
Hi Mario,
On Wed, Mar 02, 2022 at 04:07:06PM -0600, Mario Limonciello wrote:
> Switches might not have a uid set if the DROM read failed during
That's "Routers" and "UID" :)
Also $subject should have prefix "thunderbolt: " not
"drivers/thunderbolt". Please capitalize the summary too:
thunderbolt: Do not resume routers if UID is not set
The patch itself looks good to me.
> initialization previously.
>
> Normally upon resume the uid is re-read to confirm it's the same
> device connected.
> * If the DROM read failed during init but then succeeded during
> resume it could either be a new device or faulty device
> * If the DROM read failed during init and also failed during resume
> it might be a different device plugged in all together.
>
> Detect this situation and prevent re-using the same configuration in
> these cirucmstances.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/thunderbolt/switch.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
> index b5fb3e76ed09..294518af4ee4 100644
> --- a/drivers/thunderbolt/switch.c
> +++ b/drivers/thunderbolt/switch.c
> @@ -2980,6 +2980,10 @@ int tb_switch_resume(struct tb_switch *sw)
> return err;
> }
>
> + /* We don't have any way to confirm this was the same device */
> + if (!sw->uid)
> + return -ENODEV;
> +
> if (tb_switch_is_usb4(sw))
> err = usb4_switch_read_uid(sw, &uid);
> else
> --
> 2.34.1
next prev parent reply other threads:[~2022-03-03 7:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 22:07 [PATCH 1/5] drivers/thunderbolt: Retry DROM reads for more failure scenarios Mario Limonciello
2022-03-02 22:07 ` [PATCH 2/5] drivers/thunderbolt: don't resume switches without uid set Mario Limonciello
2022-03-03 7:43 ` Mika Westerberg [this message]
2022-03-02 22:07 ` [PATCH 3/5] drivers/thunderbolt: Don't make DROM read success compulsory Mario Limonciello
2022-03-03 7:47 ` Mika Westerberg
2022-03-02 22:07 ` [PATCH 4/5] drivers/thunderbolt: Clarify/correct register offsets for tb_cap_plug_events Mario Limonciello
2022-03-03 7:54 ` Mika Westerberg
2022-03-02 22:07 ` [PATCH 5/5] drivers/thunderbolt: Rename EEPROM handling bits to match USB4 spec Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiBxqkG9iB9x8SMW@lahna \
--to=mika.westerberg@linux.intel.com \
--cc=Sanju.Mehta@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.