From: Peter Zijlstra <peterz@infradead.org>
To: Donghai Qiao <dqiao@redhat.com>
Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au, arnd@arndb.de,
heying24@huawei.com, andriy.shevchenko@linux.intel.com,
axboe@kernel.dk, rdunlap@infradead.org, tglx@linutronix.de,
gor@linux.ibm.com, donghai.w.qiao@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/11] smp: cross CPU call interface
Date: Fri, 15 Apr 2022 14:13:07 +0200 [thread overview]
Message-ID: <YllhUx6g7ySAtk9k@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20220415024701.876364-1-dqiao@redhat.com>
On Thu, Apr 14, 2022 at 10:46:50PM -0400, Donghai Qiao wrote:
> The motivation of submitting this patch set is intended to make the
> existing cross CPU call mechanism become a bit more formal interface
> and more friendly to the kernel developers.
>
> Basically the minimum set of functions below can satisfy any demand
> for cross CPU call from kernel consumers. For the sack of simplicity
> self-explanatory and less code redundancy no ambiguity, the functions
> in this interface are renamed, simplified, or eliminated. But they
> are still inheriting the same semantics and parameter lists from their
> previous version.
>
> int smp_xcall(int cpu, smp_call_func_t func, void *info, unsigned int flags)
>
> int smp_xcall_cond(int cpu, smp_call_func_t func, void *info,
> smp_cond_func_t condf, unsigned int flags)
>
> void smp_xcall_mask(const struct cpumask *mask, smp_call_func_t func,
> void *info, unsigned int flags)
>
> void smp_xcall_mask_cond(const struct cpumask *mask, smp_call_func_t func,
> void *info, smp_cond_func_t condf, unsigned int flags)
>
> int smp_xcall_private(int cpu, call_single_data_t *csd, unsigned int flags)
>
> int smp_xcall_any(const struct cpumask *mask, smp_call_func_t func,
> void *info, unsigned int flags)
>
Can we please remove that x? That's going to be horrible pain for a long
time to come.
prev parent reply other threads:[~2022-04-15 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 2:46 [PATCH 00/11] smp: cross CPU call interface Donghai Qiao
2022-04-15 2:46 ` [PATCH 01/11] smp: consolidate the structure definitions to smp.h Donghai Qiao
2022-04-15 2:46 ` [PATCH 02/11] smp: cross call interface Donghai Qiao
2022-04-15 2:46 ` [PATCH 03/11] smp: eliminate SCF_WAIT and SCF_RUN_LOCAL Donghai Qiao
2022-04-15 2:46 ` [PATCH 04/11] smp: replace smp_call_function_single() with smp_xcall() Donghai Qiao
2022-04-15 2:46 ` [PATCH 05/11] smp: replace smp_call_function_single_async() with smp_xcall_private() Donghai Qiao
2022-04-15 2:46 ` [PATCH 06/11] smp: use smp_xcall_private() fron irq_work.c and core.c Donghai Qiao
2022-04-15 2:46 ` [PATCH 07/11] smp: change smp_call_function_any() to smp_xcall_any() Donghai Qiao
2022-04-15 2:46 ` [PATCH 08/11] smp: replace smp_call_function_many_cond() with __smp_call_mask_cond() Donghai Qiao
2022-04-15 2:46 ` [PATCH 09/11] smp: replace smp_call_function_single_async with smp_xcall_private Donghai Qiao
2022-04-15 2:47 ` [PATCH 10/11] smp: replace smp_call_function_single() with smp_xcall() Donghai Qiao
2022-04-15 2:47 ` [PATCH 11/11] smp: modify up.c to adopt the same format of cross CPU call Donghai Qiao
2022-04-15 12:13 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YllhUx6g7ySAtk9k@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=donghai.w.qiao@gmail.com \
--cc=dqiao@redhat.com \
--cc=gor@linux.ibm.com \
--cc=heying24@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.