From: Greg KH <gregkh@linuxfoundation.org>
To: Manjunatha Venkatesh <manjunatha.venkatesh@nxp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"will@kernel.org" <will@kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"mb@lightnvm.io" <mb@lightnvm.io>,
"ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
"arnd@arndb.d" <arnd@arndb.d>, "mst@redhat.com" <mst@redhat.com>,
"javier@javigon.com" <javier@javigon.com>,
"mikelley@microsoft.com" <mikelley@microsoft.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"sunilmut@microsoft.com" <sunilmut@microsoft.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"rvmanjumce@gmail.com" <rvmanjumce@gmail.com>,
Ashish Deshpande <ashish.deshpande@nxp.com>
Subject: Re: [EXT] Re: [PATCH] Uwb: Nxp: sr1xx: Uwb driver support for sr1xx series chip
Date: Wed, 27 Apr 2022 08:37:41 +0200 [thread overview]
Message-ID: <YmjktXZDb5ELR8Xp@kroah.com> (raw)
In-Reply-To: <AM6PR04MB6407537BDB702B3D8C2BC73A8FFA9@AM6PR04MB6407.eurprd04.prod.outlook.com>
On Wed, Apr 27, 2022 at 06:24:14AM +0000, Manjunatha Venkatesh wrote:
> Hello Greg,
>
> Thanks for sharing your comments with us and apologies for our delayed
> response.
> We have done a thorough review internally and would like to put forward a
> proposal for your consideration.
>
> 1) In our next submission we will define the kernel/user API clearly with
> kernel pre-defined IOCTL macros in the uapi header file and follow the
> standard IOCTL rules.
Why do you need ioctls at all? Anyway, submit the code and we can
review the api then, I have no recollection of the previous submission
as it was thousands of patches ago.
> 2) We agree that this is a simple driver which may not need a dedicated
> directory under Linux/drivers so we will move the driver to "misc" folder.
> 3) We can also share some applications which show the usage of these driver
> API's from the user space.
That's great, submit away!
greg k-h
prev parent reply other threads:[~2022-04-27 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 12:37 [PATCH] Uwb: Nxp: sr1xx: Uwb driver support for sr1xx series chip Manjunatha Venkatesh
2022-03-07 13:16 ` Greg KH
2022-03-15 10:43 ` [EXT] " Manjunatha Venkatesh
2022-03-15 12:31 ` Greg KH
2022-04-27 6:24 ` Manjunatha Venkatesh
2022-04-27 6:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmjktXZDb5ELR8Xp@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.d \
--cc=ashish.deshpande@nxp.com \
--cc=axboe@kernel.dk \
--cc=bjorn.andersson@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=jasowang@redhat.com \
--cc=javier@javigon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manjunatha.venkatesh@nxp.com \
--cc=mb@lightnvm.io \
--cc=mikelley@microsoft.com \
--cc=mst@redhat.com \
--cc=rvmanjumce@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.