From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E342C43217 for ; Thu, 5 May 2022 19:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385000AbiEETal (ORCPT ); Thu, 5 May 2022 15:30:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232129AbiEETaf (ORCPT ); Thu, 5 May 2022 15:30:35 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B90734652; Thu, 5 May 2022 12:26:46 -0700 (PDT) Received: from leknes.fjasle.eu ([46.142.98.182]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MiIhU-1oH5uO3YH8-00fPtT; Thu, 05 May 2022 21:25:22 +0200 Received: by leknes.fjasle.eu (Postfix, from userid 1000) id 38E543C088; Thu, 5 May 2022 21:25:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1651778720; bh=Cwl4zkdeQcVXSxZ/RPcnVgB7zM8oGINbzVc8Y2VMFBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PwCfqkixa12sjKmUlkGN0KNMba5H+CtsWqxRGlVdXRptb7TBIoy0BO7Sc1zRukI0i EvUm1lkuiTNGLNT1bpJs98zozgIt6sLhIAOebglqQmNOD+itcraoJUvz+J1M7FySUT 6hRW+SHN7GBvySLN/CpZb48xBVsXn+jeS7J2nWak= Date: Thu, 5 May 2022 21:25:20 +0200 From: Nicolas Schier To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Ard Biesheuvel , Luis Chamberlain , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-um@lists.infradead.org, linux-s390@vger.kernel.org, Nick Desaulniers , Sami Tolvanen , Kees Cook Subject: Re: [PATCH v3 01/15] modpost: mitigate false-negatives for static EXPORT_SYMBOL checks Message-ID: References: <20220505072244.1155033-1-masahiroy@kernel.org> <20220505072244.1155033-2-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220505072244.1155033-2-masahiroy@kernel.org> X-Provags-ID: V03:K1:453ge2nHJXg6JLo5cZeMgSEFhVvVa0swhzjR0uQKtW94gAuyPQc MTjdF1f5pbFygWaA0SosWLKNmyUdXwFK1CUqAPSkq2SKzmSgl51MwQo6xoMn3Z2qWshs+mq zUww0m+Vg1VGGeeohNre8BVjxjh7qSjrYTbvLGMl0VUFNN4UdaEPPhevVoj5lG7DWNaJkaT +cWvR/fsod9psxrnhT2vQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:E/c3KfkTYqI=:WfyzXN1Ql6zaAT4DiqwkTJ g6eBKNFCR1ckva7OwYLJxj89Ptoc7lU/QO4lc4dF5H5MR2oC9dEcNMIvgldHzZ1mwtZO3jDSa kxXT3P45Oly90jDN6piciVbpmS5PiIN98iFiMY3xWoFqxSTsPukcGbRFtCCtqCpdJFGsxrvUv 50PptUYBB9qVbLMaGXWWcKdHnFpYHU85kTiui3ORX1eGuyp6gSGp64oE2KjBNxWkD+Pg3AsPO cjxqaI7hrDswa87uvVmP/XszaYYmgeCjDOs7Jr9YdeSMDqnDsm+FxJTDEg1WvBF7kSY0KAPpl 4ne04Q3EQdkaXgf1PIurv/NyYByPMvji1xwcjkPIOqTx+r5ywtC2RPfAAmqI+tOzChPjNmanI ui6sUW2f6hOzXSmEtMWJPjbFXh9she7QBrCgtg46CgWI/MwDRl4mRYh7jgZWv40k5DuML+pIw eFQ4OVTUOUdwWqOUnH9p4Ot93BBAaDOYcSpkgUtcWqF5BY1O3QqdVRYTO1i5ttyQq5K1f+MmL UtUNOAZJCqH/RQkfD4FMcz57oBp90XzENlKNb1c8Zo+iAeQ/Wcgvk2VXpQY3suOnZP1qS4k5D e6+MqTSwhVcXqK3nrnpHGT6bvgoYPw+15z7ABCJjY0qInVfWDyYmeKpkhgCzomsPr51wgB5Xo WYfEQXww31bqGHvnVdV0RE0g76zSdQvhaaCCPbDEjn2MlbFHgAeTjpB1gInHE8B0sXfg= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2022 at 04:22:30PM +0900 Masahiro Yamada wrote: > The 'static' specifier and EXPORT_SYMBOL() are an odd combination. > > Since commit 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* > functions"), modpost tries to detect it, but there are false negatives. > > Here is the sample code. > > [Sample 1] > > Makefile: > > obj-m += mymod1.o mymod2.o > > mymod1.c: > > #include > #include > static void foo(void) {} > EXPORT_SYMBOL(foo); > MODULE_LICENSE("GPL"); > > mymod2.c: > > #include > void foo(void) {} > MODULE_LICENSE("GPL"); > > mymod1 exports the static symbol 'foo', but modpost cannot catch it > because it is fooled by the same name symbol in another module, mymod2. > (Without mymod2, modpost can detect the error in mymod1) > > find_symbol() returns the first symbol found in the hash table with the > given name. This hash table is global, so it may return a symbol from > an unrelated module. So, a global symbol in a module may unset the > 'is_static' flag of another module. > > To mitigate this issue, add sym_find_with_module(), which receives the > module pointer as the second argument. If non-NULL pointer is passed, it > returns the symbol in the specified module. If NULL is passed, it is > equivalent to find_module(). > > Please note there are still false positives in the composite module, > like below (or when both are built-in). I have no idea how to do this > correctly. > > [Sample 2] (not fixed by this commit) > > Makefile: > obj-m += mymod.o > mymod-objs := mymod1.o mymod2.o > > Signed-off-by: Masahiro Yamada > --- I like the detailed commit description! Reviewed-by: Nicolas Schier > > (no changes since v2) > > Changes in v2: > - Rename the new func to sym_find_with_module() > > scripts/mod/modpost.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index b605f4a58759..a55fa2b88a9a 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -272,7 +272,7 @@ static void sym_add_unresolved(const char *name, struct module *mod, bool weak) > list_add_tail(&sym->list, &mod->unresolved_symbols); > } > > -static struct symbol *find_symbol(const char *name) > +static struct symbol *sym_find_with_module(const char *name, struct module *mod) > { > struct symbol *s; > > @@ -281,12 +281,17 @@ static struct symbol *find_symbol(const char *name) > name++; > > for (s = symbolhash[tdb_hash(name) % SYMBOL_HASH_SIZE]; s; s = s->next) { > - if (strcmp(s->name, name) == 0) > + if (strcmp(s->name, name) == 0 && (!mod || s->module == mod)) > return s; > } > return NULL; > } > > +static struct symbol *find_symbol(const char *name) > +{ > + return sym_find_with_module(name, NULL); > +} > + > struct namespace_list { > struct list_head list; > char namespace[]; > @@ -2063,8 +2068,9 @@ static void read_symbols(const char *modname) > > if (bind == STB_GLOBAL || bind == STB_WEAK) { > struct symbol *s = > - find_symbol(remove_dot(info.strtab + > - sym->st_name)); > + sym_find_with_module(remove_dot(info.strtab + > + sym->st_name), > + mod); > > if (s) > s->is_static = false; > -- > 2.32.0 -- epost|xmpp: nicolas@fjasle.eu irc://oftc.net/nsc ↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f -- frykten for herren er opphav til kunnskap -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB738C433EF for ; Thu, 5 May 2022 21:54:51 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KvSCt2xVBz3c9g for ; Fri, 6 May 2022 07:54:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=fjasle.eu header.i=@fjasle.eu header.a=rsa-sha256 header.s=mail header.b=PwCfqkix; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=fjasle.eu (client-ip=212.227.17.10; helo=mout.kundenserver.de; envelope-from=nicolas@fjasle.eu; receiver=) X-Greylist: delayed 569 seconds by postgrey-1.36 at boromir; Fri, 06 May 2022 05:42:47 AEST Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KvPHW6qsZz3bft for ; Fri, 6 May 2022 05:42:21 +1000 (AEST) Received: from leknes.fjasle.eu ([46.142.98.182]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MiIhU-1oH5uO3YH8-00fPtT; Thu, 05 May 2022 21:25:22 +0200 Received: by leknes.fjasle.eu (Postfix, from userid 1000) id 38E543C088; Thu, 5 May 2022 21:25:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1651778720; bh=Cwl4zkdeQcVXSxZ/RPcnVgB7zM8oGINbzVc8Y2VMFBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PwCfqkixa12sjKmUlkGN0KNMba5H+CtsWqxRGlVdXRptb7TBIoy0BO7Sc1zRukI0i EvUm1lkuiTNGLNT1bpJs98zozgIt6sLhIAOebglqQmNOD+itcraoJUvz+J1M7FySUT 6hRW+SHN7GBvySLN/CpZb48xBVsXn+jeS7J2nWak= Date: Thu, 5 May 2022 21:25:20 +0200 From: Nicolas Schier To: Masahiro Yamada Subject: Re: [PATCH v3 01/15] modpost: mitigate false-negatives for static EXPORT_SYMBOL checks Message-ID: References: <20220505072244.1155033-1-masahiroy@kernel.org> <20220505072244.1155033-2-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220505072244.1155033-2-masahiroy@kernel.org> X-Provags-ID: V03:K1:453ge2nHJXg6JLo5cZeMgSEFhVvVa0swhzjR0uQKtW94gAuyPQc MTjdF1f5pbFygWaA0SosWLKNmyUdXwFK1CUqAPSkq2SKzmSgl51MwQo6xoMn3Z2qWshs+mq zUww0m+Vg1VGGeeohNre8BVjxjh7qSjrYTbvLGMl0VUFNN4UdaEPPhevVoj5lG7DWNaJkaT +cWvR/fsod9psxrnhT2vQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:1I7YRGCbifg=:wiHGGZsjWiVsWflzSdZlf1 rnxSHlzLZbMlXQME6NsR23TczHKf6OFgpjIJRweoZDOt+P1A1+Y5ynWZFi1DUzWJOz1sKX0TM LRwVI4ERpbHQcSO0gDL6tU6ksEw87Zm+bAHq0WXCrwZsZa6+Y5mRLCIcxUmo329FGyjYNyhdS eG7aZnZWvzTXCARfGy1WslzyAgC8o6GEeHvAWVHxXESeqY8upGZMHXEI+uKbObPJTg0fEl3E7 NAoM9kJuatC3ZzJYV0EFKws1gCXTvip2bVKO/76Y3MvV0BFw8JDmr4hEJVRfSCNsQwoxvETEm byFT8g0yFtZ76OUQrjgzr2+eiPV/xAeMTNluTgPdpr4zrzFMZs4/+ugUQNJ15EYFAC0sBYW1W Pz3BGAUMOGllW0YjUQYhaqkW9sVp+UOPPJVZCClWZkiUGHSSLpgzeOhEorkO9iKmPcbeis2Hb MUJjhwu8LEveg9G2hunBn0D3ktK0vBt0TVPu6g1sSL68SLfVws0jRqa39KUc8HOJ41b06YlIy wFd3T3RT5uNwEXWYXjbev/LJZ0jLeMtsZkSbZ9rBnEFgQ/7s0XV+eQAmN0+BWqCDM3dzUO+Ym xMlRbF8rqGdgTzXPN8gNZpFvlIHgugQ82P+/XzVVZr46f8pl/L9tlr6VPnEKmAGrgxWPn3PFH f73++dR3OrYy55UT1C6nPNpG8/BjWlgNb3gzr+kTvM0/e/n3pIQ1OTs5w4FzgufxvWzg= X-Mailman-Approved-At: Fri, 06 May 2022 07:52:56 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, Kees Cook , linux-kbuild@vger.kernel.org, Peter Zijlstra , Nick Desaulniers , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Luis Chamberlain , Sami Tolvanen , linuxppc-dev@lists.ozlabs.org, Ard Biesheuvel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, May 05, 2022 at 04:22:30PM +0900 Masahiro Yamada wrote: > The 'static' specifier and EXPORT_SYMBOL() are an odd combination. > > Since commit 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* > functions"), modpost tries to detect it, but there are false negatives. > > Here is the sample code. > > [Sample 1] > > Makefile: > > obj-m += mymod1.o mymod2.o > > mymod1.c: > > #include > #include > static void foo(void) {} > EXPORT_SYMBOL(foo); > MODULE_LICENSE("GPL"); > > mymod2.c: > > #include > void foo(void) {} > MODULE_LICENSE("GPL"); > > mymod1 exports the static symbol 'foo', but modpost cannot catch it > because it is fooled by the same name symbol in another module, mymod2. > (Without mymod2, modpost can detect the error in mymod1) > > find_symbol() returns the first symbol found in the hash table with the > given name. This hash table is global, so it may return a symbol from > an unrelated module. So, a global symbol in a module may unset the > 'is_static' flag of another module. > > To mitigate this issue, add sym_find_with_module(), which receives the > module pointer as the second argument. If non-NULL pointer is passed, it > returns the symbol in the specified module. If NULL is passed, it is > equivalent to find_module(). > > Please note there are still false positives in the composite module, > like below (or when both are built-in). I have no idea how to do this > correctly. > > [Sample 2] (not fixed by this commit) > > Makefile: > obj-m += mymod.o > mymod-objs := mymod1.o mymod2.o > > Signed-off-by: Masahiro Yamada > --- I like the detailed commit description! Reviewed-by: Nicolas Schier > > (no changes since v2) > > Changes in v2: > - Rename the new func to sym_find_with_module() > > scripts/mod/modpost.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index b605f4a58759..a55fa2b88a9a 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -272,7 +272,7 @@ static void sym_add_unresolved(const char *name, struct module *mod, bool weak) > list_add_tail(&sym->list, &mod->unresolved_symbols); > } > > -static struct symbol *find_symbol(const char *name) > +static struct symbol *sym_find_with_module(const char *name, struct module *mod) > { > struct symbol *s; > > @@ -281,12 +281,17 @@ static struct symbol *find_symbol(const char *name) > name++; > > for (s = symbolhash[tdb_hash(name) % SYMBOL_HASH_SIZE]; s; s = s->next) { > - if (strcmp(s->name, name) == 0) > + if (strcmp(s->name, name) == 0 && (!mod || s->module == mod)) > return s; > } > return NULL; > } > > +static struct symbol *find_symbol(const char *name) > +{ > + return sym_find_with_module(name, NULL); > +} > + > struct namespace_list { > struct list_head list; > char namespace[]; > @@ -2063,8 +2068,9 @@ static void read_symbols(const char *modname) > > if (bind == STB_GLOBAL || bind == STB_WEAK) { > struct symbol *s = > - find_symbol(remove_dot(info.strtab + > - sym->st_name)); > + sym_find_with_module(remove_dot(info.strtab + > + sym->st_name), > + mod); > > if (s) > s->is_static = false; > -- > 2.32.0 -- epost|xmpp: nicolas@fjasle.eu irc://oftc.net/nsc ↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f -- frykten for herren er opphav til kunnskap -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmh6r-00HUPz-BW for linux-um@lists.infradead.org; Thu, 05 May 2022 19:26:04 +0000 Date: Thu, 5 May 2022 21:25:20 +0200 From: Nicolas Schier Subject: Re: [PATCH v3 01/15] modpost: mitigate false-negatives for static EXPORT_SYMBOL checks Message-ID: References: <20220505072244.1155033-1-masahiroy@kernel.org> <20220505072244.1155033-2-masahiroy@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220505072244.1155033-2-masahiroy@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Ard Biesheuvel , Luis Chamberlain , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-um@lists.infradead.org, linux-s390@vger.kernel.org, Nick Desaulniers , Sami Tolvanen , Kees Cook T24gVGh1LCBNYXkgMDUsIDIwMjIgYXQgMDQ6MjI6MzBQTSArMDkwMCBNYXNhaGlybyBZYW1hZGEg d3JvdGU6Cj4gVGhlICdzdGF0aWMnIHNwZWNpZmllciBhbmQgRVhQT1JUX1NZTUJPTCgpIGFyZSBh biBvZGQgY29tYmluYXRpb24uCj4gCj4gU2luY2UgY29tbWl0IDE1YmZjMjM0OGQ1NCAoIm1vZHBv c3Q6IGNoZWNrIGZvciBzdGF0aWMgRVhQT1JUX1NZTUJPTCoKPiBmdW5jdGlvbnMiKSwgbW9kcG9z dCB0cmllcyB0byBkZXRlY3QgaXQsIGJ1dCB0aGVyZSBhcmUgZmFsc2UgbmVnYXRpdmVzLgo+IAo+ IEhlcmUgaXMgdGhlIHNhbXBsZSBjb2RlLgo+IAo+IFtTYW1wbGUgMV0KPiAKPiAgIE1ha2VmaWxl Ogo+IAo+ICAgICBvYmotbSArPSBteW1vZDEubyBteW1vZDIubwo+IAo+ICAgbXltb2QxLmM6Cj4g Cj4gICAgICNpbmNsdWRlIDxsaW51eC9leHBvcnQuaD4KPiAgICAgI2luY2x1ZGUgPGxpbnV4L21v ZHVsZS5oPgo+ICAgICBzdGF0aWMgdm9pZCBmb28odm9pZCkge30KPiAgICAgRVhQT1JUX1NZTUJP TChmb28pOwo+ICAgICBNT0RVTEVfTElDRU5TRSgiR1BMIik7Cj4gCj4gICBteW1vZDIuYzoKPiAK PiAgICAgI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ICAgICB2b2lkIGZvbyh2b2lkKSB7fQo+ ICAgICBNT0RVTEVfTElDRU5TRSgiR1BMIik7Cj4gCj4gbXltb2QxIGV4cG9ydHMgdGhlIHN0YXRp YyBzeW1ib2wgJ2ZvbycsIGJ1dCBtb2Rwb3N0IGNhbm5vdCBjYXRjaCBpdAo+IGJlY2F1c2UgaXQg aXMgZm9vbGVkIGJ5IHRoZSBzYW1lIG5hbWUgc3ltYm9sIGluIGFub3RoZXIgbW9kdWxlLCBteW1v ZDIuCj4gKFdpdGhvdXQgbXltb2QyLCBtb2Rwb3N0IGNhbiBkZXRlY3QgdGhlIGVycm9yIGluIG15 bW9kMSkKPiAKPiBmaW5kX3N5bWJvbCgpIHJldHVybnMgdGhlIGZpcnN0IHN5bWJvbCBmb3VuZCBp biB0aGUgaGFzaCB0YWJsZSB3aXRoIHRoZQo+IGdpdmVuIG5hbWUuIFRoaXMgaGFzaCB0YWJsZSBp cyBnbG9iYWwsIHNvIGl0IG1heSByZXR1cm4gYSBzeW1ib2wgZnJvbQo+IGFuIHVucmVsYXRlZCBt b2R1bGUuIFNvLCBhIGdsb2JhbCBzeW1ib2wgaW4gYSBtb2R1bGUgbWF5IHVuc2V0IHRoZQo+ICdp c19zdGF0aWMnIGZsYWcgb2YgYW5vdGhlciBtb2R1bGUuCj4gCj4gVG8gbWl0aWdhdGUgdGhpcyBp c3N1ZSwgYWRkIHN5bV9maW5kX3dpdGhfbW9kdWxlKCksIHdoaWNoIHJlY2VpdmVzIHRoZQo+IG1v ZHVsZSBwb2ludGVyIGFzIHRoZSBzZWNvbmQgYXJndW1lbnQuIElmIG5vbi1OVUxMIHBvaW50ZXIg aXMgcGFzc2VkLCBpdAo+IHJldHVybnMgdGhlIHN5bWJvbCBpbiB0aGUgc3BlY2lmaWVkIG1vZHVs ZS4gSWYgTlVMTCBpcyBwYXNzZWQsIGl0IGlzCj4gZXF1aXZhbGVudCB0byBmaW5kX21vZHVsZSgp Lgo+IAo+IFBsZWFzZSBub3RlIHRoZXJlIGFyZSBzdGlsbCBmYWxzZSBwb3NpdGl2ZXMgaW4gdGhl IGNvbXBvc2l0ZSBtb2R1bGUsCj4gbGlrZSBiZWxvdyAob3Igd2hlbiBib3RoIGFyZSBidWlsdC1p bikuIEkgaGF2ZSBubyBpZGVhIGhvdyB0byBkbyB0aGlzCj4gY29ycmVjdGx5Lgo+IAo+IFtTYW1w bGUgMl0gIChub3QgZml4ZWQgYnkgdGhpcyBjb21taXQpCj4gCj4gICBNYWtlZmlsZToKPiAgICAg b2JqLW0gKz0gbXltb2Qubwo+ICAgICBteW1vZC1vYmpzIDo9IG15bW9kMS5vIG15bW9kMi5vCj4g Cj4gU2lnbmVkLW9mZi1ieTogTWFzYWhpcm8gWWFtYWRhIDxtYXNhaGlyb3lAa2VybmVsLm9yZz4K PiAtLS0KCkkgbGlrZSB0aGUgZGV0YWlsZWQgY29tbWl0IGRlc2NyaXB0aW9uIQoKUmV2aWV3ZWQt Ynk6IE5pY29sYXMgU2NoaWVyIDxuaWNvbGFzQGZqYXNsZS5ldT4KCj4gCj4gKG5vIGNoYW5nZXMg c2luY2UgdjIpCj4gCj4gQ2hhbmdlcyBpbiB2MjoKPiAgIC0gUmVuYW1lIHRoZSBuZXcgZnVuYyB0 byBzeW1fZmluZF93aXRoX21vZHVsZSgpCj4gCj4gIHNjcmlwdHMvbW9kL21vZHBvc3QuYyB8IDE0 ICsrKysrKysrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA0IGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9zY3JpcHRzL21vZC9tb2Rwb3N0LmMgYi9zY3Jp cHRzL21vZC9tb2Rwb3N0LmMKPiBpbmRleCBiNjA1ZjRhNTg3NTkuLmE1NWZhMmI4OGE5YSAxMDA2 NDQKPiAtLS0gYS9zY3JpcHRzL21vZC9tb2Rwb3N0LmMKPiArKysgYi9zY3JpcHRzL21vZC9tb2Rw b3N0LmMKPiBAQCAtMjcyLDcgKzI3Miw3IEBAIHN0YXRpYyB2b2lkIHN5bV9hZGRfdW5yZXNvbHZl ZChjb25zdCBjaGFyICpuYW1lLCBzdHJ1Y3QgbW9kdWxlICptb2QsIGJvb2wgd2VhaykKPiAgCWxp c3RfYWRkX3RhaWwoJnN5bS0+bGlzdCwgJm1vZC0+dW5yZXNvbHZlZF9zeW1ib2xzKTsKPiAgfQo+ ICAKPiAtc3RhdGljIHN0cnVjdCBzeW1ib2wgKmZpbmRfc3ltYm9sKGNvbnN0IGNoYXIgKm5hbWUp Cj4gK3N0YXRpYyBzdHJ1Y3Qgc3ltYm9sICpzeW1fZmluZF93aXRoX21vZHVsZShjb25zdCBjaGFy ICpuYW1lLCBzdHJ1Y3QgbW9kdWxlICptb2QpCj4gIHsKPiAgCXN0cnVjdCBzeW1ib2wgKnM7Cj4g IAo+IEBAIC0yODEsMTIgKzI4MSwxNyBAQCBzdGF0aWMgc3RydWN0IHN5bWJvbCAqZmluZF9zeW1i b2woY29uc3QgY2hhciAqbmFtZSkKPiAgCQluYW1lKys7Cj4gIAo+ICAJZm9yIChzID0gc3ltYm9s aGFzaFt0ZGJfaGFzaChuYW1lKSAlIFNZTUJPTF9IQVNIX1NJWkVdOyBzOyBzID0gcy0+bmV4dCkg ewo+IC0JCWlmIChzdHJjbXAocy0+bmFtZSwgbmFtZSkgPT0gMCkKPiArCQlpZiAoc3RyY21wKHMt Pm5hbWUsIG5hbWUpID09IDAgJiYgKCFtb2QgfHwgcy0+bW9kdWxlID09IG1vZCkpCj4gIAkJCXJl dHVybiBzOwo+ICAJfQo+ICAJcmV0dXJuIE5VTEw7Cj4gIH0KPiAgCj4gK3N0YXRpYyBzdHJ1Y3Qg c3ltYm9sICpmaW5kX3N5bWJvbChjb25zdCBjaGFyICpuYW1lKQo+ICt7Cj4gKwlyZXR1cm4gc3lt X2ZpbmRfd2l0aF9tb2R1bGUobmFtZSwgTlVMTCk7Cj4gK30KPiArCj4gIHN0cnVjdCBuYW1lc3Bh Y2VfbGlzdCB7Cj4gIAlzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7Cj4gIAljaGFyIG5hbWVzcGFjZVtd Owo+IEBAIC0yMDYzLDggKzIwNjgsOSBAQCBzdGF0aWMgdm9pZCByZWFkX3N5bWJvbHMoY29uc3Qg Y2hhciAqbW9kbmFtZSkKPiAgCj4gIAkJaWYgKGJpbmQgPT0gU1RCX0dMT0JBTCB8fCBiaW5kID09 IFNUQl9XRUFLKSB7Cj4gIAkJCXN0cnVjdCBzeW1ib2wgKnMgPQo+IC0JCQkJZmluZF9zeW1ib2wo cmVtb3ZlX2RvdChpbmZvLnN0cnRhYiArCj4gLQkJCQkJCSAgICAgICBzeW0tPnN0X25hbWUpKTsK PiArCQkJCXN5bV9maW5kX3dpdGhfbW9kdWxlKHJlbW92ZV9kb3QoaW5mby5zdHJ0YWIgKwo+ICsJ CQkJCQkJCXN5bS0+c3RfbmFtZSksCj4gKwkJCQkJCSAgICAgbW9kKTsKPiAgCj4gIAkJCWlmIChz KQo+ICAJCQkJcy0+aXNfc3RhdGljID0gZmFsc2U7Cj4gLS0gCj4gMi4zMi4wCgotLSAKZXBvc3R8 eG1wcDogbmljb2xhc0BmamFzbGUuZXUgICAgICAgICAgaXJjOi8vb2Z0Yy5uZXQvbnNjCuKGsyBn cGc6IDE4ZWQgNTJkYiBlMzRmIDg2MGUgZTlmYiAgYzgyYiA3ZDk3IDA5MzIgNTVhMCBjZTdmCiAg ICAgLS0gZnJ5a3RlbiBmb3IgaGVycmVuIGVyIG9wcGhhdiB0aWwga3VubnNrYXAgLS0KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXVtIG1haWxp bmcgbGlzdApsaW51eC11bUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtdW0K