From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 020FBC433F5 for ; Thu, 5 May 2022 19:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385613AbiEET70 (ORCPT ); Thu, 5 May 2022 15:59:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385464AbiEET66 (ORCPT ); Thu, 5 May 2022 15:58:58 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EFC35F24B; Thu, 5 May 2022 12:55:13 -0700 (PDT) Received: from leknes.fjasle.eu ([46.142.98.182]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N3K9E-1nwDkz0qKw-010OY9; Thu, 05 May 2022 21:53:59 +0200 Received: by leknes.fjasle.eu (Postfix, from userid 1000) id 156A33C088; Thu, 5 May 2022 21:53:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1651780437; bh=dBGPpUTd6f50KRn9utFIdPZJncpaOpFQeh/8wziuA/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BA/UrMfyunASKGi7EkzUpzPsPi2aei9LQHExoWZtA5QFmz+nF8ch9crJVNxlyXlAo 9/Na54bbnRtHOJVT/Cu1rd++ItUCRwJYL1sK4BZ0RkHyXPHaNQRVN2803zQ7qVDZ9q IFpDp5e19gxb+cnRkH0vRcmlOzVJGX4BOzBrpews= Date: Thu, 5 May 2022 21:53:56 +0200 From: Nicolas Schier To: Masahiro Yamada Cc: Linux Kbuild mailing list , clang-built-linux , Linux Kernel Mailing List , Ard Biesheuvel , Luis Chamberlain , Peter Zijlstra , linuxppc-dev , linux-um@lists.infradead.org, linux-s390 , Nick Desaulniers , Sami Tolvanen , Kees Cook Subject: Re: [PATCH v3 02/15] modpost: change the license of EXPORT_SYMBOL to bool type Message-ID: References: <20220505072244.1155033-1-masahiroy@kernel.org> <20220505072244.1155033-3-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:eVIKbsZAbmzWlKtPrBj9Mb+vBbXXzsRynicJaMbmbzeysZP9arT xtUnuIVyv55qPraP+CQORaltSCsWVTcv/yBmJe397a5RhE4lqPF/7NTAdPbhqJt+3Gh8g92 ZoO+xpkipSHT4m8eoWenn52JjlnfRIYuJaTzy/dfT9T33OOig4RA8icWKQqDbDJT1r+AETo wW4IQZEr5rVf+AzQyOwXw== X-UI-Out-Filterresults: notjunk:1;V03:K0:O1718LcMWqY=:suNSu7o6nKuRoYHjwHkK7V I5JxHIqIanjGfPigUPLhylAYRpIOBsQUko5BnQ6W4am6/4Rk1hQN6SjvKN5TJ+Ie4NSKLKRUU /rCUpt8uxsEkDWvgPp2uG0z6DNKPTzqh8GOV+zc/pZy4BIyyREB8aD/ArpRnIaRaYTcqnn56q XUSx9OWW0FgRVVjXnPgkQwU3vCboB03AivsI9pjAaunR2mMKkgjkV9UgoLuBEtCr1gGEQLY5q z4gY0BE70xMtqT8byLS8fXfYh0Cd9tmtCdH1UvMI0eN9ObwTzYhaRtzGMaFmzNcYu/HJGpADG S8KLRMdZq3HDg9PtUi/8323eqrhjuEFIx9AcoFTVjHgQkAUqar0NTGwnCGXtlJ6By8bb1mW1N dlSRIjRe39kgHYAcF4eWrvXUorPWsok/1vGuGljWIdqmDlUxyf6IaxJH9iEdRJZi4QMOYsrru GwTY6TZBAAM7xXkzedF/IBOT6zwIoooV1swVFW6ldMo75vnpOkJ7OtLQBARHpTDtcdpjFN9oA tonNUBC+ZHeQ8bmR1CcgL4nvBkdAa5mIRaypRTPGCOtPxEvwMhuyASvdQkdxOCbWJbK9uZa9l h7U5WP0/B6y9l/upnfY5B/pSb4v9X4o2Cxgjvspp3ACwnhKVDVDlZ1Sgugg3sGpeXE/AU4xsl 9YYc4OOhpf0rxjgHtRHcZ4fJ+MpGjD+n2/wd9yTekkkDcgbJ19y5X+rdO48X0t3Q0g0c= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 05, 2022 at 10:48:55PM +0900 Masahiro Yamada wrote: > On Thu, May 5, 2022 at 4:24 PM Masahiro Yamada wrote: > > > > Currently, enum export is tristate, but export_unknown does not make > > sense in any way. > > > > If the symbol name starts with "__ksymtab_", but the section name > > does not start with "___ksymtab+" or "___ksymtab_gpl+", it is not > > an exported symbol. The variable name just happens to start with > > "__ksymtab_". Do not call sym_add_exported() in this case. > > > > __ksymtab_* is internally by EXPORT_SYMBOL(_GPL) but somebody may > > I mean > "... is internally used by ..." Looks good to me; a nice cleanup. Reviewed-by: Nicolas Schier From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB0D8C433F5 for ; Thu, 5 May 2022 21:55:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KvSDY2734z3cHD for ; Fri, 6 May 2022 07:55:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=fjasle.eu header.i=@fjasle.eu header.a=rsa-sha256 header.s=mail header.b=BA/UrMfy; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=fjasle.eu (client-ip=212.227.17.24; helo=mout.kundenserver.de; envelope-from=nicolas@fjasle.eu; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=fjasle.eu header.i=@fjasle.eu header.a=rsa-sha256 header.s=mail header.b=BA/UrMfy; dkim-atps=neutral Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KvPZD5b8vz3bpP for ; Fri, 6 May 2022 05:55:21 +1000 (AEST) Received: from leknes.fjasle.eu ([46.142.98.182]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N3K9E-1nwDkz0qKw-010OY9; Thu, 05 May 2022 21:53:59 +0200 Received: by leknes.fjasle.eu (Postfix, from userid 1000) id 156A33C088; Thu, 5 May 2022 21:53:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1651780437; bh=dBGPpUTd6f50KRn9utFIdPZJncpaOpFQeh/8wziuA/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BA/UrMfyunASKGi7EkzUpzPsPi2aei9LQHExoWZtA5QFmz+nF8ch9crJVNxlyXlAo 9/Na54bbnRtHOJVT/Cu1rd++ItUCRwJYL1sK4BZ0RkHyXPHaNQRVN2803zQ7qVDZ9q IFpDp5e19gxb+cnRkH0vRcmlOzVJGX4BOzBrpews= Date: Thu, 5 May 2022 21:53:56 +0200 From: Nicolas Schier To: Masahiro Yamada Subject: Re: [PATCH v3 02/15] modpost: change the license of EXPORT_SYMBOL to bool type Message-ID: References: <20220505072244.1155033-1-masahiroy@kernel.org> <20220505072244.1155033-3-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:eVIKbsZAbmzWlKtPrBj9Mb+vBbXXzsRynicJaMbmbzeysZP9arT xtUnuIVyv55qPraP+CQORaltSCsWVTcv/yBmJe397a5RhE4lqPF/7NTAdPbhqJt+3Gh8g92 ZoO+xpkipSHT4m8eoWenn52JjlnfRIYuJaTzy/dfT9T33OOig4RA8icWKQqDbDJT1r+AETo wW4IQZEr5rVf+AzQyOwXw== X-UI-Out-Filterresults: notjunk:1;V03:K0:O1718LcMWqY=:suNSu7o6nKuRoYHjwHkK7V I5JxHIqIanjGfPigUPLhylAYRpIOBsQUko5BnQ6W4am6/4Rk1hQN6SjvKN5TJ+Ie4NSKLKRUU /rCUpt8uxsEkDWvgPp2uG0z6DNKPTzqh8GOV+zc/pZy4BIyyREB8aD/ArpRnIaRaYTcqnn56q XUSx9OWW0FgRVVjXnPgkQwU3vCboB03AivsI9pjAaunR2mMKkgjkV9UgoLuBEtCr1gGEQLY5q z4gY0BE70xMtqT8byLS8fXfYh0Cd9tmtCdH1UvMI0eN9ObwTzYhaRtzGMaFmzNcYu/HJGpADG S8KLRMdZq3HDg9PtUi/8323eqrhjuEFIx9AcoFTVjHgQkAUqar0NTGwnCGXtlJ6By8bb1mW1N dlSRIjRe39kgHYAcF4eWrvXUorPWsok/1vGuGljWIdqmDlUxyf6IaxJH9iEdRJZi4QMOYsrru GwTY6TZBAAM7xXkzedF/IBOT6zwIoooV1swVFW6ldMo75vnpOkJ7OtLQBARHpTDtcdpjFN9oA tonNUBC+ZHeQ8bmR1CcgL4nvBkdAa5mIRaypRTPGCOtPxEvwMhuyASvdQkdxOCbWJbK9uZa9l h7U5WP0/B6y9l/upnfY5B/pSb4v9X4o2Cxgjvspp3ACwnhKVDVDlZ1Sgugg3sGpeXE/AU4xsl 9YYc4OOhpf0rxjgHtRHcZ4fJ+MpGjD+n2/wd9yTekkkDcgbJ19y5X+rdO48X0t3Q0g0c= X-Mailman-Approved-At: Fri, 06 May 2022 07:52:56 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390 , Kees Cook , Linux Kbuild mailing list , Peter Zijlstra , Nick Desaulniers , linux-um@lists.infradead.org, Linux Kernel Mailing List , clang-built-linux , Luis Chamberlain , Sami Tolvanen , linuxppc-dev , Ard Biesheuvel Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, May 05, 2022 at 10:48:55PM +0900 Masahiro Yamada wrote: > On Thu, May 5, 2022 at 4:24 PM Masahiro Yamada wrote: > > > > Currently, enum export is tristate, but export_unknown does not make > > sense in any way. > > > > If the symbol name starts with "__ksymtab_", but the section name > > does not start with "___ksymtab+" or "___ksymtab_gpl+", it is not > > an exported symbol. The variable name just happens to start with > > "__ksymtab_". Do not call sym_add_exported() in this case. > > > > __ksymtab_* is internally by EXPORT_SYMBOL(_GPL) but somebody may > > I mean > "... is internally used by ..." Looks good to me; a nice cleanup. Reviewed-by: Nicolas Schier From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmhYO-0001lZ-Oh for linux-um@lists.infradead.org; Thu, 05 May 2022 19:54:32 +0000 Date: Thu, 5 May 2022 21:53:56 +0200 From: Nicolas Schier Subject: Re: [PATCH v3 02/15] modpost: change the license of EXPORT_SYMBOL to bool type Message-ID: References: <20220505072244.1155033-1-masahiroy@kernel.org> <20220505072244.1155033-3-masahiroy@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Masahiro Yamada Cc: Linux Kbuild mailing list , clang-built-linux , Linux Kernel Mailing List , Ard Biesheuvel , Luis Chamberlain , Peter Zijlstra , linuxppc-dev , linux-um@lists.infradead.org, linux-s390 , Nick Desaulniers , Sami Tolvanen , Kees Cook On Thu, May 05, 2022 at 10:48:55PM +0900 Masahiro Yamada wrote: > On Thu, May 5, 2022 at 4:24 PM Masahiro Yamada wrote: > > > > Currently, enum export is tristate, but export_unknown does not make > > sense in any way. > > > > If the symbol name starts with "__ksymtab_", but the section name > > does not start with "___ksymtab+" or "___ksymtab_gpl+", it is not > > an exported symbol. The variable name just happens to start with > > "__ksymtab_". Do not call sym_add_exported() in this case. > > > > __ksymtab_* is internally by EXPORT_SYMBOL(_GPL) but somebody may > > I mean > "... is internally used by ..." Looks good to me; a nice cleanup. Reviewed-by: Nicolas Schier _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um