From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EE53C433EF for ; Tue, 14 Jun 2022 16:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hsXwS9mNjZkpPIvoxU2PjiX5nXMqqxazlx7xqAKcsjY=; b=Q7XPIiohM3pmn0 R5hUOdCx2Yu6oFuctWlq1NF5oy8stBkMP+DCBOpqJi49jZ8gto/j6+fRRboRO41D6w+HmhJREUrED 0J3E5n2EOzNvPxWlddMAuA1PoIcJtBXJR4sroCzToWwhvF2Y7GrCZI9Fj4OY5v6SC143uWm200YCj kOoWsH6mTD+7Za3bXNf0Mabsyt1Ge3P83oth14kWJ+RWA6YUskyRuUlOl95iFMhy67yiNK7HnUcf3 B5WOzJAPrvtMneJk8OTcKShH1Kv5JveiMsvJJoVHkmy3V3CJd4E0c0xvDUKY/XTgyHVXhWSvoF/Xe pQADnn8r5mfZ9dNkULgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19eH-00APSX-LZ; Tue, 14 Jun 2022 16:44:13 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19eF-00APQJ-FQ; Tue, 14 Jun 2022 16:44:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=lGPDnVOvpW5cJYkNK5aiO+HQt8YloxSeZZcAt0L3T+0=; b=DAyjnelx4YBZDCDKjW1vABnwD6 bfuQInSMcO0k1N9c43zulrHrt0FEspCLqBV7dzVlaMMaDm/0d8h+E1vx/Mn16eV+mdIA5cFTuH3pJ ZPctIYIGAc1IQVFMkXT59RectB0+FvezRUN6pXOBo7jPhyxeW7DquiSvQAiutE+ZX5GvtHgbHFHRx 6HNiF1zBAiNoXSUuUybOLrpKXxYLhLp7SkKzRQuOg8AsSzW4GjX7X7PIc8C1Yqe4MS+PoRyI4eENc TnTVXl8b+mj78ByEoizyUwQl4K8tWC0/1bV8h78+HtzLeArX034mK97ekOVdMcZW15wljxz2QwCm7 eJasXJFA==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19e7-007uTz-7Y; Tue, 14 Jun 2022 16:44:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BBDAE3002BE; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A1F7228B3F630; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Date: Tue, 14 Jun 2022 18:44:02 +0200 From: Peter Zijlstra To: Nadav Amit Cc: "srivatsa@csail.mit.edu" , "juri.lelli@redhat.com" , "rafael@kernel.org" , Benjamin Herrenschmidt , "linus.walleij@linaro.org" , "bsegall@google.com" , "guoren@kernel.org" , "pavel@ucw.cz" , "agordeev@linux.ibm.com" , "linux-clk@vger.kernel.org" , linux-arch , "vincent.guittot@linaro.org" , "mpe@ellerman.id.au" , "chenhuacai@kernel.org" , "linux-acpi@vger.kernel.org" , "agross@kernel.org" , "geert@linux-m68k.org" , "linux-imx@nxp.com" , Catalin Marinas , "xen-devel@lists.xenproject.org" , "mattst88@gmail.com" , "borntraeger@linux.ibm.com" , "mturquette@baylibre.com" , "sammy@sammy.net" , "pmladek@suse.com" , "linux-pm@vger.kernel.org" , "jiangshanlai@gmail.com" , Sascha Hauer , "linux-um@lists.infradead.org" , "acme@kernel.org" , Thomas Gleixner , "linux-omap@vger.kernel.org" , "dietmar.eggemann@arm.com" , "rth@twiddle.net" , Greg Kroah-Hartman , LKML , "linux-perf-users@vger.kernel.org" , "senozhatsky@chromium.org" , "svens@linux.ibm.com" , "jolsa@kernel.org" , "paulus@samba.org" , "mark.rutland@arm.com" , "linux-ia64@vger.kernel.org" , Dave Hansen , Linux Virtualization , "James.Bottomley@hansenpartnership.com" , "jcmvbkbc@gmail.com" , "thierry.reding@gmail.com" , "kernel@xen0n.name" , "quic_neeraju@quicinc.com" , linux-s390 , "vschneid@redhat.com" , "john.ogness@linutronix.de" , "ysato@users.sourceforge.jp" , "linux-sh@vger.kernel.org" , "festevam@gmail.com" , "deller@gmx.de" , "daniel.lezcano@linaro.org" , "jonathanh@nvidia.com" , Mathieu Desnoyers , "frederic@kernel.org" , "lenb@kernel.org" , "linux-xtensa@linux-xtensa.org" , "kernel@pengutronix.de" , "gor@linux.ibm.com" , "linux-arm-msm@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "shorne@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "chris@zankel.net" , "sboyd@kernel.org" , "dinguyen@kernel.org" , "bristot@redhat.com" , "alexander.shishkin@linux.intel.com" , "lpieralisi@kernel.org" , "linux@rasmusvillemoes.dk" , "joel@joelfernandes.org" , Will Deacon , Boris Ostrovsky , "khilman@kernel.org" , "linux-csky@vger.kernel.org" , Pv-drivers , "linux-snps-arc@lists.infradead.org" , Mel Gorman , "jacob.jun.pan@linux.intel.com" , Arnd Bergmann , "ulli.kroll@googlemail.com" , "vgupta@kernel.org" , "josh@joshtriplett.org" , Steven Rostedt , "rcu@vger.kernel.org" , Borislav Petkov , "bcain@quicinc.com" , "tsbogend@alpha.franken.de" , "linux-parisc@vger.kernel.org" , "sudeep.holla@arm.com" , "shawnguo@kernel.org" , "davem@davemloft.net" , "dalias@libc.org" , "tony@atomide.com" , "bjorn.andersson@linaro.org" , "H. Peter Anvin" , "sparclinux@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Anton Ivanov , "jonas@southpole.se" , "yury.norov@gmail.com" , "richard@nod.at" , X86 ML , "linux@armlinux.org.uk" , Ingo Molnar , "aou@eecs.berkeley.edu" , "paulmck@kernel.org" , "hca@linux.ibm.com" , "stefan.kristiansson@saunalahti.fi" , "openrisc@lists.librecores.org" , "paul.walmsley@sifive.com" , "linux-tegra@vger.kernel.org" , "namhyung@kernel.org" , "andriy.shevchenko@linux.intel.com" , "jpoimboe@kernel.org" , Juergen Gross , "monstr@monstr.eu" , "linux-mips@vger.kernel.org" , "palmer@dabbelt.com" , "anup@brainfault.org" , "ink@jurassic.park.msu.ru" , "johannes@sipsolutions.net" , linuxppc-dev Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more PARAVIRT_XXL noinstr clean Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144517.759631860@infradead.org> <510b9b68-7d53-7d4d-5a05-37fbd199eb4b@csail.mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMTMsIDIwMjIgYXQgMDc6MjM6MTNQTSArMDAwMCwgTmFkYXYgQW1pdCB3cm90 ZToKPiBPbiBKdW4gMTMsIDIwMjIsIGF0IDExOjQ4IEFNLCBTcml2YXRzYSBTLiBCaGF0IDxzcml2 YXRzYUBjc2FpbC5taXQuZWR1PiB3cm90ZToKPiAKPiA+IOKaoCBFeHRlcm5hbCBFbWFpbAo+ID4g Cj4gPiBPbiA2LzgvMjIgNDoyNyBQTSwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6Cj4gPj4gdm1saW51 eC5vOiB3YXJuaW5nOiBvYmp0b29sOiBhY3BpX2lkbGVfZW50ZXJfczJpZGxlKzB4ZGU6IGNhbGwg dG8gd2JpbnZkKCkgbGVhdmVzIC5ub2luc3RyLnRleHQgc2VjdGlvbgo+ID4+IHZtbGludXgubzog d2FybmluZzogb2JqdG9vbDogZGVmYXVsdF9pZGxlKzB4NDogY2FsbCB0byBhcmNoX3NhZmVfaGFs dCgpIGxlYXZlcyAubm9pbnN0ci50ZXh0IHNlY3Rpb24KPiA+PiB2bWxpbnV4Lm86IHdhcm5pbmc6 IG9ianRvb2w6IHhlbl9zYWZlX2hhbHQrMHhhOiBjYWxsIHRvIEhZUEVSVklTT1Jfc2NoZWRfb3Au Y29uc3Rwcm9wLjAoKSBsZWF2ZXMgLm5vaW5zdHIudGV4dCBzZWN0aW9uCj4gPj4gCj4gPj4gU2ln bmVkLW9mZi1ieTogUGV0ZXIgWmlqbHN0cmEgKEludGVsKSA8cGV0ZXJ6QGluZnJhZGVhZC5vcmc+ Cj4gPiAKPiA+IFJldmlld2VkLWJ5OiBTcml2YXRzYSBTLiBCaGF0IChWTXdhcmUpIDxzcml2YXRz YUBjc2FpbC5taXQuZWR1Pgo+ID4gCj4gPj4gCj4gPj4gLXN0YXRpYyBpbmxpbmUgdm9pZCB3Ymlu dmQodm9pZCkKPiA+PiArZXh0ZXJuIG5vaW5zdHIgdm9pZCBwdl9uYXRpdmVfd2JpbnZkKHZvaWQp Owo+ID4+ICsKPiA+PiArc3RhdGljIF9fYWx3YXlzX2lubGluZSB2b2lkIHdiaW52ZCh2b2lkKQo+ ID4+IHsKPiA+PiAgICAgIFBWT1BfQUxUX1ZDQUxMMChjcHUud2JpbnZkLCAid2JpbnZkIiwgQUxU X05PVChYODZfRkVBVFVSRV9YRU5QVikpOwo+ID4+IH0KPiAKPiBJIGd1ZXNzIGl0IGlzIHlldCBh bm90aGVyIGluc3RhbmNlIG9mIHdyb25nIGFjY291bnRpbmcgb2YgR0NDIGZvcgo+IHRoZSBhc3Nl bWJseSBibG9ja3PigJkgd2VpZ2h0LiBJIGd1ZXNzIGl0IGlzIG5vdCBhIHNvbHV0aW9uIGZvciBv bGRlcgo+IEdDQ3MsIGJ1dCBwcmVzdW1hYmx5IF9fX19QVk9QX0FMVF9DQUxMKCkgYW5kIGZyaWVu ZHMgc2hvdWxkIGhhdmUKPiB1c2VkIGFzbV9pbmxpbmUgb3Igc29tZSBuZXcg4oCcYXNtX3ZvbGF0 aWxlX2lubGluZeKAnSB2YXJpYW50LgoKUGFydGlhbGx5LCBzb21lIG9mIHRoZSAqU0FOIG9wdGlv bnMgYWxzbyBnZW5lcmF0ZSBhIG1ldHJpYyB0b24gb2YKbm9uc2Vuc2Ugd2hlbiBlbmFibGVkIGFu ZCBza2V3IHRoZSBjb21waWxlcnMgdG93YXJkcyBub3QgaW5saW5pbmcKdGhpbmdzLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtc25wcy1hcmMg bWFpbGluZyBsaXN0CmxpbnV4LXNucHMtYXJjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1zbnBzLWFyYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 615A6C433EF for ; Tue, 14 Jun 2022 16:44:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0A27760B02; Tue, 14 Jun 2022 16:44:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kHsRpoK1p2sn; Tue, 14 Jun 2022 16:44:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 989726077D; Tue, 14 Jun 2022 16:44:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6F83DC0039; Tue, 14 Jun 2022 16:44:41 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id D4799C002D for ; Tue, 14 Jun 2022 16:44:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B098141576 for ; Tue, 14 Jun 2022 16:44:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=infradead.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W_4ccmEQmeCF for ; Tue, 14 Jun 2022 16:44:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by smtp4.osuosl.org (Postfix) with ESMTPS id 66644410BB for ; Tue, 14 Jun 2022 16:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=lGPDnVOvpW5cJYkNK5aiO+HQt8YloxSeZZcAt0L3T+0=; b=DAyjnelx4YBZDCDKjW1vABnwD6 bfuQInSMcO0k1N9c43zulrHrt0FEspCLqBV7dzVlaMMaDm/0d8h+E1vx/Mn16eV+mdIA5cFTuH3pJ ZPctIYIGAc1IQVFMkXT59RectB0+FvezRUN6pXOBo7jPhyxeW7DquiSvQAiutE+ZX5GvtHgbHFHRx 6HNiF1zBAiNoXSUuUybOLrpKXxYLhLp7SkKzRQuOg8AsSzW4GjX7X7PIc8C1Yqe4MS+PoRyI4eENc TnTVXl8b+mj78ByEoizyUwQl4K8tWC0/1bV8h78+HtzLeArX034mK97ekOVdMcZW15wljxz2QwCm7 eJasXJFA==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19e7-007uTz-7Y; Tue, 14 Jun 2022 16:44:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BBDAE3002BE; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A1F7228B3F630; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Date: Tue, 14 Jun 2022 18:44:02 +0200 From: Peter Zijlstra To: Nadav Amit Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more PARAVIRT_XXL noinstr clean Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144517.759631860@infradead.org> <510b9b68-7d53-7d4d-5a05-37fbd199eb4b@csail.mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: "juri.lelli@redhat.com" , "rafael@kernel.org" , Benjamin Herrenschmidt , "linus.walleij@linaro.org" , "bsegall@google.com" , "guoren@kernel.org" , "pavel@ucw.cz" , "agordeev@linux.ibm.com" , "linux-clk@vger.kernel.org" , linux-arch , "vincent.guittot@linaro.org" , "mpe@ellerman.id.au" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Ingo Molnar , "geert@linux-m68k.org" , "linux-imx@nxp.com" , Catalin Marinas , "xen-devel@lists.xenproject.org" , "mattst88@gmail.com" , "lpieralisi@kernel.org" , "sammy@sammy.net" , "pmladek@suse.com" , "linux-pm@vger.kernel.org" , "ink@jurassic.park.msu.ru" , "jiangshanlai@gmail.com" , Sascha Hauer , "linux-um@lists.infradead.org" , "acme@kernel.org" , Thomas Gleixner , "linux-omap@vger.kernel.org" , "dietmar.eggemann@arm.com" , "rth@twiddle.net" , Greg Kroah-Hartman , LKML , "linux-perf-users@vger.kernel.org" , "senozhatsky@chromium.org" , "svens@linux.ibm.com" , "kernel@pengutronix.de" , "paulus@samba.org" , "mark.rutland@arm.com" , "linux-ia64@vger.kernel.org" , Dave Hansen , Linux Virtualization , "James.Bottomley@hansenpartnership.com" , "jcmvbkbc@gmail.com" , "thierry.reding@gmail.com" , "kernel@xen0n.name" , "quic_neeraju@quicinc.com" , linux-s390 , "vschneid@redhat.com" , "john.ogness@linutronix.de" , "ysato@users.sourceforge.jp" , "festevam@gmail.com" , "deller@gmx.de" , "daniel.lezcano@linaro.org" , "jonathanh@nvidia.com" , "hca@linux.ibm.com" , "lenb@kernel.org" , "linux-xtensa@linux-xtensa.org" , "jolsa@kernel.org" , "gor@linux.ibm.com" , "linux-arm-msm@vger.kernel.org" , "sudeep.holla@arm.com" , "linux-m68k@lists.linux-m68k.org" , "shorne@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "chris@zankel.net" , "sboyd@kernel.org" , "dinguyen@kernel.org" , "bristot@redhat.com" , "chenhuacai@kernel.org" , "alexander.shishkin@linux.intel.com" , "mturquette@baylibre.com" , "linux@rasmusvillemoes.dk" , "joel@joelfernandes.org" , Will Deacon , Boris Ostrovsky , "khilman@kernel.org" , "linux-csky@vger.kernel.org" , "tony@atomide.com" , "linux-snps-arc@lists.infradead.org" , Mel Gorman , "jacob.jun.pan@linux.intel.com" , Arnd Bergmann , "ulli.kroll@googlemail.com" , "vgupta@kernel.org" , "josh@joshtriplett.org" , Steven Rostedt , "rcu@vger.kernel.org" , Mathieu Desnoyers , "bcain@quicinc.com" , "tsbogend@alpha.franken.de" , "linux-parisc@vger.kernel.org" , "anup@brainfault.org" , "linux-alpha@vger.kernel.org" , "shawnguo@kernel.org" , "davem@davemloft.net" , "dalias@libc.org" , Pv-drivers , "bjorn.andersson@linaro.org" , "H. Peter Anvin" , "sparclinux@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Anton Ivanov , "jonas@southpole.se" , "yury.norov@gmail.com" , "richard@nod.at" , X86 ML , "linux@armlinux.org.uk" , "agross@kernel.org" , "aou@eecs.berkeley.edu" , "paulmck@kernel.org" , "frederic@kernel.org" , "stefan.kristiansson@saunalahti.fi" , "openrisc@lists.librecores.org" , "paul.walmsley@sifive.com" , "linux-tegra@vger.kernel.org" , "namhyung@kernel.org" , "andriy.shevchenko@linux.intel.com" , "jpoimboe@kernel.org" , Juergen Gross , "monstr@monstr.eu" , "linux-mips@vger.kernel.org" , "palmer@dabbelt.com" , "linux-hexagon@vger.kernel.org" , Borislav Petkov , "johannes@sipsolutions.net" , linuxppc-dev X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gTW9uLCBKdW4gMTMsIDIwMjIgYXQgMDc6MjM6MTNQTSArMDAwMCwgTmFkYXYgQW1pdCB3cm90 ZToKPiBPbiBKdW4gMTMsIDIwMjIsIGF0IDExOjQ4IEFNLCBTcml2YXRzYSBTLiBCaGF0IDxzcml2 YXRzYUBjc2FpbC5taXQuZWR1PiB3cm90ZToKPiAKPiA+IOKaoCBFeHRlcm5hbCBFbWFpbAo+ID4g Cj4gPiBPbiA2LzgvMjIgNDoyNyBQTSwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6Cj4gPj4gdm1saW51 eC5vOiB3YXJuaW5nOiBvYmp0b29sOiBhY3BpX2lkbGVfZW50ZXJfczJpZGxlKzB4ZGU6IGNhbGwg dG8gd2JpbnZkKCkgbGVhdmVzIC5ub2luc3RyLnRleHQgc2VjdGlvbgo+ID4+IHZtbGludXgubzog d2FybmluZzogb2JqdG9vbDogZGVmYXVsdF9pZGxlKzB4NDogY2FsbCB0byBhcmNoX3NhZmVfaGFs dCgpIGxlYXZlcyAubm9pbnN0ci50ZXh0IHNlY3Rpb24KPiA+PiB2bWxpbnV4Lm86IHdhcm5pbmc6 IG9ianRvb2w6IHhlbl9zYWZlX2hhbHQrMHhhOiBjYWxsIHRvIEhZUEVSVklTT1Jfc2NoZWRfb3Au Y29uc3Rwcm9wLjAoKSBsZWF2ZXMgLm5vaW5zdHIudGV4dCBzZWN0aW9uCj4gPj4gCj4gPj4gU2ln bmVkLW9mZi1ieTogUGV0ZXIgWmlqbHN0cmEgKEludGVsKSA8cGV0ZXJ6QGluZnJhZGVhZC5vcmc+ Cj4gPiAKPiA+IFJldmlld2VkLWJ5OiBTcml2YXRzYSBTLiBCaGF0IChWTXdhcmUpIDxzcml2YXRz YUBjc2FpbC5taXQuZWR1Pgo+ID4gCj4gPj4gCj4gPj4gLXN0YXRpYyBpbmxpbmUgdm9pZCB3Ymlu dmQodm9pZCkKPiA+PiArZXh0ZXJuIG5vaW5zdHIgdm9pZCBwdl9uYXRpdmVfd2JpbnZkKHZvaWQp Owo+ID4+ICsKPiA+PiArc3RhdGljIF9fYWx3YXlzX2lubGluZSB2b2lkIHdiaW52ZCh2b2lkKQo+ ID4+IHsKPiA+PiAgICAgIFBWT1BfQUxUX1ZDQUxMMChjcHUud2JpbnZkLCAid2JpbnZkIiwgQUxU X05PVChYODZfRkVBVFVSRV9YRU5QVikpOwo+ID4+IH0KPiAKPiBJIGd1ZXNzIGl0IGlzIHlldCBh bm90aGVyIGluc3RhbmNlIG9mIHdyb25nIGFjY291bnRpbmcgb2YgR0NDIGZvcgo+IHRoZSBhc3Nl bWJseSBibG9ja3PigJkgd2VpZ2h0LiBJIGd1ZXNzIGl0IGlzIG5vdCBhIHNvbHV0aW9uIGZvciBv bGRlcgo+IEdDQ3MsIGJ1dCBwcmVzdW1hYmx5IF9fX19QVk9QX0FMVF9DQUxMKCkgYW5kIGZyaWVu ZHMgc2hvdWxkIGhhdmUKPiB1c2VkIGFzbV9pbmxpbmUgb3Igc29tZSBuZXcg4oCcYXNtX3ZvbGF0 aWxlX2lubGluZeKAnSB2YXJpYW50LgoKUGFydGlhbGx5LCBzb21lIG9mIHRoZSAqU0FOIG9wdGlv bnMgYWxzbyBnZW5lcmF0ZSBhIG1ldHJpYyB0b24gb2YKbm9uc2Vuc2Ugd2hlbiBlbmFibGVkIGFu ZCBza2V3IHRoZSBjb21waWxlcnMgdG93YXJkcyBub3QgaW5saW5pbmcKdGhpbmdzLgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBt YWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0 cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6 YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF867CCA487 for ; Tue, 14 Jun 2022 16:45:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240932AbiFNQov (ORCPT ); Tue, 14 Jun 2022 12:44:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235710AbiFNQoT (ORCPT ); Tue, 14 Jun 2022 12:44:19 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA35919037; Tue, 14 Jun 2022 09:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=lGPDnVOvpW5cJYkNK5aiO+HQt8YloxSeZZcAt0L3T+0=; b=MN0E+GuQLLm4tM+GK8hWccQUFL PxmHsP4/A97SKIR0+ews6BPbY8JdimA4zzl8B8x1wTlPZj26+HyDjOVxj1Wvti7DkxrdahnIWXznf Sck8K5ryGTb2H97Q25XV5ua07NtZrt8RBovpr0tuOchGW9iLxyJb1i6ZL47+Eas56Gb5nEQiTe9bW l/5aGjKZFL1yA3gACFUDFeCqx4zcJMLiRKrPP5Wx+chh5o0sU6RQZsB3HldVraUQWhIlzWIv4ONvZ B8VU2ERHT/yK/yX47pqt+Uyn9a6PeiG9bFg6pm7fHV4nB44DfSKBjrV02VjqvtliTo2mpR5esSTG4 vZhkhfdg==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19eA-000KXf-9W; Tue, 14 Jun 2022 16:44:06 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BEA18300372; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A1F7228B3F630; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Date: Tue, 14 Jun 2022 18:44:02 +0200 From: Peter Zijlstra To: Nadav Amit Cc: "srivatsa@csail.mit.edu" , "juri.lelli@redhat.com" , "rafael@kernel.org" , Benjamin Herrenschmidt , "linus.walleij@linaro.org" , "bsegall@google.com" , "guoren@kernel.org" , "pavel@ucw.cz" , "agordeev@linux.ibm.com" , "linux-clk@vger.kernel.org" , linux-arch , "vincent.guittot@linaro.org" , "mpe@ellerman.id.au" , "chenhuacai@kernel.org" , "linux-acpi@vger.kernel.org" , "agross@kernel.org" , "geert@linux-m68k.org" , "linux-imx@nxp.com" , Catalin Marinas , "xen-devel@lists.xenproject.org" , "mattst88@gmail.com" , "borntraeger@linux.ibm.com" , "mturquette@baylibre.com" , "sammy@sammy.net" , "pmladek@suse.com" , "linux-pm@vger.kernel.org" , "jiangshanlai@gmail.com" , Sascha Hauer , "linux-um@lists.infradead.org" , "acme@kernel.org" , Thomas Gleixner , "linux-omap@vger.kernel.org" , "dietmar.eggemann@arm.com" , "rth@twiddle.net" , Greg Kroah-Hartman , LKML , "linux-perf-users@vger.kernel.org" , "senozhatsky@chromium.org" , "svens@linux.ibm.com" , "jolsa@kernel.org" , "paulus@samba.org" , "mark.rutland@arm.com" , "linux-ia64@vger.kernel.org" , Dave Hansen , Linux Virtualization , "James.Bottomley@hansenpartnership.com" , "jcmvbkbc@gmail.com" , "thierry.reding@gmail.com" , "kernel@xen0n.name" , "quic_neeraju@quicinc.com" , linux-s390 , "vschneid@redhat.com" , "john.ogness@linutronix.de" , "ysato@users.sourceforge.jp" , "linux-sh@vger.kernel.org" , "festevam@gmail.com" , "deller@gmx.de" , "daniel.lezcano@linaro.org" , "jonathanh@nvidia.com" , Mathieu Desnoyers , "frederic@kernel.org" , "lenb@kernel.org" , "linux-xtensa@linux-xtensa.org" , "kernel@pengutronix.de" , "gor@linux.ibm.com" , "linux-arm-msm@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "shorne@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "chris@zankel.net" , "sboyd@kernel.org" , "dinguyen@kernel.org" , "bristot@redhat.com" , "alexander.shishkin@linux.intel.com" , "lpieralisi@kernel.org" , "linux@rasmusvillemoes.dk" , "joel@joelfernandes.org" , Will Deacon , Boris Ostrovsky , "khilman@kernel.org" , "linux-csky@vger.kernel.org" , Pv-drivers , "linux-snps-arc@lists.infradead.org" , Mel Gorman , "jacob.jun.pan@linux.intel.com" , Arnd Bergmann , "ulli.kroll@googlemail.com" , "vgupta@kernel.org" , "josh@joshtriplett.org" , Steven Rostedt , "rcu@vger.kernel.org" , Borislav Petkov , "bcain@quicinc.com" , "tsbogend@alpha.franken.de" , "linux-parisc@vger.kernel.org" , "sudeep.holla@arm.com" , "shawnguo@kernel.org" , "davem@davemloft.net" , "dalias@libc.org" , "tony@atomide.com" , "bjorn.andersson@linaro.org" , "H. Peter Anvin" , "sparclinux@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Anton Ivanov , "jonas@southpole.se" , "yury.norov@gmail.com" , "richard@nod.at" , X86 ML , "linux@armlinux.org.uk" , Ingo Molnar , "aou@eecs.berkeley.edu" , "paulmck@kernel.org" , "hca@linux.ibm.com" , "stefan.kristiansson@saunalahti.fi" , "openrisc@lists.librecores.org" , "paul.walmsley@sifive.com" , "linux-tegra@vger.kernel.org" , "namhyung@kernel.org" , "andriy.shevchenko@linux.intel.com" , "jpoimboe@kernel.org" , Juergen Gross , "monstr@monstr.eu" , "linux-mips@vger.kernel.org" , "palmer@dabbelt.com" , "anup@brainfault.org" , "ink@jurassic.park.msu.ru" , "johannes@sipsolutions.net" , linuxppc-dev Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more PARAVIRT_XXL noinstr clean Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144517.759631860@infradead.org> <510b9b68-7d53-7d4d-5a05-37fbd199eb4b@csail.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Mon, Jun 13, 2022 at 07:23:13PM +0000, Nadav Amit wrote: > On Jun 13, 2022, at 11:48 AM, Srivatsa S. Bhat wrote: > > > ⚠ External Email > > > > On 6/8/22 4:27 PM, Peter Zijlstra wrote: > >> vmlinux.o: warning: objtool: acpi_idle_enter_s2idle+0xde: call to wbinvd() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: default_idle+0x4: call to arch_safe_halt() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: xen_safe_halt+0xa: call to HYPERVISOR_sched_op.constprop.0() leaves .noinstr.text section > >> > >> Signed-off-by: Peter Zijlstra (Intel) > > > > Reviewed-by: Srivatsa S. Bhat (VMware) > > > >> > >> -static inline void wbinvd(void) > >> +extern noinstr void pv_native_wbinvd(void); > >> + > >> +static __always_inline void wbinvd(void) > >> { > >> PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV)); > >> } > > I guess it is yet another instance of wrong accounting of GCC for > the assembly blocks’ weight. I guess it is not a solution for older > GCCs, but presumably ____PVOP_ALT_CALL() and friends should have > used asm_inline or some new “asm_volatile_inline” variant. Partially, some of the *SAN options also generate a metric ton of nonsense when enabled and skew the compilers towards not inlining things. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33B19C433EF for ; Tue, 14 Jun 2022 17:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pPXd0iKbLuhNMpxMsrD+rOuvSaG+ulGrpF285X7SLdk=; b=hEbjR+JPyvquLa Zq3lRLfNsaxprG0mrZ8v78WVT2syhSq+Vfnip3F5VxydImgotI5k1qY2QDBXaB8QbIB1LIYLPM02G qUfHSLDIOavrmzq9ZwskTO6csR1uI1vgbNyno17TiBe5Dt0eLn7x8/HnAg+/mmaxeZUZx5JoPjLm7 UG4IlrbOjce5WdPueZI5YvGx6dQQ1rRXXLWlTKooNPzYU6m0X8Toe/tiAv5AhZY+8XzOtay/9nIV9 9vDTmGoN1gCu6WvePF3Fdzyg/8S5mZIq5GQP4gJSwk2uH4Mt/9rlFN2tuuOhv8jKPq2Cs2AfRoNKC ombPtA0nHZJzMs5/1UeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1AFr-00AYVh-V0; Tue, 14 Jun 2022 17:23:03 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19eF-00APQJ-FQ; Tue, 14 Jun 2022 16:44:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=lGPDnVOvpW5cJYkNK5aiO+HQt8YloxSeZZcAt0L3T+0=; b=DAyjnelx4YBZDCDKjW1vABnwD6 bfuQInSMcO0k1N9c43zulrHrt0FEspCLqBV7dzVlaMMaDm/0d8h+E1vx/Mn16eV+mdIA5cFTuH3pJ ZPctIYIGAc1IQVFMkXT59RectB0+FvezRUN6pXOBo7jPhyxeW7DquiSvQAiutE+ZX5GvtHgbHFHRx 6HNiF1zBAiNoXSUuUybOLrpKXxYLhLp7SkKzRQuOg8AsSzW4GjX7X7PIc8C1Yqe4MS+PoRyI4eENc TnTVXl8b+mj78ByEoizyUwQl4K8tWC0/1bV8h78+HtzLeArX034mK97ekOVdMcZW15wljxz2QwCm7 eJasXJFA==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19e7-007uTz-7Y; Tue, 14 Jun 2022 16:44:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BBDAE3002BE; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A1F7228B3F630; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Date: Tue, 14 Jun 2022 18:44:02 +0200 From: Peter Zijlstra To: Nadav Amit Cc: "srivatsa@csail.mit.edu" , "juri.lelli@redhat.com" , "rafael@kernel.org" , Benjamin Herrenschmidt , "linus.walleij@linaro.org" , "bsegall@google.com" , "guoren@kernel.org" , "pavel@ucw.cz" , "agordeev@linux.ibm.com" , "linux-clk@vger.kernel.org" , linux-arch , "vincent.guittot@linaro.org" , "mpe@ellerman.id.au" , "chenhuacai@kernel.org" , "linux-acpi@vger.kernel.org" , "agross@kernel.org" , "geert@linux-m68k.org" , "linux-imx@nxp.com" , Catalin Marinas , "xen-devel@lists.xenproject.org" , "mattst88@gmail.com" , "borntraeger@linux.ibm.com" , "mturquette@baylibre.com" , "sammy@sammy.net" , "pmladek@suse.com" , "linux-pm@vger.kernel.org" , "jiangshanlai@gmail.com" , Sascha Hauer , "linux-um@lists.infradead.org" , "acme@kernel.org" , Thomas Gleixner , "linux-omap@vger.kernel.org" , "dietmar.eggemann@arm.com" , "rth@twiddle.net" , Greg Kroah-Hartman , LKML , "linux-perf-users@vger.kernel.org" , "senozhatsky@chromium.org" , "svens@linux.ibm.com" , "jolsa@kernel.org" , "paulus@samba.org" , "mark.rutland@arm.com" , "linux-ia64@vger.kernel.org" , Dave Hansen , Linux Virtualization , "James.Bottomley@hansenpartnership.com" , "jcmvbkbc@gmail.com" , "thierry.reding@gmail.com" , "kernel@xen0n.name" , "quic_neeraju@quicinc.com" , linux-s390 , "vschneid@redhat.com" , "john.ogness@linutronix.de" , "ysato@users.sourceforge.jp" , "linux-sh@vger.kernel.org" , "festevam@gmail.com" , "deller@gmx.de" , "daniel.lezcano@linaro.org" , "jonathanh@nvidia.com" , Mathieu Desnoyers , "frederic@kernel.org" , "lenb@kernel.org" , "linux-xtensa@linux-xtensa.org" , "kernel@pengutronix.de" , "gor@linux.ibm.com" , "linux-arm-msm@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "shorne@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "chris@zankel.net" , "sboyd@kernel.org" , "dinguyen@kernel.org" , "bristot@redhat.com" , "alexander.shishkin@linux.intel.com" , "lpieralisi@kernel.org" , "linux@rasmusvillemoes.dk" , "joel@joelfernandes.org" , Will Deacon , Boris Ostrovsky , "khilman@kernel.org" , "linux-csky@vger.kernel.org" , Pv-drivers , "linux-snps-arc@lists.infradead.org" , Mel Gorman , "jacob.jun.pan@linux.intel.com" , Arnd Bergmann , "ulli.kroll@googlemail.com" , "vgupta@kernel.org" , "josh@joshtriplett.org" , Steven Rostedt , "rcu@vger.kernel.org" , Borislav Petkov , "bcain@quicinc.com" , "tsbogend@alpha.franken.de" , "linux-parisc@vger.kernel.org" , "sudeep.holla@arm.com" , "shawnguo@kernel.org" , "davem@davemloft.net" , "dalias@libc.org" , "tony@atomide.com" , "bjorn.andersson@linaro.org" , "H. Peter Anvin" , "sparclinux@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Anton Ivanov , "jonas@southpole.se" , "yury.norov@gmail.com" , "richard@nod.at" , X86 ML , "linux@armlinux.org.uk" , Ingo Molnar , "aou@eecs.berkeley.edu" , "paulmck@kernel.org" , "hca@linux.ibm.com" , "stefan.kristiansson@saunalahti.fi" , "openrisc@lists.librecores.org" , "paul.walmsley@sifive.com" , "linux-tegra@vger.kernel.org" , "namhyung@kernel.org" , "andriy.shevchenko@linux.intel.com" , "jpoimboe@kernel.org" , Juergen Gross , "monstr@monstr.eu" , "linux-mips@vger.kernel.org" , "palmer@dabbelt.com" , "anup@brainfault.org" , "ink@jurassic.park.msu.ru" , "johannes@sipsolutions.net" , linuxppc-dev Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more PARAVIRT_XXL noinstr clean Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144517.759631860@infradead.org> <510b9b68-7d53-7d4d-5a05-37fbd199eb4b@csail.mit.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Tue, 14 Jun 2022 10:23:02 -0700 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMTMsIDIwMjIgYXQgMDc6MjM6MTNQTSArMDAwMCwgTmFkYXYgQW1pdCB3cm90 ZToKPiBPbiBKdW4gMTMsIDIwMjIsIGF0IDExOjQ4IEFNLCBTcml2YXRzYSBTLiBCaGF0IDxzcml2 YXRzYUBjc2FpbC5taXQuZWR1PiB3cm90ZToKPiAKPiA+IOKaoCBFeHRlcm5hbCBFbWFpbAo+ID4g Cj4gPiBPbiA2LzgvMjIgNDoyNyBQTSwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6Cj4gPj4gdm1saW51 eC5vOiB3YXJuaW5nOiBvYmp0b29sOiBhY3BpX2lkbGVfZW50ZXJfczJpZGxlKzB4ZGU6IGNhbGwg dG8gd2JpbnZkKCkgbGVhdmVzIC5ub2luc3RyLnRleHQgc2VjdGlvbgo+ID4+IHZtbGludXgubzog d2FybmluZzogb2JqdG9vbDogZGVmYXVsdF9pZGxlKzB4NDogY2FsbCB0byBhcmNoX3NhZmVfaGFs dCgpIGxlYXZlcyAubm9pbnN0ci50ZXh0IHNlY3Rpb24KPiA+PiB2bWxpbnV4Lm86IHdhcm5pbmc6 IG9ianRvb2w6IHhlbl9zYWZlX2hhbHQrMHhhOiBjYWxsIHRvIEhZUEVSVklTT1Jfc2NoZWRfb3Au Y29uc3Rwcm9wLjAoKSBsZWF2ZXMgLm5vaW5zdHIudGV4dCBzZWN0aW9uCj4gPj4gCj4gPj4gU2ln bmVkLW9mZi1ieTogUGV0ZXIgWmlqbHN0cmEgKEludGVsKSA8cGV0ZXJ6QGluZnJhZGVhZC5vcmc+ Cj4gPiAKPiA+IFJldmlld2VkLWJ5OiBTcml2YXRzYSBTLiBCaGF0IChWTXdhcmUpIDxzcml2YXRz YUBjc2FpbC5taXQuZWR1Pgo+ID4gCj4gPj4gCj4gPj4gLXN0YXRpYyBpbmxpbmUgdm9pZCB3Ymlu dmQodm9pZCkKPiA+PiArZXh0ZXJuIG5vaW5zdHIgdm9pZCBwdl9uYXRpdmVfd2JpbnZkKHZvaWQp Owo+ID4+ICsKPiA+PiArc3RhdGljIF9fYWx3YXlzX2lubGluZSB2b2lkIHdiaW52ZCh2b2lkKQo+ ID4+IHsKPiA+PiAgICAgIFBWT1BfQUxUX1ZDQUxMMChjcHUud2JpbnZkLCAid2JpbnZkIiwgQUxU X05PVChYODZfRkVBVFVSRV9YRU5QVikpOwo+ID4+IH0KPiAKPiBJIGd1ZXNzIGl0IGlzIHlldCBh bm90aGVyIGluc3RhbmNlIG9mIHdyb25nIGFjY291bnRpbmcgb2YgR0NDIGZvcgo+IHRoZSBhc3Nl bWJseSBibG9ja3PigJkgd2VpZ2h0LiBJIGd1ZXNzIGl0IGlzIG5vdCBhIHNvbHV0aW9uIGZvciBv bGRlcgo+IEdDQ3MsIGJ1dCBwcmVzdW1hYmx5IF9fX19QVk9QX0FMVF9DQUxMKCkgYW5kIGZyaWVu ZHMgc2hvdWxkIGhhdmUKPiB1c2VkIGFzbV9pbmxpbmUgb3Igc29tZSBuZXcg4oCcYXNtX3ZvbGF0 aWxlX2lubGluZeKAnSB2YXJpYW50LgoKUGFydGlhbGx5LCBzb21lIG9mIHRoZSAqU0FOIG9wdGlv bnMgYWxzbyBnZW5lcmF0ZSBhIG1ldHJpYyB0b24gb2YKbm9uc2Vuc2Ugd2hlbiBlbmFibGVkIGFu ZCBza2V3IHRoZSBjb21waWxlcnMgdG93YXJkcyBub3QgaW5saW5pbmcKdGhpbmdzLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFp bGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.librecores.org (lists.librecores.org [88.198.125.70]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3FECCA47A for ; Tue, 14 Jun 2022 20:02:03 +0000 (UTC) Received: from [172.31.1.100] (localhost.localdomain [127.0.0.1]) by mail.librecores.org (Postfix) with ESMTP id EEC56249B3; Tue, 14 Jun 2022 22:02:02 +0200 (CEST) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by mail.librecores.org (Postfix) with ESMTPS id 9E1292496D for ; Tue, 14 Jun 2022 18:44:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=lGPDnVOvpW5cJYkNK5aiO+HQt8YloxSeZZcAt0L3T+0=; b=DAyjnelx4YBZDCDKjW1vABnwD6 bfuQInSMcO0k1N9c43zulrHrt0FEspCLqBV7dzVlaMMaDm/0d8h+E1vx/Mn16eV+mdIA5cFTuH3pJ ZPctIYIGAc1IQVFMkXT59RectB0+FvezRUN6pXOBo7jPhyxeW7DquiSvQAiutE+ZX5GvtHgbHFHRx 6HNiF1zBAiNoXSUuUybOLrpKXxYLhLp7SkKzRQuOg8AsSzW4GjX7X7PIc8C1Yqe4MS+PoRyI4eENc TnTVXl8b+mj78ByEoizyUwQl4K8tWC0/1bV8h78+HtzLeArX034mK97ekOVdMcZW15wljxz2QwCm7 eJasXJFA==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19e7-007uTz-7Y; Tue, 14 Jun 2022 16:44:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BBDAE3002BE; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A1F7228B3F630; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Date: Tue, 14 Jun 2022 18:44:02 +0200 From: Peter Zijlstra To: Nadav Amit Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more PARAVIRT_XXL noinstr clean Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144517.759631860@infradead.org> <510b9b68-7d53-7d4d-5a05-37fbd199eb4b@csail.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailman-Approved-At: Tue, 14 Jun 2022 22:01:55 +0200 X-BeenThere: openrisc@lists.librecores.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussion around the OpenRISC processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "juri.lelli@redhat.com" , "rafael@kernel.org" , Benjamin Herrenschmidt , "linus.walleij@linaro.org" , "bsegall@google.com" , "guoren@kernel.org" , "pavel@ucw.cz" , "agordeev@linux.ibm.com" , "linux-clk@vger.kernel.org" , linux-arch , "vincent.guittot@linaro.org" , "mpe@ellerman.id.au" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Ingo Molnar , "linux-imx@nxp.com" , Catalin Marinas , "xen-devel@lists.xenproject.org" , "mattst88@gmail.com" , "borntraeger@linux.ibm.com" , "lpieralisi@kernel.org" , "sammy@sammy.net" , "pmladek@suse.com" , "linux-pm@vger.kernel.org" , "ink@jurassic.park.msu.ru" , "jiangshanlai@gmail.com" , Sascha Hauer , "linux-um@lists.infradead.org" , "acme@kernel.org" , Thomas Gleixner , "linux-omap@vger.kernel.org" , "dietmar.eggemann@arm.com" , "rth@twiddle.net" , Greg Kroah-Hartman , LKML , "linux-perf-users@vger.kernel.org" , "senozhatsky@chromium.org" , "svens@linux.ibm.com" , "kernel@pengutronix.de" , "paulus@samba.org" , "mark.rutland@arm.com" , "linux-ia64@vger.kernel.org" , Dave Hansen , Linux Virtualization , "James.Bottomley@hansenpartnership.com" , "jcmvbkbc@gmail.com" , "thierry.reding@gmail.com" , "kernel@xen0n.name" , "quic_neeraju@quicinc.com" , linux-s390 , "vschneid@redhat.com" , "john.ogness@linutronix.de" , "ysato@users.sourceforge.jp" , "festevam@gmail.com" , "deller@gmx.de" , "daniel.lezcano@linaro.org" , "jonathanh@nvidia.com" , "hca@linux.ibm.com" , "lenb@kernel.org" , "linux-xtensa@linux-xtensa.org" , "jolsa@kernel.org" , "gor@linux.ibm.com" , "linux-arm-msm@vger.kernel.org" , "sudeep.holla@arm.com" , "linux-m68k@lists.linux-m68k.org" , "linux-arm-kernel@lists.infradead.org" , "chris@zankel.net" , "sboyd@kernel.org" , "dinguyen@kernel.org" , "bristot@redhat.com" , "chenhuacai@kernel.org" , "alexander.shishkin@linux.intel.com" , "mturquette@baylibre.com" , "linux@rasmusvillemoes.dk" , "joel@joelfernandes.org" , Will Deacon , Boris Ostrovsky , "khilman@kernel.org" , "linux-csky@vger.kernel.org" , "tony@atomide.com" , "linux-snps-arc@lists.infradead.org" , Mel Gorman , "jacob.jun.pan@linux.intel.com" , Arnd Bergmann , "ulli.kroll@googlemail.com" , "vgupta@kernel.org" , "josh@joshtriplett.org" , Steven Rostedt , "rcu@vger.kernel.org" , Mathieu Desnoyers , "bcain@quicinc.com" , "tsbogend@alpha.franken.de" , "linux-parisc@vger.kernel.org" , "anup@brainfault.org" , "srivatsa@csail.mit.edu" , "linux-alpha@vger.kernel.org" , "shawnguo@kernel.org" , "davem@davemloft.net" , "dalias@libc.org" , Pv-drivers , "bjorn.andersson@linaro.org" , "H. Peter Anvin" , "sparclinux@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Anton Ivanov , "jonas@southpole.se" , "yury.norov@gmail.com" , "richard@nod.at" , X86 ML , "linux@armlinux.org.uk" , "agross@kernel.org" , "aou@eecs.berkeley.edu" , "paulmck@kernel.org" , "frederic@kernel.org" , "openrisc@lists.librecores.org" , "paul.walmsley@sifive.com" , "linux-tegra@vger.kernel.org" , "namhyung@kernel.org" , "andriy.shevchenko@linux.intel.com" , "jpoimboe@kernel.org" , Juergen Gross , "monstr@monstr.eu" , "linux-mips@vger.kernel.org" , "palmer@dabbelt.com" , "linux-hexagon@vger.kernel.org" , Borislav Petkov , "johannes@sipsolutions.net" , linuxppc-dev Errors-To: openrisc-bounces@lists.librecores.org Sender: "OpenRISC" On Mon, Jun 13, 2022 at 07:23:13PM +0000, Nadav Amit wrote: > On Jun 13, 2022, at 11:48 AM, Srivatsa S. Bhat wrote: > > > ⚠ External Email > > > > On 6/8/22 4:27 PM, Peter Zijlstra wrote: > >> vmlinux.o: warning: objtool: acpi_idle_enter_s2idle+0xde: call to wbinvd() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: default_idle+0x4: call to arch_safe_halt() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: xen_safe_halt+0xa: call to HYPERVISOR_sched_op.constprop.0() leaves .noinstr.text section > >> > >> Signed-off-by: Peter Zijlstra (Intel) > > > > Reviewed-by: Srivatsa S. Bhat (VMware) > > > >> > >> -static inline void wbinvd(void) > >> +extern noinstr void pv_native_wbinvd(void); > >> + > >> +static __always_inline void wbinvd(void) > >> { > >> PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV)); > >> } > > I guess it is yet another instance of wrong accounting of GCC for > the assembly blocks’ weight. I guess it is not a solution for older > GCCs, but presumably ____PVOP_ALT_CALL() and friends should have > used asm_inline or some new “asm_volatile_inline” variant. Partially, some of the *SAN options also generate a metric ton of nonsense when enabled and skew the compilers towards not inlining things. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0F8DC43334 for ; Wed, 15 Jun 2022 04:06:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.349287.575761 (Exim 4.92) (envelope-from ) id 1o1KHs-0007qx-40; Wed, 15 Jun 2022 04:05:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 349287.575761; Wed, 15 Jun 2022 04:05:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o1KHr-0007pP-N7; Wed, 15 Jun 2022 04:05:47 +0000 Received: by outflank-mailman (input) for mailman id 349287; Tue, 14 Jun 2022 16:44:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o19ev-0008Hf-1X for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 16:44:53 +0000 Received: from desiato.infradead.org (desiato.infradead.org [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e4b972e-ec01-11ec-a26a-b96bd03d9e80; Tue, 14 Jun 2022 18:44:51 +0200 (CEST) Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19e7-007uTz-7Y; Tue, 14 Jun 2022 16:44:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BBDAE3002BE; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A1F7228B3F630; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e4b972e-ec01-11ec-a26a-b96bd03d9e80 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=lGPDnVOvpW5cJYkNK5aiO+HQt8YloxSeZZcAt0L3T+0=; b=DAyjnelx4YBZDCDKjW1vABnwD6 bfuQInSMcO0k1N9c43zulrHrt0FEspCLqBV7dzVlaMMaDm/0d8h+E1vx/Mn16eV+mdIA5cFTuH3pJ ZPctIYIGAc1IQVFMkXT59RectB0+FvezRUN6pXOBo7jPhyxeW7DquiSvQAiutE+ZX5GvtHgbHFHRx 6HNiF1zBAiNoXSUuUybOLrpKXxYLhLp7SkKzRQuOg8AsSzW4GjX7X7PIc8C1Yqe4MS+PoRyI4eENc TnTVXl8b+mj78ByEoizyUwQl4K8tWC0/1bV8h78+HtzLeArX034mK97ekOVdMcZW15wljxz2QwCm7 eJasXJFA==; Date: Tue, 14 Jun 2022 18:44:02 +0200 From: Peter Zijlstra To: Nadav Amit Cc: "srivatsa@csail.mit.edu" , "juri.lelli@redhat.com" , "rafael@kernel.org" , Benjamin Herrenschmidt , "linus.walleij@linaro.org" , "bsegall@google.com" , "guoren@kernel.org" , "pavel@ucw.cz" , "agordeev@linux.ibm.com" , "linux-clk@vger.kernel.org" , linux-arch , "vincent.guittot@linaro.org" , "mpe@ellerman.id.au" , "chenhuacai@kernel.org" , "linux-acpi@vger.kernel.org" , "agross@kernel.org" , "geert@linux-m68k.org" , "linux-imx@nxp.com" , Catalin Marinas , "xen-devel@lists.xenproject.org" , "mattst88@gmail.com" , "borntraeger@linux.ibm.com" , "mturquette@baylibre.com" , "sammy@sammy.net" , "pmladek@suse.com" , "linux-pm@vger.kernel.org" , "jiangshanlai@gmail.com" , Sascha Hauer , "linux-um@lists.infradead.org" , "acme@kernel.org" , Thomas Gleixner , "linux-omap@vger.kernel.org" , "dietmar.eggemann@arm.com" , "rth@twiddle.net" , Greg Kroah-Hartman , LKML , "linux-perf-users@vger.kernel.org" , "senozhatsky@chromium.org" , "svens@linux.ibm.com" , "jolsa@kernel.org" , "paulus@samba.org" , "mark.rutland@arm.com" , "linux-ia64@vger.kernel.org" , Dave Hansen , Linux Virtualization , "James.Bottomley@hansenpartnership.com" , "jcmvbkbc@gmail.com" , "thierry.reding@gmail.com" , "kernel@xen0n.name" , "quic_neeraju@quicinc.com" , linux-s390 , "vschneid@redhat.com" , "john.ogness@linutronix.de" , "ysato@users.sourceforge.jp" , "linux-sh@vger.kernel.org" , "festevam@gmail.com" , "deller@gmx.de" , "daniel.lezcano@linaro.org" , "jonathanh@nvidia.com" , Mathieu Desnoyers , "frederic@kernel.org" , "lenb@kernel.org" , "linux-xtensa@linux-xtensa.org" , "kernel@pengutronix.de" , "gor@linux.ibm.com" , "linux-arm-msm@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "shorne@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "chris@zankel.net" , "sboyd@kernel.org" , "dinguyen@kernel.org" , "bristot@redhat.com" , "alexander.shishkin@linux.intel.com" , "lpieralisi@kernel.org" , "linux@rasmusvillemoes.dk" , "joel@joelfernandes.org" , Will Deacon , Boris Ostrovsky , "khilman@kernel.org" , "linux-csky@vger.kernel.org" , Pv-drivers , "linux-snps-arc@lists.infradead.org" , Mel Gorman , "jacob.jun.pan@linux.intel.com" , Arnd Bergmann , "ulli.kroll@googlemail.com" , "vgupta@kernel.org" , "josh@joshtriplett.org" , Steven Rostedt , "rcu@vger.kernel.org" , Borislav Petkov , "bcain@quicinc.com" , "tsbogend@alpha.franken.de" , "linux-parisc@vger.kernel.org" , "sudeep.holla@arm.com" , "shawnguo@kernel.org" , "davem@davemloft.net" , "dalias@libc.org" , "tony@atomide.com" , "bjorn.andersson@linaro.org" , "H. Peter Anvin" , "sparclinux@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Anton Ivanov , "jonas@southpole.se" , "yury.norov@gmail.com" , "richard@nod.at" , X86 ML , "linux@armlinux.org.uk" , Ingo Molnar , "aou@eecs.berkeley.edu" , "paulmck@kernel.org" , "hca@linux.ibm.com" , "stefan.kristiansson@saunalahti.fi" , "openrisc@lists.librecores.org" , "paul.walmsley@sifive.com" , "linux-tegra@vger.kernel.org" , "namhyung@kernel.org" , "andriy.shevchenko@linux.intel.com" , "jpoimboe@kernel.org" , Juergen Gross , "monstr@monstr.eu" , "linux-mips@vger.kernel.org" , "palmer@dabbelt.com" , "anup@brainfault.org" , "ink@jurassic.park.msu.ru" , "johannes@sipsolutions.net" , linuxppc-dev Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more PARAVIRT_XXL noinstr clean Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144517.759631860@infradead.org> <510b9b68-7d53-7d4d-5a05-37fbd199eb4b@csail.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jun 13, 2022 at 07:23:13PM +0000, Nadav Amit wrote: > On Jun 13, 2022, at 11:48 AM, Srivatsa S. Bhat wrote: > > > ⚠ External Email > > > > On 6/8/22 4:27 PM, Peter Zijlstra wrote: > >> vmlinux.o: warning: objtool: acpi_idle_enter_s2idle+0xde: call to wbinvd() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: default_idle+0x4: call to arch_safe_halt() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: xen_safe_halt+0xa: call to HYPERVISOR_sched_op.constprop.0() leaves .noinstr.text section > >> > >> Signed-off-by: Peter Zijlstra (Intel) > > > > Reviewed-by: Srivatsa S. Bhat (VMware) > > > >> > >> -static inline void wbinvd(void) > >> +extern noinstr void pv_native_wbinvd(void); > >> + > >> +static __always_inline void wbinvd(void) > >> { > >> PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV)); > >> } > > I guess it is yet another instance of wrong accounting of GCC for > the assembly blocks’ weight. I guess it is not a solution for older > GCCs, but presumably ____PVOP_ALT_CALL() and friends should have > used asm_inline or some new “asm_volatile_inline” variant. Partially, some of the *SAN options also generate a metric ton of nonsense when enabled and skew the compilers towards not inlining things. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8525C43334 for ; Tue, 14 Jun 2022 22:14:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LN2mZ49ltz3f1d for ; Wed, 15 Jun 2022 08:14:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=DAyjnelx; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=peterz@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=DAyjnelx; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LMvRd4X4Lz2xnN for ; Wed, 15 Jun 2022 02:44:45 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=lGPDnVOvpW5cJYkNK5aiO+HQt8YloxSeZZcAt0L3T+0=; b=DAyjnelx4YBZDCDKjW1vABnwD6 bfuQInSMcO0k1N9c43zulrHrt0FEspCLqBV7dzVlaMMaDm/0d8h+E1vx/Mn16eV+mdIA5cFTuH3pJ ZPctIYIGAc1IQVFMkXT59RectB0+FvezRUN6pXOBo7jPhyxeW7DquiSvQAiutE+ZX5GvtHgbHFHRx 6HNiF1zBAiNoXSUuUybOLrpKXxYLhLp7SkKzRQuOg8AsSzW4GjX7X7PIc8C1Yqe4MS+PoRyI4eENc TnTVXl8b+mj78ByEoizyUwQl4K8tWC0/1bV8h78+HtzLeArX034mK97ekOVdMcZW15wljxz2QwCm7 eJasXJFA==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o19e7-007uTz-7Y; Tue, 14 Jun 2022 16:44:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BBDAE3002BE; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A1F7228B3F630; Tue, 14 Jun 2022 18:44:02 +0200 (CEST) Date: Tue, 14 Jun 2022 18:44:02 +0200 From: Peter Zijlstra To: Nadav Amit Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more PARAVIRT_XXL noinstr clean Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144517.759631860@infradead.org> <510b9b68-7d53-7d4d-5a05-37fbd199eb4b@csail.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailman-Approved-At: Wed, 15 Jun 2022 08:01:46 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "juri.lelli@redhat.com" , "rafael@kernel.org" , "linus.walleij@linaro.org" , "bsegall@google.com" , "guoren@kernel.org" , "pavel@ucw.cz" , "agordeev@linux.ibm.com" , "linux-clk@vger.kernel.org" , linux-arch , "vincent.guittot@linaro.org" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Ingo Molnar , "geert@linux-m68k.org" , "linux-imx@nxp.com" , Catalin Marinas , "xen-devel@lists.xenproject.org" , "mattst88@gmail.com" , "borntraeger@linux.ibm.com" , "lpieralisi@kernel.org" , "sammy@sammy.net" , "pmladek@suse.com" , "linux-pm@vger.kernel.org" , "ink@jurassic.park.msu.ru" , "jiangshanlai@gmail.com" , Sascha Hauer , "linux-um@lists.infradead.org" , "acme@kernel.org" , Thomas Gleixner , "linux-omap@vger.kernel.org" , "dietmar.eggemann@arm.com" , "rth@twiddle.net" , Greg Kroah-Hartman , LKML , "linux-perf-users@vger.kernel.org" , "senozhatsky@chromium.org" , "svens@linux.ibm.com" , "kernel@pengutronix.de" , "paulus@samba.org" , "mark.rutland@arm.com" , "linux-ia64@vger.kernel.org" , Dave Hansen , Linux Virtualization , "James.Bottomley@hansenpartnership.com" , "jcmvbkbc@gmail.com" , "thierry.reding@gmail.com" , "kernel@xen0n.name" , "quic_neeraju@quicinc.com" , linux-s390 , "vschneid@redhat.com" , "john.ogness@linutronix.de" , "ysato@users.sourceforge.jp" , "festevam@gmail.com" , "deller@gmx.de" , "daniel.lezcano@linaro.org" , "jonathanh@nvidia.com" , "hca@linux.ibm.com" , "lenb@kernel.org" , "linux-xtensa@linux-xtensa.org" , "jolsa@kernel.org" , "gor@linux.ibm.com" , "linux-arm-msm@vger.kernel.org" , "sudeep.hol la@arm.com" , "linux-m68k@lists.linux-m68k.org" , "shorne@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "chris@zankel.net" , "sboyd@kernel.org" , "dinguyen@kernel.org" , "bristot@redhat.com" , "chenhuacai@kernel.org" , "alexander.shishkin@linux.intel.com" , "mturquette@baylibre.com" , "linux@rasmusvillemoes.dk" , "joel@joelfernandes.org" , Will Deacon , Boris Ostrovsky , "khilman@kernel.org" , "linux-csky@vger.kernel.org" , "tony@atomide.com" , "linux-snps-arc@lists.infradead.org" , Mel Gorman , "j acob.jun.pan@linux.intel.com" , Arnd Bergmann , "ulli.kroll@googlemail.com" , "vgupta@kernel.org" , "josh@joshtriplett.org" , Steven Rostedt , "rcu@vger.kernel.org" , Mathieu Desnoyers , "bcain@quicinc.com" , "tsbogend@alpha.franken.de" , "linux-parisc@vger.kernel.org" , "anup@brainfault.org" , "srivatsa@csail.mit.edu" , "linux-alpha@vger.kernel.org" , "shawnguo@kernel.org" , "davem@davemloft.net" , "dalias@libc.org" , Pv-drivers , "bjorn.andersson@linaro.org" , "H. Peter Anvin" , "sparclinux@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Anton Ivanov , "jonas@southpole.se" , "yury.norov@gmail.com" , "richard@nod.at" , X86 ML , "linux@armlinux.org.uk" , "agross@kernel.org" , "aou@eecs.berkeley.edu" , "paulmck@kernel.org" , "frederic@kernel.org" , "stefan.kristiansson@saunalahti.fi" , "openrisc@lists.librecores.org" , "paul.walmsley@sifive.com" , "linux-tegra@vger.kernel.org" , "namhyung@kernel.org" , "andriy.shevchenko@linux.intel.com" , "jpoimboe@kernel.org" , Juergen Gross , "monstr@monstr.eu" , "linux-mips@vger.kernel.org" , "palmer@dabbelt.com" , "linux- hexagon@vger.kernel.org" , Borislav Petkov , "johannes@sipsolutions.net" , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jun 13, 2022 at 07:23:13PM +0000, Nadav Amit wrote: > On Jun 13, 2022, at 11:48 AM, Srivatsa S. Bhat wrote: > > > ⚠ External Email > > > > On 6/8/22 4:27 PM, Peter Zijlstra wrote: > >> vmlinux.o: warning: objtool: acpi_idle_enter_s2idle+0xde: call to wbinvd() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: default_idle+0x4: call to arch_safe_halt() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: xen_safe_halt+0xa: call to HYPERVISOR_sched_op.constprop.0() leaves .noinstr.text section > >> > >> Signed-off-by: Peter Zijlstra (Intel) > > > > Reviewed-by: Srivatsa S. Bhat (VMware) > > > >> > >> -static inline void wbinvd(void) > >> +extern noinstr void pv_native_wbinvd(void); > >> + > >> +static __always_inline void wbinvd(void) > >> { > >> PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV)); > >> } > > I guess it is yet another instance of wrong accounting of GCC for > the assembly blocks’ weight. I guess it is not a solution for older > GCCs, but presumably ____PVOP_ALT_CALL() and friends should have > used asm_inline or some new “asm_volatile_inline” variant. Partially, some of the *SAN options also generate a metric ton of nonsense when enabled and skew the compilers towards not inlining things. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Tue, 14 Jun 2022 16:44:02 +0000 Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more PARAVIRT_XXL noinstr clean Message-Id: List-Id: References: <20220608142723.103523089@infradead.org> <20220608144517.759631860@infradead.org> <510b9b68-7d53-7d4d-5a05-37fbd199eb4b@csail.mit.edu> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Nadav Amit Cc: "srivatsa@csail.mit.edu" , "juri.lelli@redhat.com" , "rafael@kernel.org" , Benjamin Herrenschmidt , "linus.walleij@linaro.org" , "bsegall@google.com" , "guoren@kernel.org" , "pavel@ucw.cz" , "agordeev@linux.ibm.com" , "linux-clk@vger.kernel.org" , linux-arch , "vincent.guittot@linaro.org" , "mpe@ellerman.id.au" , "chenhuacai@kernel.org" , "linux-acpi@vger.kernel.org" , "agross@kernel.org" , "geert@linux-m68k.org" , "linux-imx@nxp.com" , Catalin Marinas , "xen-devel@lists.xenproject.org" , "mattst88@gmail.com" , "borntraeger@linux.ibm.com" , "mturquette@baylibre.com" , "sammy@sammy.net" , "pmladek@suse.com" , "linux-pm@vger.kernel.org" , "jiangshanlai@gmail.com" , Sascha Hauer , "linux-um@lists.infradead.org" , "acme@kernel.org" , Thomas Gleixner , "linux-omap@vger.kernel.org" , "dietmar.eggemann@arm.com" , "rth@twiddle.net" , Greg Kroah-Hartman , LKML , "linux-perf-users@vger.kernel.org" , "senozhatsky@chromium.org" , "svens@linux.ibm.com" , "jolsa@kernel.org" , "paulus@samba.org" , "mark.rutland@arm.com" , "linux-ia64@vger.kernel.org" , Dave Hansen , Linux Virtualization , "James.Bottomley@hansenpartnership.com" , "jcmvbkbc@gmail.com" , "thierry.reding@gmail.com" , "kernel@xen0n.name" , "quic_neeraju@quicinc.com" , linux-s390 , "vschneid@redhat.com" , "john.ogness@linutronix.de" , "ysato@users.sourceforge.jp" , "linux-sh@vger.kernel.org" , "festevam@gmail.com" , "deller@gmx.de" , "daniel.lezcano@linaro.org" , "jonathanh@nvidia.com" , Mathieu Desnoyers , "frederic@kernel.org" , "lenb@kernel.org" , "linux-xtensa@linux-xtensa.org" , "kernel@pengutronix.de" , "gor@linux.ibm.com" , "linux-arm-msm@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "shorne@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "chris@zankel.net" , "sboyd@kernel.org" , "dinguyen@kernel.org" , "bristot@redhat.com" , "alexander.shishkin@linux.intel.com" , "lpieralisi@kernel.org" , "linux@rasmusvillemoes.dk" , "joel@joelfernandes.org" , Will Deacon , Boris Ostrovsky , "khilman@kernel.org" , "linux-csky@vger.kernel.org" , Pv-drivers , "linux-snps-arc@lists.infradead.org" , Mel Gorman , "jacob.jun.pan@linux.intel.com" , Arnd Bergmann , "ulli.kroll@googlemail.com" , "vgupta@kernel.org" , "josh@joshtriplett.org" , Steven Rostedt , "rcu@vger.kernel.org" , Borislav Petkov , "bcain@quicinc.com" , "tsbogend@alpha.franken.de" , "linux-parisc@vger.kernel.org" , "sudeep.holla@arm.com" , "shawnguo@kernel.org" , "davem@davemloft.net" , "dalias@libc.org" , "tony@atomide.com" , "bjorn.andersson@linaro.org" , "H. Peter Anvin" , "sparclinux@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Anton Ivanov , "jonas@southpole.se" , "yury.norov@gmail.com" , "richard@nod.at" , X86 ML , "linux@armlinux.org.uk" , Ingo Molnar , "aou@eecs.berkeley.edu" , "paulmck@kernel.org" , "hca@linux.ibm.com" , "stefan.kristiansson@saunalahti.fi" , "openrisc@lists.librecores.org" , "paul.walmsley@sifive.com" , "linux-tegra@vger.kernel.org" , "namhyung@kernel.org" , "andriy.shevchenko@linux.intel.com" , "jpoimboe@kernel.org" , Juergen Gross , "monstr@monstr.eu" , "linux-mips@vger.kernel.org" , "palmer@dabbelt.com" , "anup@brainfault.org" , "ink@jurassic.park.msu.ru" , "johannes@sipsolutions.net" , linuxppc-dev On Mon, Jun 13, 2022 at 07:23:13PM +0000, Nadav Amit wrote: > On Jun 13, 2022, at 11:48 AM, Srivatsa S. Bhat wrote: > > > ⚠ External Email > > > > On 6/8/22 4:27 PM, Peter Zijlstra wrote: > >> vmlinux.o: warning: objtool: acpi_idle_enter_s2idle+0xde: call to wbinvd() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: default_idle+0x4: call to arch_safe_halt() leaves .noinstr.text section > >> vmlinux.o: warning: objtool: xen_safe_halt+0xa: call to HYPERVISOR_sched_op.constprop.0() leaves .noinstr.text section > >> > >> Signed-off-by: Peter Zijlstra (Intel) > > > > Reviewed-by: Srivatsa S. Bhat (VMware) > > > >> > >> -static inline void wbinvd(void) > >> +extern noinstr void pv_native_wbinvd(void); > >> + > >> +static __always_inline void wbinvd(void) > >> { > >> PVOP_ALT_VCALL0(cpu.wbinvd, "wbinvd", ALT_NOT(X86_FEATURE_XENPV)); > >> } > > I guess it is yet another instance of wrong accounting of GCC for > the assembly blocks’ weight. I guess it is not a solution for older > GCCs, but presumably ____PVOP_ALT_CALL() and friends should have > used asm_inline or some new “asm_volatile_inline” variant. Partially, some of the *SAN options also generate a metric ton of nonsense when enabled and skew the compilers towards not inlining things. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [Pv-drivers] [PATCH 29/36] cpuidle, xenpv: Make more PARAVIRT_XXL noinstr clean Date: Tue, 14 Jun 2022 18:44:02 +0200 Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144517.759631860@infradead.org> <510b9b68-7d53-7d4d-5a05-37fbd199eb4b@csail.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=lGPDnVOvpW5cJYkNK5aiO+HQt8YloxSeZZcAt0L3T+0=; b=DAyjnelx4YBZDCDKjW1vABnwD6 bfuQInSMcO0k1N9c43zulrHrt0FEspCLqBV7dzVlaMMaDm/0d8h+E1vx/Mn16eV+mdIA5cFTuH3pJ ZPctIYIGAc1IQVFMkXT59RectB0+FvezRUN6pXOBo7jPhyxeW7DquiSvQAiutE+ZX5GvtHgbHFHRx 6HNiF1zBAiNoXSUuUybOLrpKXxYLhLp7SkKzRQuOg8AsSzW4GjX7X7PIc8C1Yqe4MS+PoRyI4eENc TnTVXl8b+mj78ByEoizyUwQl4K8tWC0/1bV8h78+HtzLeArX034mK97ekOVdMcZW15wljxz2QwCm7 eJasXJFA==; Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Nadav Amit Cc: "juri.lelli@redhat.com" , "rafael@kernel.org" , Benjamin Herrenschmidt , "linus.walleij@linaro.org" , "bsegall@google.com" , "guoren@kernel.org" , "pavel@ucw.cz" , "agordeev@linux.ibm.com" , "linux-clk@vger.kernel.org" , linux-arch , "vincent.guittot@linaro.org" , "mpe@ellerman.id.au" , "linux-sh@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Ingo Molnar , "geert@linux-m68k.org" , "linux-imx@nxp.com" , Catalin Marinas , "xen-devel@lists.xenproject.org" T24gTW9uLCBKdW4gMTMsIDIwMjIgYXQgMDc6MjM6MTNQTSArMDAwMCwgTmFkYXYgQW1pdCB3cm90 ZToKPiBPbiBKdW4gMTMsIDIwMjIsIGF0IDExOjQ4IEFNLCBTcml2YXRzYSBTLiBCaGF0IDxzcml2 YXRzYUBjc2FpbC5taXQuZWR1PiB3cm90ZToKPiAKPiA+IOKaoCBFeHRlcm5hbCBFbWFpbAo+ID4g Cj4gPiBPbiA2LzgvMjIgNDoyNyBQTSwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6Cj4gPj4gdm1saW51 eC5vOiB3YXJuaW5nOiBvYmp0b29sOiBhY3BpX2lkbGVfZW50ZXJfczJpZGxlKzB4ZGU6IGNhbGwg dG8gd2JpbnZkKCkgbGVhdmVzIC5ub2luc3RyLnRleHQgc2VjdGlvbgo+ID4+IHZtbGludXgubzog d2FybmluZzogb2JqdG9vbDogZGVmYXVsdF9pZGxlKzB4NDogY2FsbCB0byBhcmNoX3NhZmVfaGFs dCgpIGxlYXZlcyAubm9pbnN0ci50ZXh0IHNlY3Rpb24KPiA+PiB2bWxpbnV4Lm86IHdhcm5pbmc6 IG9ianRvb2w6IHhlbl9zYWZlX2hhbHQrMHhhOiBjYWxsIHRvIEhZUEVSVklTT1Jfc2NoZWRfb3Au Y29uc3Rwcm9wLjAoKSBsZWF2ZXMgLm5vaW5zdHIudGV4dCBzZWN0aW9uCj4gPj4gCj4gPj4gU2ln bmVkLW9mZi1ieTogUGV0ZXIgWmlqbHN0cmEgKEludGVsKSA8cGV0ZXJ6QGluZnJhZGVhZC5vcmc+ Cj4gPiAKPiA+IFJldmlld2VkLWJ5OiBTcml2YXRzYSBTLiBCaGF0IChWTXdhcmUpIDxzcml2YXRz YUBjc2FpbC5taXQuZWR1Pgo+ID4gCj4gPj4gCj4gPj4gLXN0YXRpYyBpbmxpbmUgdm9pZCB3Ymlu dmQodm9pZCkKPiA+PiArZXh0ZXJuIG5vaW5zdHIgdm9pZCBwdl9uYXRpdmVfd2JpbnZkKHZvaWQp Owo+ID4+ICsKPiA+PiArc3RhdGljIF9fYWx3YXlzX2lubGluZSB2b2lkIHdiaW52ZCh2b2lkKQo+ ID4+IHsKPiA+PiAgICAgIFBWT1BfQUxUX1ZDQUxMMChjcHUud2JpbnZkLCAid2JpbnZkIiwgQUxU X05PVChYODZfRkVBVFVSRV9YRU5QVikpOwo+ID4+IH0KPiAKPiBJIGd1ZXNzIGl0IGlzIHlldCBh bm90aGVyIGluc3RhbmNlIG9mIHdyb25nIGFjY291bnRpbmcgb2YgR0NDIGZvcgo+IHRoZSBhc3Nl bWJseSBibG9ja3PigJkgd2VpZ2h0LiBJIGd1ZXNzIGl0IGlzIG5vdCBhIHNvbHV0aW9uIGZvciBv bGRlcgo+IEdDQ3MsIGJ1dCBwcmVzdW1hYmx5IF9fX19QVk9QX0FMVF9DQUxMKCkgYW5kIGZyaWVu ZHMgc2hvdWxkIGhhdmUKPiB1c2VkIGFzbV9pbmxpbmUgb3Igc29tZSBuZXcg4oCcYXNtX3ZvbGF0 aWxlX2lubGluZeKAnSB2YXJpYW50LgoKUGFydGlhbGx5LCBzb21lIG9mIHRoZSAqU0FOIG9wdGlv bnMgYWxzbyBnZW5lcmF0ZSBhIG1ldHJpYyB0b24gb2YKbm9uc2Vuc2Ugd2hlbiBlbmFibGVkIGFu ZCBza2V3IHRoZSBjb21waWxlcnMgdG93YXJkcyBub3QgaW5saW5pbmcKdGhpbmdzLgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBt YWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0 cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6 YXRpb24=