Re: [PATCH V15 6/9] mfd: pm8008: Use i2c_new_dummy_device() API

From: Mark Brown <broonie@kernel.org>
To: "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, quic_collinsd@quicinc.com,
	quic_subbaram@quicinc.com, quic_jprakash@quicinc.com
Subject: Re: [PATCH V15 6/9] mfd: pm8008: Use i2c_new_dummy_device() API
Date: Wed, 13 Jul 2022 14:14:38 +0100	[thread overview]
Message-ID: <Ys7FPt/KfRjgj3nL@sirena.org.uk> (raw)
In-Reply-To: <08460c2a-8e21-f149-edec-ee3523f1b727@quicinc.com>

[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]

On Wed, Jul 13, 2022 at 11:20:43AM +0530, Satya Priya Kakitapalli (Temp) wrote:
> On 7/12/2022 6:17 PM, Lee Jones wrote:
> > On Mon, 11 Jul 2022, Satya Priya Kakitapalli (Temp) wrote:
> > 
> > > On 7/4/2022 6:19 PM, Lee Jones wrote:
> > > > On Mon, 04 Jul 2022, Satya Priya Kakitapalli (Temp) wrote:
> > > > 
> > > > > On 7/1/2022 2:42 PM, Lee Jones wrote:
> > > > > > On Fri, 01 Jul 2022, Satya Priya Kakitapalli (Temp) wrote:
> > > > > > 
> > > > > > > On 7/1/2022 1:24 PM, Lee Jones wrote:
> > > > > > > > On Fri, 01 Jul 2022, Satya Priya Kakitapalli (Temp) wrote:
> > > > > > > > 
> > > > > > > > > On 6/30/2022 4:04 PM, Lee Jones wrote:
> > > > > > > > > > On Thu, 30 Jun 2022, Satya Priya Kakitapalli (Temp) wrote:
> > > > > > > > > > 
> > > > > > > > > > > On 6/29/2022 8:48 PM, Lee Jones wrote:
> > > > > > > > > > > > On Wed, 29 Jun 2022, Satya Priya Kakitapalli (Temp) wrote:

Please delete unneeded context from mails when replying.  Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.

> > That's not to say that the v9 submission was the right way to go
> > either.  Everything in relation to:
> > 
> >    i2c_add_driver(&pm8008_regulators_driver);
> > 
> > ... should be moved into the Regulator driver itself.

> Mark/Stephen,
> 
> 
> Could you please share your inputs on this approach?

I don't have particularly strong opinions.  It does seem like the chip
should be visible as being a single entity in DT if it's a single
physical thing in the schematic and board.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]