From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH v2] replay: notify CPU on event
Date: Mon, 29 Mar 2021 14:10:40 +0200 [thread overview]
Message-ID: <a05d12f6-7e2a-53f5-5aaf-1fbdea8b0bb5@redhat.com> (raw)
In-Reply-To: <4be6bee2-fa58-09ec-439f-8ccd99a965e8@ispras.ru>
On 29/03/21 13:23, Pavel Dovgalyuk wrote:
>>
>> I still do not understand why the qemu_clock_notify function is used
>> to notify the CPU. It would be nice to have a description of the call
>> chain in a comment or to have a more appropriate API. I can queue the
>> patch since it's deep in replay-events.c and not in common code, but
>> if you post a short description here I'll integrate it.
>
> Maybe I missed something.
> This call is needed for the case when vCPU is waiting in rr_wait_io_event.
> You mean that we can use qemu_cpu_kick instead?
I have no idea. Using qemu_clock_notify however is definitely weird.
Paolo
next prev parent reply other threads:[~2021-03-29 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 7:43 [PATCH v2] replay: notify CPU on event Pavel Dovgalyuk
2021-03-29 10:29 ` Paolo Bonzini
2021-03-29 11:23 ` Pavel Dovgalyuk
2021-03-29 12:10 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-16 9:34 Pavel Dovgalyuk
2021-02-24 8:26 ` Pavel Dovgalyuk
2021-03-15 6:01 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a05d12f6-7e2a-53f5-5aaf-1fbdea8b0bb5@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.