From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF4BFC433EF for ; Fri, 3 Dec 2021 11:26:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.237403.411781 (Exim 4.92) (envelope-from ) id 1mt6he-00018N-9i; Fri, 03 Dec 2021 11:26:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 237403.411781; Fri, 03 Dec 2021 11:26:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt6he-00018A-6i; Fri, 03 Dec 2021 11:26:10 +0000 Received: by outflank-mailman (input) for mailman id 237403; Fri, 03 Dec 2021 11:26:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mt6hd-0000G0-Oa for xen-devel@lists.xenproject.org; Fri, 03 Dec 2021 11:26:09 +0000 Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cf5d8ee3-542b-11ec-b1df-f38ee3fbfdf7; Fri, 03 Dec 2021 12:26:09 +0100 (CET) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:40488) by ppsw-43.csi.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.139]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1mt6hV-000KAH-nr (Exim 4.95) (return-path ); Fri, 03 Dec 2021 11:26:01 +0000 Received: from [192.168.1.10] (host-92-12-61-86.as13285.net [92.12.61.86]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id 3AD7E1FD7A; Fri, 3 Dec 2021 11:26:01 +0000 (GMT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf5d8ee3-542b-11ec-b1df-f38ee3fbfdf7 X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: Date: Fri, 3 Dec 2021 11:26:01 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point Content-Language: en-GB To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <46de3a57-76d0-1538-ec3b-79290d1bfb70@suse.com> <8b369fc8-8f9e-c350-95de-790d47fd9aae@suse.com> <8413bd97-90f5-1b9b-9090-d9fd3bcbcc66@srcf.net> <00c116e8-b3d4-bd78-781d-21a4057e989b@suse.com> From: Andrew Cooper In-Reply-To: <00c116e8-b3d4-bd78-781d-21a4057e989b@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 03/12/2021 11:25, Jan Beulich wrote: > On 03.12.2021 12:21, Andrew Cooper wrote: >> On 03/12/2021 10:56, Jan Beulich wrote: >>> When it was introduced, it was imo placed way too high up, making it >>> necessary to forward-declare way too many static functions. Move it down >>> together with >>> - the efi_check_dt_boot() stub, which afaict was deliberately placed >>> immediately ahead of the #include, >>> - blexit(), because of its use of the efi_arch_blexit() hook. >>> Move up get_value() and set_color() to before the inclusion so their >>> forward declarations can also be zapped. >>> >>> Signed-off-by: Jan Beulich >> Why does blexit() need moving?  It isn't static, and has a real >> prototype in efi.h > Oops - clearly an oversight of mine. With that left as was, everything else looks fine, so the whole series Acked-by: Andrew Cooper