All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Krish Sadhukhan <krish.sadhukhan@oracle.com>,
	Eric Auger <eric.auger@redhat.com>,
	eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, vkuznets@redhat.com
Cc: thuth@redhat.com, drjones@redhat.com, wei.huang2@amd.com
Subject: Re: [PATCH v4 3/3] selftests: KVM: SVM: Add vmcall test
Date: Wed, 12 Feb 2020 12:45:04 +0100	[thread overview]
Message-ID: <a30f5513-d80b-a4e9-0279-995bf5c6417a@redhat.com> (raw)
In-Reply-To: <2469b52e-9f66-b19b-7269-297dbbd0ca27@oracle.com>

On 06/02/20 23:46, Krish Sadhukhan wrote:
>>
>> +
>> +static inline void l2_vmcall(struct svm_test_data *svm)
>> +{
>> +    __asm__ __volatile__("vmcall");
> Is it possible to re-use the existing vmcall() function ?

Technically the AMD opcode is "vmmcall".  Using vmcall() still makes
sense as it tests KVM's emulation of the Intel opcode.

> Also, we should probably re-name the function to 'l2_guest_code' which
> is used in the existing code and also it matches with 'l1_guest_code'
> naming.

Ok.  I also removed the "inline" which is really not used since we take
the address of the function.

Paolo


      parent reply	other threads:[~2020-02-12 11:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 10:47 [PATCH v4 0/3] selftests: KVM: AMD Nested SVM test infrastructure Eric Auger
2020-02-06 10:47 ` [PATCH v4 1/3] selftests: KVM: Replace get_gdt/idt_base() by get_gdt/idt() Eric Auger
2020-02-06 17:13   ` Wei Huang
2020-02-06 19:17   ` Krish Sadhukhan
2020-02-06 10:47 ` [PATCH v4 2/3] selftests: KVM: AMD Nested test infrastructure Eric Auger
2020-02-06 12:20   ` Vitaly Kuznetsov
2020-02-06 12:27     ` Auger Eric
2020-02-06 22:57   ` Krish Sadhukhan
2020-02-07  9:16     ` Vitaly Kuznetsov
2020-02-07 14:16     ` Auger Eric
2020-02-12 11:38     ` Paolo Bonzini
2020-02-06 10:47 ` [PATCH v4 3/3] selftests: KVM: SVM: Add vmcall test Eric Auger
2020-02-06 17:39   ` Wei Huang
2020-02-06 19:08     ` Krish Sadhukhan
2020-02-07 10:05       ` Auger Eric
2020-02-07 10:15     ` Auger Eric
2020-02-12 11:43       ` Paolo Bonzini
2020-02-06 22:46   ` Krish Sadhukhan
2020-02-07 14:06     ` Auger Eric
2020-02-12 11:45     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a30f5513-d80b-a4e9-0279-995bf5c6417a@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thuth@redhat.com \
    --cc=vkuznets@redhat.com \
    --cc=wei.huang2@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.