All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/8] mkfs: Quota support
Date: Sat, 28 Oct 2017 07:57:31 +0800	[thread overview]
Message-ID: <a358fe47-920d-25e8-3d4d-7c1fb7b7c8c3@gmx.com> (raw)
In-Reply-To: <20171027173709.GO3521@twin.jikos.cz>


[-- Attachment #1.1: Type: text/plain, Size: 2174 bytes --]



On 2017年10月28日 01:37, David Sterba wrote:
> On Fri, Oct 27, 2017 at 03:29:28PM +0800, Qu Wenruo wrote:
>> This patchset adds quota support, which means the result fs will have
>> quota enabled by default, and its accounting is already consistent, no
>> manually rescan or quota enable is needed.
> 
> Great, thanks for working on that. I'm going to merge the preparatory
> patches next. I'm not sure about the command line option, we might want
> to design it in a similar way as -O/--features. As this is a runtime
> feature (unlike the on-disk format features), a new option will be
> needed, backed by some research what other mkfs.* tools use.

OK, I'll reconsider the command line interface.

Although I'm not pretty sure if other fs will has such design.

> 
> The uuid_tree would at least use the btrfs_create_tree, but I don't
> think we'd need to create it only on request, so quotas will be the only
> option.
> 
>> 2) Fill quota root with basic skeleton
>>    Only 3 items are really needed
>>    a) global quota status item
>>    b) quota info for 0/5 qgroup
>>    c) quota limit for 0/5 qgroup
>>
>>    The content doesn't matter at all.
> 
> How would --rootdir and quotas behave in that case? A related question
> is what will be the semantics of rootdir+quotas+subvolume created at
> mkfs time.

Already considered! (Although not in test case)

For current behavior, rootdir works fine, as we only use one subvolume
(fs tree) and rescan is placed just after we filled fs tree.

So, as you could try your self, it's completely fine.

And the infrastructure I used in the helpers can easily handle the case
where extra subvolume qgroups are used.
Just pass insert_qgroup_items() with new qgroupid, then rescan will
handle them all.

Thanks,
Qu

> 
> We can certainly start with only quotas on the empty filesystem, but I'm
> sure somebody will ask for the wild combination at some point.> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 520 bytes --]

  reply	other threads:[~2017-10-27 23:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27  7:29 [PATCH 0/8] mkfs: Quota support Qu Wenruo
2017-10-27  7:29 ` [PATCH 1/8] btrfs-progs: qgroup-verify: Also repair qgroup status version Qu Wenruo
2017-10-27  7:29 ` [PATCH 2/8] btrfs-progs: qgroup-verify: Use fs_info->readonly to check if we should repair qgroups Qu Wenruo
2017-10-27  7:29 ` [PATCH 3/8] btrfs-progs: qgroup-verify: Move qgroup classification out of report_qgroups Qu Wenruo
2017-11-04 14:20   ` Lu Fengqi
2017-10-27  7:29 ` [PATCH 4/8] btrfs-progs: qgroup-verify: Allow repair_qgroups function to do silent repair Qu Wenruo
2017-10-27  7:29 ` [PATCH 5/8] btrfs-progs: ctree: Introduce function to create an empty tree Qu Wenruo
2017-11-03  9:12   ` Lu Fengqi
2017-10-27  7:29 ` [PATCH 6/8] btrfs-progs: mkfs: Introduce function to insert qgroup info and limit items Qu Wenruo
2017-10-27  7:29 ` [PATCH 7/8] btrfs-progs: mkfs: Introduce option to enable quota at mkfs time Qu Wenruo
2017-10-27  7:29 ` [PATCH 8/8] btrfs-progs: test/mkfs: Add test case for --enable-quota option Qu Wenruo
2017-10-27 17:37 ` [PATCH 0/8] mkfs: Quota support David Sterba
2017-10-27 23:57   ` Qu Wenruo [this message]
2017-11-01  7:18   ` Qu Wenruo
2017-11-04 14:28 ` Lu Fengqi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a358fe47-920d-25e8-3d4d-7c1fb7b7c8c3@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.