From: David Ahern <dsahern@gmail.com>
To: "Ido Schimmel" <idosch@idosch.org>,
"Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: "Maciej Żenczykowski" <maze@google.com>,
"David S . Miller" <davem@davemloft.net>,
"Linux Network Development Mailing List" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net-icmp: make icmp{,v6} (ping) sockets available to all by default
Date: Sat, 9 May 2020 15:20:38 -0600 [thread overview]
Message-ID: <a4fefa7c-8e8a-6975-aa06-b71ba1885f7b@gmail.com> (raw)
In-Reply-To: <20200509191536.GA370521@splinter>
On 5/9/20 1:15 PM, Ido Schimmel wrote:
>
> This will unfortunately cause regressions with VRFs because they don't
> work correctly with ping sockets. Simple example:
Thanks for catching this, Ido.
>
> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
> index 535427292194..8463b0e9e811 100644
> --- a/net/ipv4/ping.c
> +++ b/net/ipv4/ping.c
> @@ -297,6 +297,7 @@ static int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk,
> struct net *net = sock_net(sk);
> if (sk->sk_family == AF_INET) {
> struct sockaddr_in *addr = (struct sockaddr_in *) uaddr;
> + u32 tb_id = RT_TABLE_LOCAL;
> int chk_addr_ret;
>
> if (addr_len < sizeof(*addr))
> @@ -310,7 +311,15 @@ static int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk,
> pr_debug("ping_check_bind_addr(sk=%p,addr=%pI4,port=%d)\n",
> sk, &addr->sin_addr.s_addr, ntohs(addr->sin_port));
>
> - chk_addr_ret = inet_addr_type(net, addr->sin_addr.s_addr);
> + if (sk->sk_bound_dev_if) {
that's the key point - checking sk->sk_bound_dev_if.
> + tb_id = l3mdev_fib_table_by_index(net,
> + sk->sk_bound_dev_if);
> + if (!tb_id)
> + tb_id = RT_TABLE_LOCAL;
> + }
> +
> + chk_addr_ret = inet_addr_type_table(net, addr->sin_addr.s_addr,
> + tb_id);
>
> if (addr->sin_addr.s_addr == htonl(INADDR_ANY))
> chk_addr_ret = RTN_LOCAL;
>
From a scan of the ipv4/ping.c code, ping_v4_sendmsg also does not
acknowledge sk->sk_bound_dev_if.
next prev parent reply other threads:[~2020-05-09 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 23:42 [PATCH] net-icmp: make icmp{,v6} (ping) sockets available to all by default Maciej Żenczykowski
2020-05-09 19:15 ` Ido Schimmel
2020-05-09 19:17 ` Maciej Żenczykowski
2020-05-09 19:32 ` Ido Schimmel
2020-05-09 21:09 ` David Ahern
2020-05-09 21:20 ` David Ahern [this message]
2020-05-09 21:35 ` Maciej Żenczykowski
2020-05-10 1:24 ` David Ahern
2020-05-10 5:15 ` Maciej Żenczykowski
2020-05-10 15:29 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4fefa7c-8e8a-6975-aa06-b71ba1885f7b@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.