From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44840C433F5 for ; Wed, 6 Apr 2022 08:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q8WKlYeoyT/xyP/Yqqxetph+5jbGTwZ26QDjY6uSb54=; b=RmYx/SrLXg9NOW 1b7JHQBk/81BCxsjQu7GB698Cg8VP1Jf+lBz6SpCTCZ4ya+qhG1Sz5dU8sZ+KRUfiu6vYVgYm6Yrm quMyvIiOopMroD/YTlaxt1Jny0u8B9kcCsqAkxgcY2mr+YM+5FcdvGm0BONfwuoKttFR7yTf7rUhy hzZ3aGUSg2HTdq6XaEv8ji+aRjRoRa19fu6i6ncyVv/6AAazC2QDxkGWIr5T55eFJAtb6Xi6HFhml 61FlJyo8f+mOMXGBz7o6o45+LxQ7HaTpuFkyZh+rRIqoxeuxeRn1ihRFdU4Y8B4Vm6moBanNKGCgU Tc8901rPeYcoV0nUtAJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc1A8-004l2t-4N; Wed, 06 Apr 2022 08:37:12 +0000 Received: from mail-m17637.qiye.163.com ([59.111.176.37]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc19p-004kuZ-Bk; Wed, 06 Apr 2022 08:36:55 +0000 Received: from [192.168.60.102] (unknown [103.29.142.67]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id B89019801AA; Wed, 6 Apr 2022 16:36:48 +0800 (CST) Message-ID: Date: Wed, 6 Apr 2022 16:36:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer Cc: Piotr Oniszczuk , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Kever Yang References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> <20220405093700.GQ4012@pengutronix.de> <12a8c0ef-90ee-cf7e-50a0-e00add8af147@rock-chips.com> <20220406081333.GU4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220406081333.GU4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUNKGR5WTEwaTktMGE4ZHU IZVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PBw6Ejo*LD5MI0oxNz0yDwgZ PD0KFDNVSlVKTU9CSUhPSUpKS05MVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZSktIVUlCVUpPSVVNTFlXWQgBWUFNSUhMNwY+ X-HM-Tid: 0a7ffe04ef24d992kuwsb89019801aa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_013653_641942_67DFE793 X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGk6CgpPbiA0LzYvMjIgMTY6MTMsIFNhc2NoYSBIYXVlciB3cm90ZToKPiBPbiBXZWQsIEFwciAw NiwgMjAyMiBhdCAxMDowMjo1OUFNICswODAwLCBBbmR5IFlhbiB3cm90ZToKPj4gSGk6Cj4+Cj4+ IE9uIDQvNS8yMiAxNzozNywgU2FzY2hhIEhhdWVyIHdyb3RlOgo+Pj4gT24gU2F0LCBBcHIgMDIs IDIwMjIgYXQgMDk6Mzc6MTdBTSArMDgwMCwgQW5keSBZYW4gd3JvdGU6Cj4+Pj4gSGkgU2FjaGE6 Cj4+Pj4KPj4+PiBPbiA0LzEvMjIgMjA6NTIsIFNhc2NoYSBIYXVlciB3cm90ZToKPj4+Pj4gLS0g Cj4+Pj4+ID5Gcm9tIGNiYzAzMDczNjIzYTcxODAyNDMzMzFhYzI0YzNhZmFmOWRlYzc1MjIgTW9u IFNlcCAxNyAwMDowMDowMCAyMDAxCj4+Pj4+IEZyb206IFNhc2NoYSBIYXVlcjxzLmhhdWVyQHBl bmd1dHJvbml4LmRlPgo+Pj4+PiBEYXRlOiBGcmksIDEgQXByIDIwMjIgMTQ6NDg6NDkgKzAyMDAK Pj4+Pj4gU3ViamVjdDogW1BBVENIXSBmaXh1cCEgZHJtOiByb2NrY2hpcDogQWRkIFZPUDIgZHJp dmVyCj4+Pj4+Cj4+Pj4+IC0tLQo+Pj4+PiAgICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3Jv Y2tjaGlwX2RybV92b3AyLmMgfCAxNCArKysrKysrKysrKysrKwo+Pj4+PiAgICAgMSBmaWxlIGNo YW5nZWQsIDE0IGluc2VydGlvbnMoKykKPj4+Pj4KPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wMi5jIGIvZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL3JvY2tjaGlwX2RybV92b3AyLmMKPj4+Pj4gaW5kZXggN2RiYTdiOWI2M2RjNi4uMTQy MWJmMmYxMzNmMSAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3Jv Y2tjaGlwX2RybV92b3AyLmMKPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3Jv Y2tjaGlwX2RybV92b3AyLmMKPj4+Pj4gQEAgLTIyODcsNiArMjI4NywyMCBAQCBzdGF0aWMgaW50 IHZvcDJfY3JlYXRlX2NydGMoc3RydWN0IHZvcDIgKnZvcDIpCj4+Pj4+ICAgICAJCQl9Cj4+Pj4+ ICAgICAJCX0KPj4+Pj4gKwkJaWYgKHZvcDItPmRhdGEtPnNvY19pZCA9PSAzNTY2KSB7Cj4+Pj4+ ICsJCQkvKgo+Pj4+PiArCQkJICogT24gUkszNTY2IHRoZXNlIHdpbmRvd3MgZG9uJ3QgaGF2ZSBh biBpbmRlcGVuZGVudAo+Pj4+PiArCQkJICogZnJhbWVidWZmZXIuIFRoZXkgc2hhcmUgdGhlIGZy YW1lYnVmZmVyIHdpdGggc21hcnQwLAo+Pj4+PiArCQkJICogZXNtYXJ0MCBhbmQgY2x1c3RlcjAg cmVzcGVjdGl2ZWx5Lgo+Pj4+PiArCQkJICovCj4+Pj4+ICsJCQlzd2l0Y2ggKHdpbi0+ZGF0YS0+ cGh5c19pZCkgewo+Pj4+PiArCQkJY2FzZSBST0NLQ0hJUF9WT1AyX1NNQVJUMToKPj4+Pj4gKwkJ CWNhc2UgUk9DS0NISVBfVk9QMl9FU01BUlQxOgo+Pj4+PiArCQkJY2FzZSBST0NLQ0hJUF9WT1Ay X0NMVVNURVIxOgo+Pj4+PiArCQkJCWNvbnRpbnVlOwo+Pj4+PiArCQkJfQo+Pj4+IFRoaW5rIGFi b3V0IHRoaXMgLCB0aGVyZSBtYXliZSBvdGhlciB1cGNvbWluZyB2b3AyIGJhc2Ugc29jLCB0aGV5 IG1heSBvbmx5Cj4+Pj4gaGF2ZQo+Pj4+Cj4+Pj4gbWlycm9yIHdpbmRvdyBTbWFydDEgRXNtYXJ0 MSwgb3IgU21hcnQxLCBFc21hcnQxLCBFc21hcnQyLCBDbHVzdGVyMS4KPj4+Pgo+Pj4+IEkgdGhp bmsgdGhpcyBzaG91bGQgYWRkIFdJTl9GRUFUVVJFIGF0IHRoZSBwbGF0Zm9ybSBkZXNjcmlwdGlv biBmaWxlCj4+Pj4gcm9ja2NoaXBfdm9wMl9yZWcuYywgdGhlbgo+Pj4+Cj4+Pj4gY2hlY2sgdGhl IEZFQVRVUkUgdG8gZGVjaWRlIHdoZXRoZXIgdGhlIGRyaXZlciBzaG91bGQgZ2l2ZSB0aGlzIHdp bmRvdyBhCj4+Pj4gc3BlY2lhbCB0cmVhdG1lbnQuCj4+Pj4KPj4+PiB0aGlzIGNhbiBtYWtlIG9u ZSBjb2RlIHJ1biBmb3IgZGlmZmVyZW50IHNvYyB3aXRoIGRpZmZlcmVudCBwbGF0Zm9ybQo+Pj4+ IGRlc2NyaXB0aW9uLiBvciB3ZSBzaG91bGQgYWRkCj4+Pj4KPj4+PiB0aGUgc2FtZSBjb2RlIGxv Z2ljIGZvciBkaWZmZXJlbnQgc29jIGFnYWluIGFuZCBhZ2Fpbi4KPj4+IFlvdSBtZWFuIGxpa2Ug ZG9uZSBpbiB0aGUgZG93bnN0cmVhbSBLZXJuZWw/IEhlcmUgaW5kZWVkIHdlIGhhdmUgYQo+Pj4g V0lOX0ZFQVRVUkVfTUlSUk9SIGZsYWcgYWRkZWQgdG8gdGhlIHBsYXRmb3JtIGRlc2NyaXB0aW9u LiBUaGlzIGlzIHRoZW4KPj4+IGV2YWx1YXRlZCB3aXRoOgo+Pj4KPj4+IHN0YXRpYyBib29sIHZv cDJfaXNfbWlycm9yX3dpbihzdHJ1Y3Qgdm9wMl93aW4gKndpbikKPj4+IHsKPj4+ICAgICAgICAg ICByZXR1cm4gc29jX2lzX3JrMzU2NigpICYmICh3aW4tPmZlYXR1cmUgJiBXSU5fRkVBVFVSRV9N SVJST1IpOwo+Pj4gfQo+Pj4KPj4+IFNvIGEgZmxhZyBpcyBhZGRlZCBhbmQgYWZ0ZXJ3YXJkcyBp dHMgZXZhbHVhdGlvbiBpcyBTb0Mgc3BlY2lmaWMuIFRoYXQKPj4+IGRvZXNuJ3QgaGVscCBhdCBh bGwgYW5kIG9ubHkgb2JmdXNjYXRlcyB0aGluZ3MuCj4+Pgo+Pj4gQmVzaWRlcywgZXhwZXJpZW5j ZSBzaG93cyB0aGF0IHlvdSBjYW4ndCBwcmVkaWN0IGEgZ29vZCBhYnN0cmFjdGlvbiBmb3IKPj4g VGhpcyBpcyBub3QgYcKgIHByZWRpY3QswqAgdGhpcyBpcyBhbiBJUCBmZWF0dXJlLCBzbyBpdCB3 aWxsIGFwcGVhcmVkIG9uCj4+IHVwY29taW5nIFNPQy4KPj4KPj4gV2UgaGF2ZSByazM1ODggd2l0 aCA4IHdpbmRvd3MoNCBDbHVzdGVyICsgNCBFc21hcnQsIG5vIFNtYXJ0IHdpbmRvdyksIGFuZAo+ Pgo+PiBhbHNvIGhhdmUgYSBlbnRyeSBsZXZlbCBzb2Mgd2hpY2ggb25seSBoYXZlIDQgd2luZG93 cywgdGhleSBib3RoIGhhdmUgdGhpcwo+PiBmZWF0dXJlLgo+IFNhbWUgYXMgd2l0aCB0aGUgb3Ro ZXIgZGlzY3Vzc2lvbjogUGxlYXNlIGxldCdzIHNvbHZlIHRoaXMgb25jZSB3ZSBhcmUKPiB0aGVy ZS4KCgpJIGFtIG5vdCBzdXJlIGlmIHRoaXMgaXMgdGhlIHN1aXRhYmxlIHdheSBmb3IgdXBzdHJl YW0sIHRoaXMgc291bmQgbGlrZQoKanVzdCBzb2x2ZSB0aGUgaXNzdWUgYXBwZWFyZWQgYXQgdGhl IGZyb250IG9mIGV5ZXMgYW5kIG5vdCB0aGluayBhbnkKCnRoaW5nIGFib3V0IG1ha2UgdGhpcyBk cml2ZXIgZWFzeSB0byBzdXBwb3J0IG5ldyBoYXJkd2FyZSBpbiB0aGUgZnV0dXJlLgoKPiBGb3Ig bm93IG15IGFkZGl0aW9uIGlzIHRoZSBlYXNpZXN0IHdheSBvdXQuIE9uY2Ugb3RoZXIgU29DcyBz aGFsbCBiZQo+IHN1cHBvcnRlZCB3ZSBjYW4gcmUtZXZhbHVhdGUgdGhhdCBhbmQgZmluZCBiZXR0 ZXIgc3VpdGFibGUgd2F5cyBmb3IgU29DCj4gYWJzdHJhY3Rpb25zLiBUaGlzIG1heSByZXN1bHQg aW4ganVzdCB5b3VyIHN1Z2dlc3Rpb24gKGluIHdoaWNoIGNhc2UgeW91Cj4gY2FuIHNheSB0b2xk LXlvdS1zbykgb3IgY29tcGxldGVseSBkaWZmZXJlbnQuCj4KPiBTYXNjaGEKPgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFp bGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60364C433F5 for ; Wed, 6 Apr 2022 08:36:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A38CE10F22B; Wed, 6 Apr 2022 08:36:54 +0000 (UTC) Received: from mail-m17637.qiye.163.com (mail-m17637.qiye.163.com [59.111.176.37]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1A6C10F22B for ; Wed, 6 Apr 2022 08:36:52 +0000 (UTC) Received: from [192.168.60.102] (unknown [103.29.142.67]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id B89019801AA; Wed, 6 Apr 2022 16:36:48 +0800 (CST) Message-ID: Date: Wed, 6 Apr 2022 16:36:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> <20220405093700.GQ4012@pengutronix.de> <12a8c0ef-90ee-cf7e-50a0-e00add8af147@rock-chips.com> <20220406081333.GU4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220406081333.GU4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUNKGR5WTEwaTktMGE4ZHU IZVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PBw6Ejo*LD5MI0oxNz0yDwgZ PD0KFDNVSlVKTU9CSUhPSUpKS05MVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZSktIVUlCVUpPSVVNTFlXWQgBWUFNSUhMNwY+ X-HM-Tid: 0a7ffe04ef24d992kuwsb89019801aa X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Benjamin Gaignard , Piotr Oniszczuk , Sandy Huang , dri-devel@lists.freedesktop.org, Kever Yang , "open list:ARM/Rockchip SoC..." , Michael Riesch , kernel@pengutronix.de, Peter Geis , "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi: On 4/6/22 16:13, Sascha Hauer wrote: > On Wed, Apr 06, 2022 at 10:02:59AM +0800, Andy Yan wrote: >> Hi: >> >> On 4/5/22 17:37, Sascha Hauer wrote: >>> On Sat, Apr 02, 2022 at 09:37:17AM +0800, Andy Yan wrote: >>>> Hi Sacha: >>>> >>>> On 4/1/22 20:52, Sascha Hauer wrote: >>>>> -- >>>>> >From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001 >>>>> From: Sascha Hauer >>>>> Date: Fri, 1 Apr 2022 14:48:49 +0200 >>>>> Subject: [PATCH] fixup! drm: rockchip: Add VOP2 driver >>>>> >>>>> --- >>>>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 14 ++++++++++++++ >>>>> 1 file changed, 14 insertions(+) >>>>> >>>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>>>> index 7dba7b9b63dc6..1421bf2f133f1 100644 >>>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>>>> @@ -2287,6 +2287,20 @@ static int vop2_create_crtc(struct vop2 *vop2) >>>>> } >>>>> } >>>>> + if (vop2->data->soc_id == 3566) { >>>>> + /* >>>>> + * On RK3566 these windows don't have an independent >>>>> + * framebuffer. They share the framebuffer with smart0, >>>>> + * esmart0 and cluster0 respectively. >>>>> + */ >>>>> + switch (win->data->phys_id) { >>>>> + case ROCKCHIP_VOP2_SMART1: >>>>> + case ROCKCHIP_VOP2_ESMART1: >>>>> + case ROCKCHIP_VOP2_CLUSTER1: >>>>> + continue; >>>>> + } >>>> Think about this , there maybe other upcoming vop2 base soc, they may only >>>> have >>>> >>>> mirror window Smart1 Esmart1, or Smart1, Esmart1, Esmart2, Cluster1. >>>> >>>> I think this should add WIN_FEATURE at the platform description file >>>> rockchip_vop2_reg.c, then >>>> >>>> check the FEATURE to decide whether the driver should give this window a >>>> special treatment. >>>> >>>> this can make one code run for different soc with different platform >>>> description. or we should add >>>> >>>> the same code logic for different soc again and again. >>> You mean like done in the downstream Kernel? Here indeed we have a >>> WIN_FEATURE_MIRROR flag added to the platform description. This is then >>> evaluated with: >>> >>> static bool vop2_is_mirror_win(struct vop2_win *win) >>> { >>> return soc_is_rk3566() && (win->feature & WIN_FEATURE_MIRROR); >>> } >>> >>> So a flag is added and afterwards its evaluation is SoC specific. That >>> doesn't help at all and only obfuscates things. >>> >>> Besides, experience shows that you can't predict a good abstraction for >> This is not a  predict,  this is an IP feature, so it will appeared on >> upcoming SOC. >> >> We have rk3588 with 8 windows(4 Cluster + 4 Esmart, no Smart window), and >> >> also have a entry level soc which only have 4 windows, they both have this >> feature. > Same as with the other discussion: Please let's solve this once we are > there. I am not sure if this is the suitable way for upstream, this sound like just solve the issue appeared at the front of eyes and not think any thing about make this driver easy to support new hardware in the future. > For now my addition is the easiest way out. Once other SoCs shall be > supported we can re-evaluate that and find better suitable ways for SoC > abstractions. This may result in just your suggestion (in which case you > can say told-you-so) or completely different. > > Sascha > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15CBCC433F5 for ; Wed, 6 Apr 2022 08:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2x7lFwloh3FfvSsSBRF4iawowvjdjMKSZ6/xLLbvPlY=; b=JWtHWFuriKr3hA J5SUFZfnOsboUv1QmumGbKiwch7Jz712CNxrQi4cizTePTWLcUBh1jWAYXW/vjvSYSUIFs31Y6/bz R9UJ+e04E2JXR1GZ9mnhkGOoxYSYONzpP7vfQ4/nMyrgBf/Z7p4AdTxNKTDHKiTao2fw6lKcAFT95 UeKND0DdKcazb5uRaA5wYO8qRbPF0vgKHUZQKI5YLM5Qv1U8wzR5f9AgCtaw3+OYG9v3Bazc0gPFk dKLEPYSpcc2Ohopern8DEht7Cxs+SWrPCDkETuNpnkMHGbfiusssYAwcRNbbxF2iTXFwjy/tTySA/ g9+FkJIH5k8OjZ5cuUtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc19t-004kwM-42; Wed, 06 Apr 2022 08:36:57 +0000 Received: from mail-m17637.qiye.163.com ([59.111.176.37]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nc19p-004kuZ-Bk; Wed, 06 Apr 2022 08:36:55 +0000 Received: from [192.168.60.102] (unknown [103.29.142.67]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id B89019801AA; Wed, 6 Apr 2022 16:36:48 +0800 (CST) Message-ID: Date: Wed, 6 Apr 2022 16:36:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer Cc: Piotr Oniszczuk , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Kever Yang References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> <20220405093700.GQ4012@pengutronix.de> <12a8c0ef-90ee-cf7e-50a0-e00add8af147@rock-chips.com> <20220406081333.GU4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220406081333.GU4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUNKGR5WTEwaTktMGE4ZHU IZVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PBw6Ejo*LD5MI0oxNz0yDwgZ PD0KFDNVSlVKTU9CSUhPSUpKS05MVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZSktIVUlCVUpPSVVNTFlXWQgBWUFNSUhMNwY+ X-HM-Tid: 0a7ffe04ef24d992kuwsb89019801aa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_013653_641942_67DFE793 X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGk6CgpPbiA0LzYvMjIgMTY6MTMsIFNhc2NoYSBIYXVlciB3cm90ZToKPiBPbiBXZWQsIEFwciAw NiwgMjAyMiBhdCAxMDowMjo1OUFNICswODAwLCBBbmR5IFlhbiB3cm90ZToKPj4gSGk6Cj4+Cj4+ IE9uIDQvNS8yMiAxNzozNywgU2FzY2hhIEhhdWVyIHdyb3RlOgo+Pj4gT24gU2F0LCBBcHIgMDIs IDIwMjIgYXQgMDk6Mzc6MTdBTSArMDgwMCwgQW5keSBZYW4gd3JvdGU6Cj4+Pj4gSGkgU2FjaGE6 Cj4+Pj4KPj4+PiBPbiA0LzEvMjIgMjA6NTIsIFNhc2NoYSBIYXVlciB3cm90ZToKPj4+Pj4gLS0g Cj4+Pj4+ID5Gcm9tIGNiYzAzMDczNjIzYTcxODAyNDMzMzFhYzI0YzNhZmFmOWRlYzc1MjIgTW9u IFNlcCAxNyAwMDowMDowMCAyMDAxCj4+Pj4+IEZyb206IFNhc2NoYSBIYXVlcjxzLmhhdWVyQHBl bmd1dHJvbml4LmRlPgo+Pj4+PiBEYXRlOiBGcmksIDEgQXByIDIwMjIgMTQ6NDg6NDkgKzAyMDAK Pj4+Pj4gU3ViamVjdDogW1BBVENIXSBmaXh1cCEgZHJtOiByb2NrY2hpcDogQWRkIFZPUDIgZHJp dmVyCj4+Pj4+Cj4+Pj4+IC0tLQo+Pj4+PiAgICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3Jv Y2tjaGlwX2RybV92b3AyLmMgfCAxNCArKysrKysrKysrKysrKwo+Pj4+PiAgICAgMSBmaWxlIGNo YW5nZWQsIDE0IGluc2VydGlvbnMoKykKPj4+Pj4KPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wMi5jIGIvZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL3JvY2tjaGlwX2RybV92b3AyLmMKPj4+Pj4gaW5kZXggN2RiYTdiOWI2M2RjNi4uMTQy MWJmMmYxMzNmMSAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3Jv Y2tjaGlwX2RybV92b3AyLmMKPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3Jv Y2tjaGlwX2RybV92b3AyLmMKPj4+Pj4gQEAgLTIyODcsNiArMjI4NywyMCBAQCBzdGF0aWMgaW50 IHZvcDJfY3JlYXRlX2NydGMoc3RydWN0IHZvcDIgKnZvcDIpCj4+Pj4+ICAgICAJCQl9Cj4+Pj4+ ICAgICAJCX0KPj4+Pj4gKwkJaWYgKHZvcDItPmRhdGEtPnNvY19pZCA9PSAzNTY2KSB7Cj4+Pj4+ ICsJCQkvKgo+Pj4+PiArCQkJICogT24gUkszNTY2IHRoZXNlIHdpbmRvd3MgZG9uJ3QgaGF2ZSBh biBpbmRlcGVuZGVudAo+Pj4+PiArCQkJICogZnJhbWVidWZmZXIuIFRoZXkgc2hhcmUgdGhlIGZy YW1lYnVmZmVyIHdpdGggc21hcnQwLAo+Pj4+PiArCQkJICogZXNtYXJ0MCBhbmQgY2x1c3RlcjAg cmVzcGVjdGl2ZWx5Lgo+Pj4+PiArCQkJICovCj4+Pj4+ICsJCQlzd2l0Y2ggKHdpbi0+ZGF0YS0+ cGh5c19pZCkgewo+Pj4+PiArCQkJY2FzZSBST0NLQ0hJUF9WT1AyX1NNQVJUMToKPj4+Pj4gKwkJ CWNhc2UgUk9DS0NISVBfVk9QMl9FU01BUlQxOgo+Pj4+PiArCQkJY2FzZSBST0NLQ0hJUF9WT1Ay X0NMVVNURVIxOgo+Pj4+PiArCQkJCWNvbnRpbnVlOwo+Pj4+PiArCQkJfQo+Pj4+IFRoaW5rIGFi b3V0IHRoaXMgLCB0aGVyZSBtYXliZSBvdGhlciB1cGNvbWluZyB2b3AyIGJhc2Ugc29jLCB0aGV5 IG1heSBvbmx5Cj4+Pj4gaGF2ZQo+Pj4+Cj4+Pj4gbWlycm9yIHdpbmRvdyBTbWFydDEgRXNtYXJ0 MSwgb3IgU21hcnQxLCBFc21hcnQxLCBFc21hcnQyLCBDbHVzdGVyMS4KPj4+Pgo+Pj4+IEkgdGhp bmsgdGhpcyBzaG91bGQgYWRkIFdJTl9GRUFUVVJFIGF0IHRoZSBwbGF0Zm9ybSBkZXNjcmlwdGlv biBmaWxlCj4+Pj4gcm9ja2NoaXBfdm9wMl9yZWcuYywgdGhlbgo+Pj4+Cj4+Pj4gY2hlY2sgdGhl IEZFQVRVUkUgdG8gZGVjaWRlIHdoZXRoZXIgdGhlIGRyaXZlciBzaG91bGQgZ2l2ZSB0aGlzIHdp bmRvdyBhCj4+Pj4gc3BlY2lhbCB0cmVhdG1lbnQuCj4+Pj4KPj4+PiB0aGlzIGNhbiBtYWtlIG9u ZSBjb2RlIHJ1biBmb3IgZGlmZmVyZW50IHNvYyB3aXRoIGRpZmZlcmVudCBwbGF0Zm9ybQo+Pj4+ IGRlc2NyaXB0aW9uLiBvciB3ZSBzaG91bGQgYWRkCj4+Pj4KPj4+PiB0aGUgc2FtZSBjb2RlIGxv Z2ljIGZvciBkaWZmZXJlbnQgc29jIGFnYWluIGFuZCBhZ2Fpbi4KPj4+IFlvdSBtZWFuIGxpa2Ug ZG9uZSBpbiB0aGUgZG93bnN0cmVhbSBLZXJuZWw/IEhlcmUgaW5kZWVkIHdlIGhhdmUgYQo+Pj4g V0lOX0ZFQVRVUkVfTUlSUk9SIGZsYWcgYWRkZWQgdG8gdGhlIHBsYXRmb3JtIGRlc2NyaXB0aW9u LiBUaGlzIGlzIHRoZW4KPj4+IGV2YWx1YXRlZCB3aXRoOgo+Pj4KPj4+IHN0YXRpYyBib29sIHZv cDJfaXNfbWlycm9yX3dpbihzdHJ1Y3Qgdm9wMl93aW4gKndpbikKPj4+IHsKPj4+ICAgICAgICAg ICByZXR1cm4gc29jX2lzX3JrMzU2NigpICYmICh3aW4tPmZlYXR1cmUgJiBXSU5fRkVBVFVSRV9N SVJST1IpOwo+Pj4gfQo+Pj4KPj4+IFNvIGEgZmxhZyBpcyBhZGRlZCBhbmQgYWZ0ZXJ3YXJkcyBp dHMgZXZhbHVhdGlvbiBpcyBTb0Mgc3BlY2lmaWMuIFRoYXQKPj4+IGRvZXNuJ3QgaGVscCBhdCBh bGwgYW5kIG9ubHkgb2JmdXNjYXRlcyB0aGluZ3MuCj4+Pgo+Pj4gQmVzaWRlcywgZXhwZXJpZW5j ZSBzaG93cyB0aGF0IHlvdSBjYW4ndCBwcmVkaWN0IGEgZ29vZCBhYnN0cmFjdGlvbiBmb3IKPj4g VGhpcyBpcyBub3QgYcKgIHByZWRpY3QswqAgdGhpcyBpcyBhbiBJUCBmZWF0dXJlLCBzbyBpdCB3 aWxsIGFwcGVhcmVkIG9uCj4+IHVwY29taW5nIFNPQy4KPj4KPj4gV2UgaGF2ZSByazM1ODggd2l0 aCA4IHdpbmRvd3MoNCBDbHVzdGVyICsgNCBFc21hcnQsIG5vIFNtYXJ0IHdpbmRvdyksIGFuZAo+ Pgo+PiBhbHNvIGhhdmUgYSBlbnRyeSBsZXZlbCBzb2Mgd2hpY2ggb25seSBoYXZlIDQgd2luZG93 cywgdGhleSBib3RoIGhhdmUgdGhpcwo+PiBmZWF0dXJlLgo+IFNhbWUgYXMgd2l0aCB0aGUgb3Ro ZXIgZGlzY3Vzc2lvbjogUGxlYXNlIGxldCdzIHNvbHZlIHRoaXMgb25jZSB3ZSBhcmUKPiB0aGVy ZS4KCgpJIGFtIG5vdCBzdXJlIGlmIHRoaXMgaXMgdGhlIHN1aXRhYmxlIHdheSBmb3IgdXBzdHJl YW0sIHRoaXMgc291bmQgbGlrZQoKanVzdCBzb2x2ZSB0aGUgaXNzdWUgYXBwZWFyZWQgYXQgdGhl IGZyb250IG9mIGV5ZXMgYW5kIG5vdCB0aGluayBhbnkKCnRoaW5nIGFib3V0IG1ha2UgdGhpcyBk cml2ZXIgZWFzeSB0byBzdXBwb3J0IG5ldyBoYXJkd2FyZSBpbiB0aGUgZnV0dXJlLgoKPiBGb3Ig bm93IG15IGFkZGl0aW9uIGlzIHRoZSBlYXNpZXN0IHdheSBvdXQuIE9uY2Ugb3RoZXIgU29DcyBz aGFsbCBiZQo+IHN1cHBvcnRlZCB3ZSBjYW4gcmUtZXZhbHVhdGUgdGhhdCBhbmQgZmluZCBiZXR0 ZXIgc3VpdGFibGUgd2F5cyBmb3IgU29DCj4gYWJzdHJhY3Rpb25zLiBUaGlzIG1heSByZXN1bHQg aW4ganVzdCB5b3VyIHN1Z2dlc3Rpb24gKGluIHdoaWNoIGNhc2UgeW91Cj4gY2FuIHNheSB0b2xk LXlvdS1zbykgb3IgY29tcGxldGVseSBkaWZmZXJlbnQuCj4KPiBTYXNjaGEKPgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0324FC433EF for ; Wed, 6 Apr 2022 12:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230514AbiDFMgu (ORCPT ); Wed, 6 Apr 2022 08:36:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232065AbiDFMey (ORCPT ); Wed, 6 Apr 2022 08:34:54 -0400 Received: from mail-m17637.qiye.163.com (mail-m17637.qiye.163.com [59.111.176.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE310CB02F for ; Wed, 6 Apr 2022 01:36:52 -0700 (PDT) Received: from [192.168.60.102] (unknown [103.29.142.67]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id B89019801AA; Wed, 6 Apr 2022 16:36:48 +0800 (CST) Message-ID: Date: Wed, 6 Apr 2022 16:36:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer Cc: Piotr Oniszczuk , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Kever Yang References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> <20220405093700.GQ4012@pengutronix.de> <12a8c0ef-90ee-cf7e-50a0-e00add8af147@rock-chips.com> <20220406081333.GU4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220406081333.GU4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUNKGR5WTEwaTktMGE4ZHU IZVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PBw6Ejo*LD5MI0oxNz0yDwgZ PD0KFDNVSlVKTU9CSUhPSUpKS05MVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZSktIVUlCVUpPSVVNTFlXWQgBWUFNSUhMNwY+ X-HM-Tid: 0a7ffe04ef24d992kuwsb89019801aa Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi: On 4/6/22 16:13, Sascha Hauer wrote: > On Wed, Apr 06, 2022 at 10:02:59AM +0800, Andy Yan wrote: >> Hi: >> >> On 4/5/22 17:37, Sascha Hauer wrote: >>> On Sat, Apr 02, 2022 at 09:37:17AM +0800, Andy Yan wrote: >>>> Hi Sacha: >>>> >>>> On 4/1/22 20:52, Sascha Hauer wrote: >>>>> -- >>>>> >From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001 >>>>> From: Sascha Hauer >>>>> Date: Fri, 1 Apr 2022 14:48:49 +0200 >>>>> Subject: [PATCH] fixup! drm: rockchip: Add VOP2 driver >>>>> >>>>> --- >>>>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 14 ++++++++++++++ >>>>> 1 file changed, 14 insertions(+) >>>>> >>>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>>>> index 7dba7b9b63dc6..1421bf2f133f1 100644 >>>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>>>> @@ -2287,6 +2287,20 @@ static int vop2_create_crtc(struct vop2 *vop2) >>>>> } >>>>> } >>>>> + if (vop2->data->soc_id == 3566) { >>>>> + /* >>>>> + * On RK3566 these windows don't have an independent >>>>> + * framebuffer. They share the framebuffer with smart0, >>>>> + * esmart0 and cluster0 respectively. >>>>> + */ >>>>> + switch (win->data->phys_id) { >>>>> + case ROCKCHIP_VOP2_SMART1: >>>>> + case ROCKCHIP_VOP2_ESMART1: >>>>> + case ROCKCHIP_VOP2_CLUSTER1: >>>>> + continue; >>>>> + } >>>> Think about this , there maybe other upcoming vop2 base soc, they may only >>>> have >>>> >>>> mirror window Smart1 Esmart1, or Smart1, Esmart1, Esmart2, Cluster1. >>>> >>>> I think this should add WIN_FEATURE at the platform description file >>>> rockchip_vop2_reg.c, then >>>> >>>> check the FEATURE to decide whether the driver should give this window a >>>> special treatment. >>>> >>>> this can make one code run for different soc with different platform >>>> description. or we should add >>>> >>>> the same code logic for different soc again and again. >>> You mean like done in the downstream Kernel? Here indeed we have a >>> WIN_FEATURE_MIRROR flag added to the platform description. This is then >>> evaluated with: >>> >>> static bool vop2_is_mirror_win(struct vop2_win *win) >>> { >>> return soc_is_rk3566() && (win->feature & WIN_FEATURE_MIRROR); >>> } >>> >>> So a flag is added and afterwards its evaluation is SoC specific. That >>> doesn't help at all and only obfuscates things. >>> >>> Besides, experience shows that you can't predict a good abstraction for >> This is not a  predict,  this is an IP feature, so it will appeared on >> upcoming SOC. >> >> We have rk3588 with 8 windows(4 Cluster + 4 Esmart, no Smart window), and >> >> also have a entry level soc which only have 4 windows, they both have this >> feature. > Same as with the other discussion: Please let's solve this once we are > there. I am not sure if this is the suitable way for upstream, this sound like just solve the issue appeared at the front of eyes and not think any thing about make this driver easy to support new hardware in the future. > For now my addition is the easiest way out. Once other SoCs shall be > supported we can re-evaluate that and find better suitable ways for SoC > abstractions. This may result in just your suggestion (in which case you > can say told-you-so) or completely different. > > Sascha >