From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D63BDC433DB for ; Sun, 27 Dec 2020 17:23:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0FF32255F for ; Sun, 27 Dec 2020 17:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726371AbgL0RXr (ORCPT ); Sun, 27 Dec 2020 12:23:47 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:49618 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbgL0RXq (ORCPT ); Sun, 27 Dec 2020 12:23:46 -0500 Received: from [192.168.42.210] ([93.22.148.120]) by mwinf5d09 with ME id 9VMz2400G2c5cNt03VN0zk; Sun, 27 Dec 2020 18:22:02 +0100 X-ME-Helo: [192.168.42.210] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 27 Dec 2020 18:22:02 +0100 X-ME-IP: 93.22.148.120 Subject: Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: Fix some resource leaks in the error handling path of the probe function To: Viresh Kumar Cc: mmayer@broadcom.com, bcm-kernel-feedback-list@broadcom.com, rjw@rjwysocki.net, f.fainelli@gmail.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20201219101751.181783-1-christophe.jaillet@wanadoo.fr> <20201222043505.rq3cmajc3mxv3p2z@vireshk-i7> From: Christophe JAILLET Message-ID: Date: Sun, 27 Dec 2020 18:22:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201222043505.rq3cmajc3mxv3p2z@vireshk-i7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 22/12/2020 à 05:35, Viresh Kumar a écrit : > On 19-12-20, 11:17, Christophe JAILLET wrote: >> If 'cpufreq_register_driver()' fails, we must release the resources >> allocated in 'brcm_avs_prepare_init()' as already done in the remove >> function. >> >> To do that, introduce a new function 'brcm_avs_prepare_uninit()' in order >> to avoid code duplication. This also makes the code more readable (IMHO). >> >> Fixes: de322e085995 ("cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs") >> Signed-off-by: Christophe JAILLET >> --- >> I'm not sure that the existing error handling in the remove function is >> correct and/or needed. >> --- >> drivers/cpufreq/brcmstb-avs-cpufreq.c | 25 ++++++++++++++++++++----- >> 1 file changed, 20 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c >> index 3e31e5d28b79..750ca7cfccb0 100644 >> --- a/drivers/cpufreq/brcmstb-avs-cpufreq.c >> +++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c >> @@ -597,6 +597,16 @@ static int brcm_avs_prepare_init(struct platform_device *pdev) >> return ret; >> } >> >> +static void brcm_avs_prepare_uninit(struct platform_device *pdev) >> +{ >> + struct private_data *priv; >> + >> + priv = platform_get_drvdata(pdev); >> + >> + iounmap(priv->avs_intr_base); >> + iounmap(priv->base); >> +} >> + >> static int brcm_avs_cpufreq_init(struct cpufreq_policy *policy) >> { >> struct cpufreq_frequency_table *freq_table; >> @@ -732,21 +742,26 @@ static int brcm_avs_cpufreq_probe(struct platform_device *pdev) >> >> brcm_avs_driver.driver_data = pdev; >> >> - return cpufreq_register_driver(&brcm_avs_driver); >> + ret = cpufreq_register_driver(&brcm_avs_driver); >> + if (ret) >> + goto err_uninit; >> + >> + return 0; >> + >> +err_uninit: >> + brcm_avs_prepare_uninit(pdev); >> + return ret; > > Maybe rewrite as: > > ret = cpufreq_register_driver(&brcm_avs_driver); > if (ret) > brcm_avs_prepare_uninit(pdev); > return ret; > Personlaly, I prefer what I have proposed. Having a clear and dedicated error handling path is more future proff, IMHO. >> } >> >> static int brcm_avs_cpufreq_remove(struct platform_device *pdev) >> { >> - struct private_data *priv; >> int ret; >> >> ret = cpufreq_unregister_driver(&brcm_avs_driver); >> if (ret) >> return ret; > > Instead of returning here, it can be just WARN_ON(ret); and then go on and free > the resources and this needs to be done in a separate patch. Ok, I agree (see my comment below the --- in my patch). I'll send a patch for it when the first patch will be applied, unless you prefer if I resend as a serie. CJ > >> >> - priv = platform_get_drvdata(pdev); >> - iounmap(priv->base); >> - iounmap(priv->avs_intr_base); >> + brcm_avs_prepare_uninit(pdev); >> >> return 0; >> } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe JAILLET Date: Sun, 27 Dec 2020 17:22:00 +0000 Subject: Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: Fix some resource leaks in the error handling path of the Message-Id: List-Id: References: <20201219101751.181783-1-christophe.jaillet@wanadoo.fr> <20201222043505.rq3cmajc3mxv3p2z@vireshk-i7> In-Reply-To: <20201222043505.rq3cmajc3mxv3p2z@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Viresh Kumar Cc: f.fainelli@gmail.com, linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, mmayer@broadcom.com, linux-arm-kernel@lists.infradead.org Le 22/12/2020 à 05:35, Viresh Kumar a écrit : > On 19-12-20, 11:17, Christophe JAILLET wrote: >> If 'cpufreq_register_driver()' fails, we must release the resources >> allocated in 'brcm_avs_prepare_init()' as already done in the remove >> function. >> >> To do that, introduce a new function 'brcm_avs_prepare_uninit()' in order >> to avoid code duplication. This also makes the code more readable (IMHO). >> >> Fixes: de322e085995 ("cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs") >> Signed-off-by: Christophe JAILLET >> --- >> I'm not sure that the existing error handling in the remove function is >> correct and/or needed. >> --- >> drivers/cpufreq/brcmstb-avs-cpufreq.c | 25 ++++++++++++++++++++----- >> 1 file changed, 20 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c >> index 3e31e5d28b79..750ca7cfccb0 100644 >> --- a/drivers/cpufreq/brcmstb-avs-cpufreq.c >> +++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c >> @@ -597,6 +597,16 @@ static int brcm_avs_prepare_init(struct platform_device *pdev) >> return ret; >> } >> >> +static void brcm_avs_prepare_uninit(struct platform_device *pdev) >> +{ >> + struct private_data *priv; >> + >> + priv = platform_get_drvdata(pdev); >> + >> + iounmap(priv->avs_intr_base); >> + iounmap(priv->base); >> +} >> + >> static int brcm_avs_cpufreq_init(struct cpufreq_policy *policy) >> { >> struct cpufreq_frequency_table *freq_table; >> @@ -732,21 +742,26 @@ static int brcm_avs_cpufreq_probe(struct platform_device *pdev) >> >> brcm_avs_driver.driver_data = pdev; >> >> - return cpufreq_register_driver(&brcm_avs_driver); >> + ret = cpufreq_register_driver(&brcm_avs_driver); >> + if (ret) >> + goto err_uninit; >> + >> + return 0; >> + >> +err_uninit: >> + brcm_avs_prepare_uninit(pdev); >> + return ret; > > Maybe rewrite as: > > ret = cpufreq_register_driver(&brcm_avs_driver); > if (ret) > brcm_avs_prepare_uninit(pdev); > return ret; > Personlaly, I prefer what I have proposed. Having a clear and dedicated error handling path is more future proff, IMHO. >> } >> >> static int brcm_avs_cpufreq_remove(struct platform_device *pdev) >> { >> - struct private_data *priv; >> int ret; >> >> ret = cpufreq_unregister_driver(&brcm_avs_driver); >> if (ret) >> return ret; > > Instead of returning here, it can be just WARN_ON(ret); and then go on and free > the resources and this needs to be done in a separate patch. Ok, I agree (see my comment below the --- in my patch). I'll send a patch for it when the first patch will be applied, unless you prefer if I resend as a serie. CJ > >> >> - priv = platform_get_drvdata(pdev); >> - iounmap(priv->base); >> - iounmap(priv->avs_intr_base); >> + brcm_avs_prepare_uninit(pdev); >> >> return 0; >> } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DB2C43381 for ; Sun, 27 Dec 2020 17:23:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AAD022507 for ; Sun, 27 Dec 2020 17:23:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AAD022507 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wanadoo.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fW9wEo1Op/S41i7frAeH1oxlKoiA0Uv/W/JmTWt2woI=; b=prwbU7TqyxFPUnRQf4EUEgL0g usos2DQX0mLkZuiyKzNq6GjL5M00qfcdaD+TMASsXCfCgEhSFgUebodQi9hYwmsLExazfTk0C2fiE c0EOCwRzeqfUNZsjRcph2uD2NSkKeiq5hJVMQ9p/tcXGWkqqay2Jj9gb+dFc015cpWygxo7GpQZX0 nNGJCsYsHZ1FGQzrACzQsYySYZt9d+qA+LYAIOEJCw2BBmaqh5fYirT33+byYKBMHfrPIjTapjf2Z QKeweywbqov+AmfbrUmd8Tw7axHUVKtk8OeRU2JJbhRXVaGcMsksz8hyla8v9frXTT1IyfexaLe34 6UqPGVTmA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktZkB-00013q-2m; Sun, 27 Dec 2020 17:22:11 +0000 Received: from smtp05.smtpout.orange.fr ([80.12.242.127] helo=smtp.smtpout.orange.fr) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ktZk8-00013N-DX for linux-arm-kernel@lists.infradead.org; Sun, 27 Dec 2020 17:22:09 +0000 Received: from [192.168.42.210] ([93.22.148.120]) by mwinf5d09 with ME id 9VMz2400G2c5cNt03VN0zk; Sun, 27 Dec 2020 18:22:02 +0100 X-ME-Helo: [192.168.42.210] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 27 Dec 2020 18:22:02 +0100 X-ME-IP: 93.22.148.120 Subject: Re: [PATCH] cpufreq: brcmstb-avs-cpufreq: Fix some resource leaks in the error handling path of the probe function To: Viresh Kumar References: <20201219101751.181783-1-christophe.jaillet@wanadoo.fr> <20201222043505.rq3cmajc3mxv3p2z@vireshk-i7> From: Christophe JAILLET Message-ID: Date: Sun, 27 Dec 2020 18:22:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201222043505.rq3cmajc3mxv3p2z@vireshk-i7> Content-Language: fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201227_122208_667390_945E2DA5 X-CRM114-Status: GOOD ( 26.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, mmayer@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgMjIvMTIvMjAyMCDDoCAwNTozNSwgVmlyZXNoIEt1bWFyIGEgw6ljcml0wqA6Cj4gT24gMTkt MTItMjAsIDExOjE3LCBDaHJpc3RvcGhlIEpBSUxMRVQgd3JvdGU6Cj4+IElmICdjcHVmcmVxX3Jl Z2lzdGVyX2RyaXZlcigpJyBmYWlscywgd2UgbXVzdCByZWxlYXNlIHRoZSByZXNvdXJjZXMKPj4g YWxsb2NhdGVkIGluICdicmNtX2F2c19wcmVwYXJlX2luaXQoKScgYXMgYWxyZWFkeSBkb25lIGlu IHRoZSByZW1vdmUKPj4gZnVuY3Rpb24uCj4+Cj4+IFRvIGRvIHRoYXQsIGludHJvZHVjZSBhIG5l dyBmdW5jdGlvbiAnYnJjbV9hdnNfcHJlcGFyZV91bmluaXQoKScgaW4gb3JkZXIKPj4gdG8gYXZv aWQgY29kZSBkdXBsaWNhdGlvbi4gVGhpcyBhbHNvIG1ha2VzIHRoZSBjb2RlIG1vcmUgcmVhZGFi bGUgKElNSE8pLgo+Pgo+PiBGaXhlczogZGUzMjJlMDg1OTk1ICgiY3B1ZnJlcTogYnJjbXN0Yi1h dnMtY3B1ZnJlcTogQVZTIENQVWZyZXEgZHJpdmVyIGZvciBCcm9hZGNvbSBTVEIgU29DcyIpCj4+ IFNpZ25lZC1vZmYtYnk6IENocmlzdG9waGUgSkFJTExFVCA8Y2hyaXN0b3BoZS5qYWlsbGV0QHdh bmFkb28uZnI+Cj4+IC0tLQo+PiBJJ20gbm90IHN1cmUgdGhhdCB0aGUgZXhpc3RpbmcgZXJyb3Ig aGFuZGxpbmcgaW4gdGhlIHJlbW92ZSBmdW5jdGlvbiBpcwo+PiBjb3JyZWN0IGFuZC9vciBuZWVk ZWQuCj4+IC0tLQo+PiAgIGRyaXZlcnMvY3B1ZnJlcS9icmNtc3RiLWF2cy1jcHVmcmVxLmMgfCAy NSArKysrKysrKysrKysrKysrKysrKy0tLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIwIGluc2Vy dGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2NwdWZy ZXEvYnJjbXN0Yi1hdnMtY3B1ZnJlcS5jIGIvZHJpdmVycy9jcHVmcmVxL2JyY21zdGItYXZzLWNw dWZyZXEuYwo+PiBpbmRleCAzZTMxZTVkMjhiNzkuLjc1MGNhN2NmY2NiMCAxMDA2NDQKPj4gLS0t IGEvZHJpdmVycy9jcHVmcmVxL2JyY21zdGItYXZzLWNwdWZyZXEuYwo+PiArKysgYi9kcml2ZXJz L2NwdWZyZXEvYnJjbXN0Yi1hdnMtY3B1ZnJlcS5jCj4+IEBAIC01OTcsNiArNTk3LDE2IEBAIHN0 YXRpYyBpbnQgYnJjbV9hdnNfcHJlcGFyZV9pbml0KHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4+ICAgCXJldHVybiByZXQ7Cj4+ICAgfQo+PiAgIAo+PiArc3RhdGljIHZvaWQgYnJjbV9h dnNfcHJlcGFyZV91bmluaXQoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4gK3sKPj4g KwlzdHJ1Y3QgcHJpdmF0ZV9kYXRhICpwcml2Owo+PiArCj4+ICsJcHJpdiA9IHBsYXRmb3JtX2dl dF9kcnZkYXRhKHBkZXYpOwo+PiArCj4+ICsJaW91bm1hcChwcml2LT5hdnNfaW50cl9iYXNlKTsK Pj4gKwlpb3VubWFwKHByaXYtPmJhc2UpOwo+PiArfQo+PiArCj4+ICAgc3RhdGljIGludCBicmNt X2F2c19jcHVmcmVxX2luaXQoc3RydWN0IGNwdWZyZXFfcG9saWN5ICpwb2xpY3kpCj4+ICAgewo+ PiAgIAlzdHJ1Y3QgY3B1ZnJlcV9mcmVxdWVuY3lfdGFibGUgKmZyZXFfdGFibGU7Cj4+IEBAIC03 MzIsMjEgKzc0MiwyNiBAQCBzdGF0aWMgaW50IGJyY21fYXZzX2NwdWZyZXFfcHJvYmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKPj4gICAKPj4gICAJYnJjbV9hdnNfZHJpdmVyLmRyaXZl cl9kYXRhID0gcGRldjsKPj4gICAKPj4gLQlyZXR1cm4gY3B1ZnJlcV9yZWdpc3Rlcl9kcml2ZXIo JmJyY21fYXZzX2RyaXZlcik7Cj4+ICsJcmV0ID0gY3B1ZnJlcV9yZWdpc3Rlcl9kcml2ZXIoJmJy Y21fYXZzX2RyaXZlcik7Cj4+ICsJaWYgKHJldCkKPj4gKwkJZ290byBlcnJfdW5pbml0Owo+PiAr Cj4+ICsJcmV0dXJuIDA7Cj4+ICsKPj4gK2Vycl91bmluaXQ6Cj4+ICsJYnJjbV9hdnNfcHJlcGFy ZV91bmluaXQocGRldik7Cj4+ICsJcmV0dXJuIHJldDsKPiAKPiBNYXliZSByZXdyaXRlIGFzOgo+ IAo+IAlyZXQgPSBjcHVmcmVxX3JlZ2lzdGVyX2RyaXZlcigmYnJjbV9hdnNfZHJpdmVyKTsKPiAJ aWYgKHJldCkKPiAgICAgICAgICAgICAgICAgIGJyY21fYXZzX3ByZXBhcmVfdW5pbml0KHBkZXYp Owo+IAlyZXR1cm4gcmV0Owo+IAoKUGVyc29ubGFseSwgSSBwcmVmZXIgd2hhdCBJIGhhdmUgcHJv cG9zZWQuIEhhdmluZyBhIGNsZWFyIGFuZCBkZWRpY2F0ZWQgCmVycm9yIGhhbmRsaW5nIHBhdGgg aXMgbW9yZSBmdXR1cmUgcHJvZmYsIElNSE8uCgo+PiAgIH0KPj4gICAKPj4gICBzdGF0aWMgaW50 IGJyY21fYXZzX2NwdWZyZXFfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+ ICAgewo+PiAtCXN0cnVjdCBwcml2YXRlX2RhdGEgKnByaXY7Cj4+ICAgCWludCByZXQ7Cj4+ICAg Cj4+ICAgCXJldCA9IGNwdWZyZXFfdW5yZWdpc3Rlcl9kcml2ZXIoJmJyY21fYXZzX2RyaXZlcik7 Cj4+ICAgCWlmIChyZXQpCj4+ICAgCQlyZXR1cm4gcmV0Owo+IAo+IEluc3RlYWQgb2YgcmV0dXJu aW5nIGhlcmUsIGl0IGNhbiBiZSBqdXN0IFdBUk5fT04ocmV0KTsgYW5kIHRoZW4gZ28gb24gYW5k IGZyZWUKPiB0aGUgcmVzb3VyY2VzIGFuZCB0aGlzIG5lZWRzIHRvIGJlIGRvbmUgaW4gYSBzZXBh cmF0ZSBwYXRjaC4KCk9rLCBJIGFncmVlIChzZWUgbXkgY29tbWVudCBiZWxvdyB0aGUgLS0tIGlu IG15IHBhdGNoKS4KSSdsbCBzZW5kIGEgcGF0Y2ggZm9yIGl0IHdoZW4gdGhlIGZpcnN0IHBhdGNo IHdpbGwgYmUgYXBwbGllZCwgdW5sZXNzIAp5b3UgcHJlZmVyIGlmIEkgcmVzZW5kIGFzIGEgc2Vy aWUuCgpDSgoKPiAKPj4gICAKPj4gLQlwcml2ID0gcGxhdGZvcm1fZ2V0X2RydmRhdGEocGRldik7 Cj4+IC0JaW91bm1hcChwcml2LT5iYXNlKTsKPj4gLQlpb3VubWFwKHByaXYtPmF2c19pbnRyX2Jh c2UpOwo+PiArCWJyY21fYXZzX3ByZXBhcmVfdW5pbml0KHBkZXYpOwo+PiAgIAo+PiAgIAlyZXR1 cm4gMDsKPj4gICB9Cj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=