All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Eugen.Hristev@microchip.com, linux-watchdog@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.or
Cc: wim@linux-watchdog.org, robh+dt@kernel.org,
	Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com
Subject: Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver
Date: Mon, 7 Oct 2019 05:36:38 -0700	[thread overview]
Message-ID: <a9adf20c-f730-a7e9-a826-59216c17f03d@roeck-us.net> (raw)
In-Reply-To: <ab7b6b45-5e6f-100d-51af-a82ac325d948@microchip.com>

On 10/7/19 12:58 AM, Eugen.Hristev@microchip.com wrote:
[ ... ]
> Hello Guenter,
> 
> Thank you for the feedback.
> After reviewing this, can you please guide me towards one of the
> possible two directions: merge this driver with sama5d4_wdt , and have a
> single driver with support for both hardware blocks; or, have this
> driver separately , as in this patch series?
> 

I noticed the similarities. I don't know if it makes sense to reconcile
the two drivers; it seems to me the new chip uses the same basic core with
enhancements. In general, I prefer a single driver, but only if the result
doesn't end up being an if/else mess. Ultimately, it is really your call
to make.

Guenter

  reply	other threads:[~2019-10-07 12:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02  7:35 [PATCH 1/3] dt-bindings: watchdog: sam9x60_wdt: add bindings Eugen.Hristev
2019-10-02  7:35 ` Eugen.Hristev
2019-10-02  7:35 ` [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver Eugen.Hristev
2019-10-02  7:35   ` Eugen.Hristev
2019-10-02 10:23   ` Alexandre Belloni
2019-10-02 10:23     ` Alexandre Belloni
2019-10-02 11:07     ` Eugen.Hristev
2019-10-02 11:07       ` Eugen.Hristev
2019-10-02 11:07       ` Eugen.Hristev
2019-10-02 13:16   ` Guenter Roeck
2019-10-07  7:58     ` Eugen.Hristev
2019-10-07  7:58       ` Eugen.Hristev
2019-10-07 12:36       ` Guenter Roeck [this message]
2019-10-07 13:14         ` Alexandre Belloni
2019-10-07 13:14           ` Alexandre Belloni
2019-10-07 14:17           ` Eugen.Hristev
2019-10-07 14:17             ` Eugen.Hristev
2019-10-07 14:17             ` Eugen.Hristev
2019-10-02 13:38   ` kbuild test robot
2019-10-02 13:38     ` kbuild test robot
2019-10-02 13:38     ` kbuild test robot
2019-10-02  7:35 ` [PATCH 3/3] MAINTAINERS: add sam9x60_wdt Eugen.Hristev
2019-10-02  7:35   ` Eugen.Hristev
2019-10-02  9:56 ` [PATCH 1/3] dt-bindings: watchdog: sam9x60_wdt: add bindings Alexandre Belloni
2019-10-02  9:56   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9adf20c-f730-a7e9-a826-59216c17f03d@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.or \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.