From: Akash Asthana <akashast@codeaurora.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
mka@chromium.org, dianders@chromium.org,
linux-kernel@vger.kernel.org, saravanak@google.com
Subject: Re: [PATCH 3/3] Serial: Separate out earlycon support
Date: Mon, 7 Dec 2020 17:52:32 +0530 [thread overview]
Message-ID: <ab693e13-0478-5301-5ccb-9d8b1191afa1@codeaurora.org> (raw)
In-Reply-To: <X83x0BZmGYtQSMUU@kroah.com>
Hi Greg,
On 12/7/2020 2:41 PM, Greg KH wrote:
> On Mon, Dec 07, 2020 at 02:17:27PM +0530, Akash Asthana wrote:
>> Separate out earlycon support from serial driver and remove it's
>> dependency on QUP wrapper driver.
>>
>> This enable us to manage earlycon independently and we can re-use the
>> same earlycon driver for android project which currently uses
>> downstream version of QUP drivers.
> What do you mean by "downstream" here?
>
>> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
>> ---
>> drivers/tty/serial/Kconfig | 9 +
>> drivers/tty/serial/Makefile | 1 +
>> drivers/tty/serial/qcom_geni_earlycon.c | 649 ++++++++++++++++++++++++++++++++
>> drivers/tty/serial/qcom_geni_serial.c | 97 -----
> So you are replacing 97 lines of code with 649 lines? How is this
> benefiting anyone?
>
> confused,
We have 2 versions of QUP driver, upstream version(Present in linus
tree, mostly used for chromium project) and downstream version(belong to
vendor part of code in GKI design, used for all the other project).
There is need to enable geni earlycon in Google provided boot image for
GKI to facilitate the debug until real console(belong to vendor code) is up.
Currently it won't be possible because geni earlycon cannot be enabled
independently, it depends on upstream QUP wrapper driver
(soc/qcom/qcom-geni-se.c) and upstream serial
driver(serial/qcom_geni_serial.c).
With this patch I am trying to break any dependency btw earlycon hook
and QUP kernel drivers, so it can be managed independently.
Regards,
Akash
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-12-07 12:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 8:47 [PATCH 0/3] Separate out earlycon Akash Asthana
2020-12-07 8:47 ` [PATCH 1/3] soc: qcom-geni-se: Cleanup the code to remove proxy votes Akash Asthana
2020-12-07 8:47 ` [PATCH 2/3] arm64: dts: qcom: sc7180: Remove QUP-CORE ICC path Akash Asthana
2020-12-07 8:47 ` [PATCH 3/3] Serial: Separate out earlycon support Akash Asthana
2020-12-07 9:11 ` Greg KH
2020-12-07 12:22 ` Akash Asthana [this message]
2020-12-07 13:55 ` Greg KH
2020-12-07 9:43 ` Greg KH
2020-12-07 12:23 ` Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab693e13-0478-5301-5ccb-9d8b1191afa1@codeaurora.org \
--to=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mka@chromium.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.