From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FFC7C433F5 for ; Sun, 22 May 2022 13:59:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CD70383E36; Sun, 22 May 2022 15:59:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="R6hwxDuO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F02C683E36; Sun, 22 May 2022 15:59:26 +0200 (CEST) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0E38483F40 for ; Sun, 22 May 2022 15:59:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ed1-x530.google.com with SMTP id n23so16153425edy.0 for ; Sun, 22 May 2022 06:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=540EMyULCv15Lltv1b1DgQqW3FdZAe8V1vEB19aGb/E=; b=R6hwxDuObgyrd841qHQy91Tr7/D7MKcJDGqbbg7/F+BjAa2IMHr+J0oXXBkYVn3xTE jLWt4IYTzq3lYBkEChdJ1wy78BYC+eOUA+3vZtCoSmfngKeDTE4I+5+FrZua8+mQiSY/ 3cz2TuQWZu/vK5JpN07dqw4GCcKsxXx/KMrIInpZUj/s5CyM7qPBVmV16AvE93aLC7VT MJbDl8Y+q3xyOlzsq8zFXEdG+mCe5HzCJ/khU0D51An+pKfhdhE3g7+9EnSOxG/KcIIH xcwgGFTHBfNK+t6MxCgMgmJ9au7besRtrIgi1PM2k5KB35rodgvjGD9qXPjX+JYALnKJ Xflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=540EMyULCv15Lltv1b1DgQqW3FdZAe8V1vEB19aGb/E=; b=KISGMUXkxyWIUNsluAAwe8YExsYMcZWguXSKxgTfVTjDmaOYs1q0xCtGzN2bLHWpAE EsS7rTGzA9EmZ0b2jf6TdfaRaDzNnOu8wLeVXuR3k8X8rxTWygaugTTVoea9dR74ntFV wdVgEXNAvhnQfXTeR5XvgrL/mFPwznHHXvmwmkmE4J2HqWqTl2trFCWk5/1cQNBA2NBl 9TuW/kqP6RHCjdfbhiVBAVE6QfTVs16ZCx09E3ggehJ3ZGpoBmE1ERUDaISbpl5CtRf/ M6e6dEfxcZfkrIZSp5OI/oeqxbnCY62wSknmYqZfmthiGmRDvncLWIvzRYgEVdNpcGdU F0iA== X-Gm-Message-State: AOAM532omKPHe+XtMlKRZxbMpr2aTwH77Lz3GQxi0JjcQDaD1A+L/H1a 3U7M3r1WUls9XTikn7VPtuY= X-Google-Smtp-Source: ABdhPJxmVFPsxov0H0cCMDDNf4f6cKPzUbsfJ55TAJIqNQXt9vr/ekmrqh4p0DkGsgxHRXxLDi6xmA== X-Received: by 2002:a05:6402:3447:b0:42a:a449:ebb with SMTP id l7-20020a056402344700b0042aa4490ebbmr19360365edc.75.1653227959617; Sun, 22 May 2022 06:59:19 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id 5-20020a170906024500b006fe8bf56f53sm4856982ejl.43.2022.05.22.06.59.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 May 2022 06:59:19 -0700 (PDT) Message-ID: Date: Sun, 22 May 2022 16:57:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: Alper Nebi Yasak Subject: Re: [PATCH V4 5/8] tools: binman: section: replace @ with - To: "Peng Fan (OSS)" Cc: u-boot@lists.denx.de, Peng Fan , sbabic@denx.de, festevam@gmail.com, ariel.dalessandro@collabora.com, michael@amarulasolutions.com, tharvey@gateworks.com, sjg@chromium.org, marek.behun@nic.cz, pali@kernel.org, sr@denx.de, ricardo@foundries.io, patrick.delaunay@foss.st.com, trini@konsulko.com References: <20220520141048.20034-1-peng.fan@oss.nxp.com> <20220520141048.20034-6-peng.fan@oss.nxp.com> Content-Language: en-US In-Reply-To: <20220520141048.20034-6-peng.fan@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 20/05/2022 17:10, Peng Fan (OSS) wrote: > From: Peng Fan > > In arch/arm/dts/imx8mp-u-boot.dtsi, there are blob-ext@1, blob-ext@2 and > etc which is for packing ddr phy firmware. However we could not declare > symbol name such as 'binman_sym_declare(ulong, blob_ext@1, image_pos)', > because '@' is not allowed, so we choose to declare the symbol > 'binman_sym_declare(ulong, blob_ext_1, image_pos);' with '@' replaced with > '_'. It does not impact if there is no '@' in section name. > > Tested-by: Tim Harvey #imx8m[m,n,p]-venice > Reviewed-by: Tom Rini > Signed-off-by: Peng Fan > --- > tools/binman/etype/section.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This shouldn't be necessary if you keep the old names for the binman entries and use `binman_sym_declare(ulong, imem_1d, image_pos);` etc. for the symbols. > diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py > index bd67238b919..e3f362b442b 100644 > --- a/tools/binman/etype/section.py > +++ b/tools/binman/etype/section.py > @@ -875,7 +875,7 @@ class Entry_section(Entry): > entries[entry.GetPath()] = entry > for entry in to_add.values(): > self._CollectEntries(entries, entries_by_name, entry) > - entries_by_name[add_entry.name] = add_entry > + entries_by_name[add_entry.name.replace('@', '-')] = add_entry The correct place to do this would be LookupSymbol() in binman/etype/section.py, but I'm not convinced this should be done at all. I'd say if an entry is important enough to have a symbol for it, it should have a unique, descriptive, non-@ name. > > def MissingArgs(self, entry, missing): > """Report a missing argument, if enabled