From: Paul Durrant <Paul.Durrant@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@citrix.com>,
"Keir (Xen.org)" <keir@xen.org>, Jan Beulich <jbeulich@suse.com>,
"Tim (Xen.org)" <tim@xen.org>
Subject: Re: [PATCH v4 3/3] public/io/netif.h: document new extra info for passing hash values
Date: Fri, 8 Jan 2016 16:26:54 +0000 [thread overview]
Message-ID: <abca4951e8264c3380905bab757b69c6@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <1452269146.26438.33.camel@citrix.com>
> -----Original Message-----
> From: Ian Campbell [mailto:ian.campbell@citrix.com]
> Sent: 08 January 2016 16:06
> To: Paul Durrant; xen-devel@lists.xenproject.org
> Cc: Ian Jackson; Jan Beulich; Keir (Xen.org); Tim (Xen.org)
> Subject: Re: [PATCH v4 3/3] public/io/netif.h: document new extra info for
> passing hash values
>
> On Thu, 2016-01-07 at 13:05 +0000, Paul Durrant wrote:
> >
> > /*
> > + * Hash types. (See NETIF_CTRL_TOEPLITZ_FLAG_* definitions above
> > + * for more information).
> > + */
> > +#define XEN_NETIF_HASH_TYPE_NONE 0
> > +#define XEN_NETIF_HASH_TYPE_IPV4 1
> > +#define XEN_NETIF_HASH_TYPE_IPV4_TCP 2
> > +#define XEN_NETIF_HASH_TYPE_IPV6 3
> > +#define XEN_NETIF_HASH_TYPE_IPV6_TCP 4
>
> Should these be TYPE_TOEPLITZ_FOO? I suppose there are other possible
> TCPv4
> hashes for example.
I didn't consider that possibility of having multiple hashing schemes in operation at the same time, but I guess someone may want such a thing at some point.
>
> Perhaps a comment along the lines "XEN_NETIF_HASH_TYPE_TOEPLITZ_*
> corresponds precisely to the bit positions of NETIF_CTRL_TOEPLITZ_FLAG_*
> values", or even defining one in terms of the other?
Yes, that sounds reasonable...
>
> The control side (previous patch) has a toeplitz specific mechanism, with
> individual hash bits with it, whereas this is presented more as a generic
> hash mechanism with specific bits corresponding to toeplitz hashes.
> i.e. NETIF_CTRL_TOEPLITZ* vs XEN_NETIF_EXTRA_TYPE_HASH. Seems like a
> wrinkle, but I'm not sure if its an important one.
>
...if perhaps I make the extra type XEN_NETIF_EXTRA_TYPE_TOEPLITZ_HASH. That would leave things more open for someone else adding an extra type for another hash and needed a slightly different format/set of flags.
Paul
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-08 16:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 13:05 [PATCH v4 0/3] public/io/netif.h: support for toeplitz hashing Paul Durrant
2016-01-07 13:05 ` [PATCH v4 1/3] public/io/netif.h: document transmit and receive wire formats separately Paul Durrant
2016-01-08 15:24 ` Ian Campbell
2016-01-08 15:56 ` Paul Durrant
2016-01-08 16:10 ` Ian Campbell
2016-01-07 13:05 ` [PATCH v4 2/3] public/io/netif.h: document control ring and toeplitz hashing Paul Durrant
2016-01-08 15:53 ` Ian Campbell
2016-01-08 16:19 ` Paul Durrant
2016-01-08 16:46 ` Ian Campbell
2016-01-08 17:07 ` Paul Durrant
2016-01-08 17:22 ` Ian Campbell
2016-01-08 17:35 ` Paul Durrant
2016-01-08 16:07 ` David Vrabel
2016-01-08 16:21 ` Paul Durrant
2016-01-08 16:22 ` David Vrabel
2016-01-07 13:05 ` [PATCH v4 3/3] public/io/netif.h: document new extra info for passing hash values Paul Durrant
2016-01-08 16:05 ` Ian Campbell
2016-01-08 16:26 ` Paul Durrant [this message]
2016-01-08 16:48 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abca4951e8264c3380905bab757b69c6@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.