From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF0C3C4361B for ; Thu, 10 Dec 2020 14:38:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7576323D50 for ; Thu, 10 Dec 2020 14:38:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7576323D50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knN5J-0008EB-Dv for qemu-devel@archiver.kernel.org; Thu, 10 Dec 2020 09:38:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knN26-0005zV-EL for qemu-devel@nongnu.org; Thu, 10 Dec 2020 09:35:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1knN24-0001hx-22 for qemu-devel@nongnu.org; Thu, 10 Dec 2020 09:35:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607610897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1iJnxtvgCJ39eWBsSfprAe1n+FbeGJcCIfWwLPok5fk=; b=G5ftWYe3UxkRQlqQ7LuOSao8HezgSqICAvHIM8pl+KbjEB4tkRoxQp+41HzH7h5ADLppIb enUyFzqws7gVmNS1atoce0alN34VAT7UJ5UWwUAz43imiofOsiuv384lxepZ8j2qGGwWoZ l01xqIVJjI4VJe49iL/UhMk7CO6HJec= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-RqR2NqXrNza5TUnizW6A7w-1; Thu, 10 Dec 2020 09:34:54 -0500 X-MC-Unique: RqR2NqXrNza5TUnizW6A7w-1 Received: by mail-wr1-f69.google.com with SMTP id b8so2000346wrv.14 for ; Thu, 10 Dec 2020 06:34:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1iJnxtvgCJ39eWBsSfprAe1n+FbeGJcCIfWwLPok5fk=; b=cm1TYGqRYSrsxM7ZJ5wr8sNJl8fk1qwixika5OxYkr28kRIvSO3jAsGmfcvYHs4opa j2Y1LlFTPqtcsPNoxhEMrictck7vOowg+cO0nLn0JJIZ9K01HmhdPz4XrSGx7xYH6AG6 pYmX8JysI0OWgsr7+Dj0KKzqeC6+dp3i84APUR+WqYl2ousjjAT0y7nSkUJ3wmVGVzO4 b7icyEkvFNLwNlLkJivDt9uMuSanAN00UsgXLCaO7EIyQYdeIDag8KsRlA3N0armQs25 ZS2i5RGzHABt7u+OZKIRTEXDOp4BKExjhrK8Sq8IgzkA6YbyTzIdbQuIyOzml0WBFo49 kkng== X-Gm-Message-State: AOAM531FHiD7D3KrPSP441O7Xunc+4BL6BuZBAFzkJ1ViSccQT1851Nt Aw5vJG+XlLVsYxp2H0NsAyjdLfYTqqNuvgshqRCMhGm4JJks2IPmaFg0TRBpghvEdpAXQ6kkfTF l64xtBFZmalBsrRc= X-Received: by 2002:adf:c648:: with SMTP id u8mr8613014wrg.215.1607610893491; Thu, 10 Dec 2020 06:34:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJM5ihYY53/XlfDii2nCk1B/kZHEpNNLEOjXCv2BcF6TABt0f8DkOpZAu5B1naY2xoeGxkTg== X-Received: by 2002:adf:c648:: with SMTP id u8mr8612994wrg.215.1607610893357; Thu, 10 Dec 2020 06:34:53 -0800 (PST) Received: from [192.168.1.36] (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id b9sm9513717wmd.32.2020.12.10.06.34.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Dec 2020 06:34:52 -0800 (PST) Subject: Re: [PATCH v3 08/13] audio: remove GNUC & MSVC check To: Peter Maydell References: <20201210134752.780923-1-marcandre.lureau@redhat.com> <20201210134752.780923-9-marcandre.lureau@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 10 Dec 2020 15:34:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Paolo Bonzini , Paul Durrant , Richard Henderson , QEMU Developers , Laurent Vivier , qemu-arm , Gerd Hoffmann , Stefan Hajnoczi , "open list:X86" , Anthony Perard , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/10/20 3:27 PM, Peter Maydell wrote: > On Thu, 10 Dec 2020 at 14:26, Philippe Mathieu-Daudé wrote: >> >> On 12/10/20 2:47 PM, marcandre.lureau@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> QEMU requires either GCC or Clang, which both advertize __GNUC__. >>> Drop MSVC fallback path. >>> >>> Note: I intentionally left further cleanups for a later work. >>> >>> Signed-off-by: Marc-André Lureau >>> --- >>> audio/audio.c | 8 +------- >>> 1 file changed, 1 insertion(+), 7 deletions(-) >>> >>> diff --git a/audio/audio.c b/audio/audio.c >>> index 46578e4a58..d7a00294de 100644 >>> --- a/audio/audio.c >>> +++ b/audio/audio.c >>> @@ -122,13 +122,7 @@ int audio_bug (const char *funcname, int cond) >>> >>> #if defined AUDIO_BREAKPOINT_ON_BUG >>> # if defined HOST_I386 >>> -# if defined __GNUC__ >>> - __asm__ ("int3"); >>> -# elif defined _MSC_VER >>> - _asm _emit 0xcc; >>> -# else >>> - abort (); >>> -# endif >>> + __asm__ ("int3"); >> >> This was 15 years ago... Why not simply use abort() today? > > That's what I suggested when I looked at this patch in > the previous version of the patchset, yes... Ah, I went back to read v2 thread. Actually I even prefer Gerd's suggestion to remove this dead code. Regards, Phil. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C09C433FE for ; Thu, 10 Dec 2020 14:35:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA4EE2310F for ; Thu, 10 Dec 2020 14:35:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA4EE2310F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.49366.87298 (Exim 4.92) (envelope-from ) id 1knN23-0005AR-Ne; Thu, 10 Dec 2020 14:34:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 49366.87298; Thu, 10 Dec 2020 14:34:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1knN23-0005AK-KC; Thu, 10 Dec 2020 14:34:59 +0000 Received: by outflank-mailman (input) for mailman id 49366; Thu, 10 Dec 2020 14:34:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1knN23-0005AF-3y for xen-devel@lists.xenproject.org; Thu, 10 Dec 2020 14:34:59 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 0a65c9e7-ae9b-4458-b61f-5b29f4cce0d7; Thu, 10 Dec 2020 14:34:58 +0000 (UTC) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471--nFxMmSzN_aW3oiKZ3bKuw-1; Thu, 10 Dec 2020 09:34:54 -0500 Received: by mail-wm1-f69.google.com with SMTP id o203so1178186wmo.3 for ; Thu, 10 Dec 2020 06:34:54 -0800 (PST) Received: from [192.168.1.36] (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id b9sm9513717wmd.32.2020.12.10.06.34.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Dec 2020 06:34:52 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a65c9e7-ae9b-4458-b61f-5b29f4cce0d7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607610898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1iJnxtvgCJ39eWBsSfprAe1n+FbeGJcCIfWwLPok5fk=; b=ASM9zcx9CytjojQ/FsWJzLgPyYQqaqiKiDg72Z99XluyOMtIhksIlxoLEQfp+ERenk2uxS h5AEMlCJSs6LGGkun1H81xastJZJTRgYF/k0seqYJqMFYuxafCr5WWxwIzjc1UUkYk3sZ7 OlL2kG4+i0H3a120F7ZR/eBhXMZrTNg= X-MC-Unique: -nFxMmSzN_aW3oiKZ3bKuw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1iJnxtvgCJ39eWBsSfprAe1n+FbeGJcCIfWwLPok5fk=; b=IEdtZ2/bx8+k3qBSlo39He0BpM35UyqpoKKohNOAedUV201nhpVVnfJ2Mm3JW1SuTG eiz/Oz+3ft6gLtgszaFajPr00baKPLVGebjpkysa/SPcLe/NAmAAomzcSTbL45c23EeO iyRpLEEJEJecJtgatPGHdkjjSWXc186KX89abxy5uRkMHDfO5npFsympacQP5BzDxGCe WWm6Z/lknIEeWjM2ceDxjX0S6e7itDHiOVnMmr8MMCkylLYgLND2KzHvwxM1UF+vtrCT rsPs0Za8KGm0aDVyPsyU38hrp+n0otNcoAlBXK0GS3dXcjMOiTwqmaklRa43N+/O2Oo0 2iAg== X-Gm-Message-State: AOAM533HwHKRjlHWH7Ta+lX5xv7L3Q8V26WKwh5YYlknb6RkKgCmphLz f6iqAgyfSIjd2QDIxT+f+2Cybg4fRJiRTSryLAJEq7Se1x71G9QMLlTq92osFzXgTMOeCeqnYlo u9HuDCQEIZIynmR0qUi0BRp5Pk6Y= X-Received: by 2002:adf:c648:: with SMTP id u8mr8613007wrg.215.1607610893491; Thu, 10 Dec 2020 06:34:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJM5ihYY53/XlfDii2nCk1B/kZHEpNNLEOjXCv2BcF6TABt0f8DkOpZAu5B1naY2xoeGxkTg== X-Received: by 2002:adf:c648:: with SMTP id u8mr8612994wrg.215.1607610893357; Thu, 10 Dec 2020 06:34:53 -0800 (PST) Subject: Re: [PATCH v3 08/13] audio: remove GNUC & MSVC check To: Peter Maydell Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , QEMU Developers , Richard Henderson , Laurent Vivier , Paul Durrant , "open list:X86" , Stefan Hajnoczi , Gerd Hoffmann , Stefano Stabellini , Anthony Perard , "Dr. David Alan Gilbert" , qemu-arm , Paolo Bonzini References: <20201210134752.780923-1-marcandre.lureau@redhat.com> <20201210134752.780923-9-marcandre.lureau@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 10 Dec 2020 15:34:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 12/10/20 3:27 PM, Peter Maydell wrote: > On Thu, 10 Dec 2020 at 14:26, Philippe Mathieu-Daudé wrote: >> >> On 12/10/20 2:47 PM, marcandre.lureau@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> QEMU requires either GCC or Clang, which both advertize __GNUC__. >>> Drop MSVC fallback path. >>> >>> Note: I intentionally left further cleanups for a later work. >>> >>> Signed-off-by: Marc-André Lureau >>> --- >>> audio/audio.c | 8 +------- >>> 1 file changed, 1 insertion(+), 7 deletions(-) >>> >>> diff --git a/audio/audio.c b/audio/audio.c >>> index 46578e4a58..d7a00294de 100644 >>> --- a/audio/audio.c >>> +++ b/audio/audio.c >>> @@ -122,13 +122,7 @@ int audio_bug (const char *funcname, int cond) >>> >>> #if defined AUDIO_BREAKPOINT_ON_BUG >>> # if defined HOST_I386 >>> -# if defined __GNUC__ >>> - __asm__ ("int3"); >>> -# elif defined _MSC_VER >>> - _asm _emit 0xcc; >>> -# else >>> - abort (); >>> -# endif >>> + __asm__ ("int3"); >> >> This was 15 years ago... Why not simply use abort() today? > > That's what I suggested when I looked at this patch in > the previous version of the patchset, yes... Ah, I went back to read v2 thread. Actually I even prefer Gerd's suggestion to remove this dead code. Regards, Phil.