From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62F1C433F5 for ; Thu, 31 Mar 2022 12:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232806AbiCaMPE (ORCPT ); Thu, 31 Mar 2022 08:15:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235899AbiCaMPD (ORCPT ); Thu, 31 Mar 2022 08:15:03 -0400 Received: from mail-m176237.qiye.163.com (mail-m176237.qiye.163.com [59.111.176.237]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99FD91FF21E for ; Thu, 31 Mar 2022 05:13:16 -0700 (PDT) Received: from [192.168.60.102] (unknown [103.29.142.67]) by mail-m176237.qiye.163.com (Hmail) with ESMTPA id CB9D1C40311; Thu, 31 Mar 2022 20:13:11 +0800 (CST) Message-ID: Date: Thu, 31 Mar 2022 20:13:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer , Piotr Oniszczuk Cc: "devicetree@vger.kernel.org" , Benjamin Gaignard , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Michael Riesch , kernel@pengutronix.de, "linux-arm-kernel@lists.infradead.org" References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220330072822.GX12181@pengutronix.de> <0D8F5951-5375-46B5-BFF0-7ED410371EB7@gmail.com> <20220330094556.GZ12181@pengutronix.de> <20220330102046.GA12181@pengutronix.de> <60601619-EF07-457B-91F2-64FEB598FEBE@gmail.com> <20220330192054.GA4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220330192054.GA4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUMaGkhWSk1LSU9NQh8fSE 4aVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OjI6Qxw*HD4BSg05SjpMOBwS DkoaCjpVSlVKTU9DTElDTEJPS0lOVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZSktIVUlCVUpPSVVNTFlXWQgBWUFNS0NCNwY+ X-HM-Tid: 0a7fdfe4e207d9afkuwscb9d1c40311 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Piotr: On 3/31/22 03:20, Sascha Hauer wrote: > On Wed, Mar 30, 2022 at 04:52:22PM +0200, Piotr Oniszczuk wrote: >> >>> Wiadomość napisana przez Sascha Hauer w dniu 30.03.2022, o godz. 12:20: >>> >>> Does it change anything if you do a "modetest -s 69@67:1920x1080" before >>> starting the app? Or if you run "modetest -P 43@67:1920x1080@NV12" >>> before starting the app? Or other combinations thereof? >> So i tried following combinations >> >> -boot >> -modetest -s 69@67:1920x1080 -> ok >> -modetest -P 43@67:1920x1080@NV12 -> green screen > I have no idea what is going on here. There same commands work for me. > You could provide me your kernel config and upstream commitish you are > working on, maybe that gets me closer to your setup. It's a little strange, I can't reproduce this issue neither. But I have problem with this two step command sequence. step 1:  modetest -s 69@67:1920x1080 -> ok step 2:  modetest -P 43@67:1920x1080@NV12, I got the failed message:  "failed to enable plane: Permission denied" Because the drm core will stop step2 by drm_ioctrl_permit as DRM_IOCTL_SETPLANE need a master, but the current master is the modetest run by step1. static int drm_ioctl_permit(u32 flags, struct drm_file *file_priv) {         /* ROOT_ONLY is only for CAP_SYS_ADMIN */         if (unlikely((flags & DRM_ROOT_ONLY) && !capable(CAP_SYS_ADMIN))) {                 printk("DRM_ROOT_ONLY\n");                 return -EACCES;         }         /* AUTH is only for authenticated or render client */         if (unlikely((flags & DRM_AUTH) && !drm_is_render_client(file_priv) &&                      !file_priv->authenticated)) {                 printk("DRM_AUTH\n");                 return -EACCES;         }         /* MASTER is only for master or control clients */         if (unlikely((flags & DRM_MASTER) &&                      !drm_is_current_master(file_priv))) {                 printk("DRM_MASTER\n");                 return -EACCES;         }         /* Render clients must be explicitly allowed */         if (unlikely(!(flags & DRM_RENDER_ALLOW) &&                      drm_is_render_client(file_priv))) {                 printk("DRM_RENDER_NOT_ALLOW\n");                 return -EACCES;         }         return 0; } After bypass the permission check, I can run step 2 , but the display on the screen will have a shift as the wrong dly configuration. So how you two got step two run success? Piotr: What soc is on you board? rk3566 or rk3568? I have a scripts[0]  use io[1] command to dump the VOP2 register you can use it dump the register configuration when you meet a display failure, then send the dump to me, maybe I can figure out something. [0]https://github.com/andyshrk/buildroot/blob/2022/board/andyshrk/rootfs_overlay/usr/bin/vop2_dump.sh [1] https://github.com/andyshrk/io > > Sascha > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACE1FC433EF for ; Thu, 31 Mar 2022 12:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0jeX8Zd9AnI/9XevkpBRIsLPVdiDC10a8CM/FhrQHiA=; b=yDL/tSNe0kT5Bo EXbsvqy5QGDaZPq7ANZb4AKs73elB2KH/BTQtynTKXkEOi6oe3xs1kcgwVa8OmTjDIlJ6EiRfMbVs UhDELosJNfYqcfehk50mLDO3Eh8EprwtCSSpov3o52LW5HfZaF7Gnc2BsFRgWb8cttQ7bP41dpWnS AMqj/Fff0rn2ZwVXXliHy4UAXFqKFviEZZXOVXvXgFiDVw/kzFFOvcpzfivQj9nZCZOUxY1Qtmbhk FkCluHliB1jvbomHTnB/y4TIM5t9+dJqCHNSlLBzxaV1kmFzDdMi1jTYqhlYT1S22i/u1eV+m0BBk UGnyqGuPsq64K7THPGkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZtgC-002Alt-EI; Thu, 31 Mar 2022 12:13:32 +0000 Received: from mail-m176237.qiye.163.com ([59.111.176.237]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZtfy-002AhH-AX; Thu, 31 Mar 2022 12:13:20 +0000 Received: from [192.168.60.102] (unknown [103.29.142.67]) by mail-m176237.qiye.163.com (Hmail) with ESMTPA id CB9D1C40311; Thu, 31 Mar 2022 20:13:11 +0800 (CST) Message-ID: Date: Thu, 31 Mar 2022 20:13:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer , Piotr Oniszczuk Cc: "devicetree@vger.kernel.org" , Benjamin Gaignard , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Michael Riesch , kernel@pengutronix.de, "linux-arm-kernel@lists.infradead.org" References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220330072822.GX12181@pengutronix.de> <0D8F5951-5375-46B5-BFF0-7ED410371EB7@gmail.com> <20220330094556.GZ12181@pengutronix.de> <20220330102046.GA12181@pengutronix.de> <60601619-EF07-457B-91F2-64FEB598FEBE@gmail.com> <20220330192054.GA4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220330192054.GA4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUMaGkhWSk1LSU9NQh8fSE 4aVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OjI6Qxw*HD4BSg05SjpMOBwS DkoaCjpVSlVKTU9DTElDTEJPS0lOVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZSktIVUlCVUpPSVVNTFlXWQgBWUFNS0NCNwY+ X-HM-Tid: 0a7fdfe4e207d9afkuwscb9d1c40311 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_051318_565622_AD419116 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgUGlvdHI6CgpPbiAzLzMxLzIyIDAzOjIwLCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4gT24gV2Vk LCBNYXIgMzAsIDIwMjIgYXQgMDQ6NTI6MjJQTSArMDIwMCwgUGlvdHIgT25pc3pjenVrIHdyb3Rl Ogo+Pgo+Pj4gV2lhZG9tb8WbxIcgbmFwaXNhbmEgcHJ6ZXogU2FzY2hhIEhhdWVyIDxzLmhhdWVy QHBlbmd1dHJvbml4LmRlPiB3IGRuaXUgMzAuMDMuMjAyMiwgbyBnb2R6LiAxMjoyMDoKPj4+Cj4+ PiBEb2VzIGl0IGNoYW5nZSBhbnl0aGluZyBpZiB5b3UgZG8gYSAibW9kZXRlc3QgLXMgNjlANjc6 MTkyMHgxMDgwIiBiZWZvcmUKPj4+IHN0YXJ0aW5nIHRoZSBhcHA/IE9yIGlmIHlvdSBydW4gIm1v ZGV0ZXN0IC1QIDQzQDY3OjE5MjB4MTA4MEBOVjEyIgo+Pj4gYmVmb3JlIHN0YXJ0aW5nIHRoZSBh cHA/IE9yIG90aGVyIGNvbWJpbmF0aW9ucyB0aGVyZW9mPwo+PiBTbyBpIHRyaWVkIGZvbGxvd2lu ZyBjb21iaW5hdGlvbnMKPj4KPj4gLWJvb3QKPj4gLW1vZGV0ZXN0IC1zIDY5QDY3OjE5MjB4MTA4 MCAtPiBvawo+PiAtbW9kZXRlc3QgLVAgNDNANjc6MTkyMHgxMDgwQE5WMTIgLT4gZ3JlZW4gc2Ny ZWVuCj4gSSBoYXZlIG5vIGlkZWEgd2hhdCBpcyBnb2luZyBvbiBoZXJlLiBUaGVyZSBzYW1lIGNv bW1hbmRzIHdvcmsgZm9yIG1lLgo+IFlvdSBjb3VsZCBwcm92aWRlIG1lIHlvdXIga2VybmVsIGNv bmZpZyBhbmQgdXBzdHJlYW0gY29tbWl0aXNoIHlvdSBhcmUKPiB3b3JraW5nIG9uLCBtYXliZSB0 aGF0IGdldHMgbWUgY2xvc2VyIHRvIHlvdXIgc2V0dXAuCgoKSXQncyBhIGxpdHRsZSBzdHJhbmdl LCBJIGNhbid0IHJlcHJvZHVjZSB0aGlzIGlzc3VlIG5laXRoZXIuCgpCdXQgSSBoYXZlIHByb2Js ZW0gd2l0aCB0aGlzIHR3byBzdGVwIGNvbW1hbmQgc2VxdWVuY2UuCgpzdGVwIDE6wqAgbW9kZXRl c3QgLXMgNjlANjc6MTkyMHgxMDgwIC0+IG9rCgpzdGVwIDI6wqAgbW9kZXRlc3QgLVAgNDNANjc6 MTkyMHgxMDgwQE5WMTIsCgpJIGdvdCB0aGUgZmFpbGVkIG1lc3NhZ2U6wqAgImZhaWxlZCB0byBl bmFibGUgcGxhbmU6IFBlcm1pc3Npb24gZGVuaWVkIgoKQmVjYXVzZSB0aGUgZHJtIGNvcmUgd2ls bCBzdG9wIHN0ZXAyIGJ5IGRybV9pb2N0cmxfcGVybWl0IGFzIApEUk1fSU9DVExfU0VUUExBTkUg bmVlZCBhIG1hc3RlciwKCmJ1dCB0aGUgY3VycmVudCBtYXN0ZXIgaXMgdGhlIG1vZGV0ZXN0IHJ1 biBieSBzdGVwMS4KCnN0YXRpYyBpbnQgZHJtX2lvY3RsX3Blcm1pdCh1MzIgZmxhZ3MsIHN0cnVj dCBkcm1fZmlsZSAqZmlsZV9wcml2KQp7CgogwqDCoMKgwqDCoMKgwqAgLyogUk9PVF9PTkxZIGlz IG9ubHkgZm9yIENBUF9TWVNfQURNSU4gKi8KIMKgwqDCoMKgwqDCoMKgIGlmICh1bmxpa2VseSgo ZmxhZ3MgJiBEUk1fUk9PVF9PTkxZKSAmJiAhY2FwYWJsZShDQVBfU1lTX0FETUlOKSkpIHsKIMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwcmludGsoIkRSTV9ST09UX09OTFlcbiIpOwog wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUFDQ0VTOwogwqDCoMKgwqDC oMKgwqAgfQoKIMKgwqDCoMKgwqDCoMKgIC8qIEFVVEggaXMgb25seSBmb3IgYXV0aGVudGljYXRl ZCBvciByZW5kZXIgY2xpZW50ICovCiDCoMKgwqDCoMKgwqDCoCBpZiAodW5saWtlbHkoKGZsYWdz ICYgRFJNX0FVVEgpICYmIAohZHJtX2lzX3JlbmRlcl9jbGllbnQoZmlsZV9wcml2KSAmJgogwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAhZmlsZV9wcml2LT5hdXRoZW50 aWNhdGVkKSkgewogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByaW50aygiRFJNX0FV VEhcbiIpOwogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUFDQ0VTOwog wqDCoMKgwqDCoMKgwqAgfQoKIMKgwqDCoMKgwqDCoMKgIC8qIE1BU1RFUiBpcyBvbmx5IGZvciBt YXN0ZXIgb3IgY29udHJvbCBjbGllbnRzICovCiDCoMKgwqDCoMKgwqDCoCBpZiAodW5saWtlbHko KGZsYWdzICYgRFJNX01BU1RFUikgJiYKIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgIWRybV9pc19jdXJyZW50X21hc3RlcihmaWxlX3ByaXYpKSkgewogwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByaW50aygiRFJNX01BU1RFUlxuIik7CiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FQUNDRVM7CiDCoMKgwqDCoMKgwqDCoCB9Cgog wqDCoMKgwqDCoMKgwqAgLyogUmVuZGVyIGNsaWVudHMgbXVzdCBiZSBleHBsaWNpdGx5IGFsbG93 ZWQgKi8KIMKgwqDCoMKgwqDCoMKgIGlmICh1bmxpa2VseSghKGZsYWdzICYgRFJNX1JFTkRFUl9B TExPVykgJiYKIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZHJtX2lz X3JlbmRlcl9jbGllbnQoZmlsZV9wcml2KSkpIHsKIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBwcmludGsoIkRSTV9SRU5ERVJfTk9UX0FMTE9XXG4iKTsKIMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCByZXR1cm4gLUVBQ0NFUzsKIMKgwqDCoMKgwqDCoMKgIH0KCiDCoMKgwqDC oMKgwqDCoCByZXR1cm4gMDsKfQoKCkFmdGVyIGJ5cGFzcyB0aGUgcGVybWlzc2lvbiBjaGVjaywg SSBjYW4gcnVuIHN0ZXAgMiAsIGJ1dCB0aGUgZGlzcGxheSBvbiAKdGhlIHNjcmVlbiB3aWxsIGhh dmUgYSBzaGlmdCBhcyB0aGUgd3JvbmcgZGx5IGNvbmZpZ3VyYXRpb24uCgpTbyBob3cgeW91IHR3 byBnb3Qgc3RlcCB0d28gcnVuIHN1Y2Nlc3M/CgpQaW90cjoKCldoYXQgc29jIGlzIG9uIHlvdSBi b2FyZD8gcmszNTY2IG9yIHJrMzU2OD8KCkkgaGF2ZSBhIHNjcmlwdHNbMF3CoCB1c2UgaW9bMV0g Y29tbWFuZCB0byBkdW1wIHRoZSBWT1AyIHJlZ2lzdGVyIHlvdSBjYW4gCnVzZSBpdCBkdW1wIHRo ZSByZWdpc3RlciBjb25maWd1cmF0aW9uIHdoZW4geW91IG1lZXQgYSBkaXNwbGF5IGZhaWx1cmUs Cgp0aGVuIHNlbmQgdGhlIGR1bXAgdG8gbWUsIG1heWJlIEkgY2FuIGZpZ3VyZSBvdXQgc29tZXRo aW5nLgoKWzBdaHR0cHM6Ly9naXRodWIuY29tL2FuZHlzaHJrL2J1aWxkcm9vdC9ibG9iLzIwMjIv Ym9hcmQvYW5keXNocmsvcm9vdGZzX292ZXJsYXkvdXNyL2Jpbi92b3AyX2R1bXAuc2gKClsxXSBo dHRwczovL2dpdGh1Yi5jb20vYW5keXNocmsvaW8KCj4KPiBTYXNjaGEKPgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGlu ZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B136C433EF for ; Thu, 31 Mar 2022 12:13:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B86110E368; Thu, 31 Mar 2022 12:13:17 +0000 (UTC) Received: from mail-m176237.qiye.163.com (mail-m176237.qiye.163.com [59.111.176.237]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0DB7B10E368 for ; Thu, 31 Mar 2022 12:13:16 +0000 (UTC) Received: from [192.168.60.102] (unknown [103.29.142.67]) by mail-m176237.qiye.163.com (Hmail) with ESMTPA id CB9D1C40311; Thu, 31 Mar 2022 20:13:11 +0800 (CST) Message-ID: Date: Thu, 31 Mar 2022 20:13:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer , Piotr Oniszczuk References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220330072822.GX12181@pengutronix.de> <0D8F5951-5375-46B5-BFF0-7ED410371EB7@gmail.com> <20220330094556.GZ12181@pengutronix.de> <20220330102046.GA12181@pengutronix.de> <60601619-EF07-457B-91F2-64FEB598FEBE@gmail.com> <20220330192054.GA4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220330192054.GA4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUMaGkhWSk1LSU9NQh8fSE 4aVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OjI6Qxw*HD4BSg05SjpMOBwS DkoaCjpVSlVKTU9DTElDTEJPS0lOVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZSktIVUlCVUpPSVVNTFlXWQgBWUFNS0NCNwY+ X-HM-Tid: 0a7fdfe4e207d9afkuwscb9d1c40311 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Benjamin Gaignard , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Michael Riesch , Peter Geis , kernel@pengutronix.de, "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Piotr: On 3/31/22 03:20, Sascha Hauer wrote: > On Wed, Mar 30, 2022 at 04:52:22PM +0200, Piotr Oniszczuk wrote: >> >>> Wiadomość napisana przez Sascha Hauer w dniu 30.03.2022, o godz. 12:20: >>> >>> Does it change anything if you do a "modetest -s 69@67:1920x1080" before >>> starting the app? Or if you run "modetest -P 43@67:1920x1080@NV12" >>> before starting the app? Or other combinations thereof? >> So i tried following combinations >> >> -boot >> -modetest -s 69@67:1920x1080 -> ok >> -modetest -P 43@67:1920x1080@NV12 -> green screen > I have no idea what is going on here. There same commands work for me. > You could provide me your kernel config and upstream commitish you are > working on, maybe that gets me closer to your setup. It's a little strange, I can't reproduce this issue neither. But I have problem with this two step command sequence. step 1:  modetest -s 69@67:1920x1080 -> ok step 2:  modetest -P 43@67:1920x1080@NV12, I got the failed message:  "failed to enable plane: Permission denied" Because the drm core will stop step2 by drm_ioctrl_permit as DRM_IOCTL_SETPLANE need a master, but the current master is the modetest run by step1. static int drm_ioctl_permit(u32 flags, struct drm_file *file_priv) {         /* ROOT_ONLY is only for CAP_SYS_ADMIN */         if (unlikely((flags & DRM_ROOT_ONLY) && !capable(CAP_SYS_ADMIN))) {                 printk("DRM_ROOT_ONLY\n");                 return -EACCES;         }         /* AUTH is only for authenticated or render client */         if (unlikely((flags & DRM_AUTH) && !drm_is_render_client(file_priv) &&                      !file_priv->authenticated)) {                 printk("DRM_AUTH\n");                 return -EACCES;         }         /* MASTER is only for master or control clients */         if (unlikely((flags & DRM_MASTER) &&                      !drm_is_current_master(file_priv))) {                 printk("DRM_MASTER\n");                 return -EACCES;         }         /* Render clients must be explicitly allowed */         if (unlikely(!(flags & DRM_RENDER_ALLOW) &&                      drm_is_render_client(file_priv))) {                 printk("DRM_RENDER_NOT_ALLOW\n");                 return -EACCES;         }         return 0; } After bypass the permission check, I can run step 2 , but the display on the screen will have a shift as the wrong dly configuration. So how you two got step two run success? Piotr: What soc is on you board? rk3566 or rk3568? I have a scripts[0]  use io[1] command to dump the VOP2 register you can use it dump the register configuration when you meet a display failure, then send the dump to me, maybe I can figure out something. [0]https://github.com/andyshrk/buildroot/blob/2022/board/andyshrk/rootfs_overlay/usr/bin/vop2_dump.sh [1] https://github.com/andyshrk/io > > Sascha > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D3EAC433F5 for ; Thu, 31 Mar 2022 12:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZR9KGqgFeSZMG9qVIMiAy1K9TQPSUfqrZXTfdeupbfs=; b=mObtrvad5vIExO VGNLYAlScGuwvrGqg0bIefPl16yoJQobCkXi3mw2FsA6OUegKNZ+wv/vuFbzwhiayGpOwSj++YODB K08O6fIyjPXcfEuY0ZhebdlBSoqllqopyO/R80U8mC+YXWZMy9O9oHEEmwDdUvnCSGxC80fsGNmhA 0WHBhdsj5SpkNyzDtjzlCoHczfixtUGcZGOZo5v7tM6J1n6NcOd2FMA6PKWxzlcen4vG7UyLUPBAD SS//SbJo6pVhLMVGALV7jCVdlszvCCgzuBt7txeMUyABFyY0IS0IPkY1Fekb/pg9mi1wz0JXvcTJW Chrmn4gXOJEIdGkzukVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZtg2-002Ak2-V5; Thu, 31 Mar 2022 12:13:23 +0000 Received: from mail-m176237.qiye.163.com ([59.111.176.237]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZtfy-002AhH-AX; Thu, 31 Mar 2022 12:13:20 +0000 Received: from [192.168.60.102] (unknown [103.29.142.67]) by mail-m176237.qiye.163.com (Hmail) with ESMTPA id CB9D1C40311; Thu, 31 Mar 2022 20:13:11 +0800 (CST) Message-ID: Date: Thu, 31 Mar 2022 20:13:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer , Piotr Oniszczuk Cc: "devicetree@vger.kernel.org" , Benjamin Gaignard , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Michael Riesch , kernel@pengutronix.de, "linux-arm-kernel@lists.infradead.org" References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220330072822.GX12181@pengutronix.de> <0D8F5951-5375-46B5-BFF0-7ED410371EB7@gmail.com> <20220330094556.GZ12181@pengutronix.de> <20220330102046.GA12181@pengutronix.de> <60601619-EF07-457B-91F2-64FEB598FEBE@gmail.com> <20220330192054.GA4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220330192054.GA4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUMaGkhWSk1LSU9NQh8fSE 4aVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkxVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OjI6Qxw*HD4BSg05SjpMOBwS DkoaCjpVSlVKTU9DTElDTEJPS0lOVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZSktIVUlCVUpPSVVNTFlXWQgBWUFNS0NCNwY+ X-HM-Tid: 0a7fdfe4e207d9afkuwscb9d1c40311 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_051318_565622_AD419116 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGlvdHI6CgpPbiAzLzMxLzIyIDAzOjIwLCBTYXNjaGEgSGF1ZXIgd3JvdGU6Cj4gT24gV2Vk LCBNYXIgMzAsIDIwMjIgYXQgMDQ6NTI6MjJQTSArMDIwMCwgUGlvdHIgT25pc3pjenVrIHdyb3Rl Ogo+Pgo+Pj4gV2lhZG9tb8WbxIcgbmFwaXNhbmEgcHJ6ZXogU2FzY2hhIEhhdWVyIDxzLmhhdWVy QHBlbmd1dHJvbml4LmRlPiB3IGRuaXUgMzAuMDMuMjAyMiwgbyBnb2R6LiAxMjoyMDoKPj4+Cj4+ PiBEb2VzIGl0IGNoYW5nZSBhbnl0aGluZyBpZiB5b3UgZG8gYSAibW9kZXRlc3QgLXMgNjlANjc6 MTkyMHgxMDgwIiBiZWZvcmUKPj4+IHN0YXJ0aW5nIHRoZSBhcHA/IE9yIGlmIHlvdSBydW4gIm1v ZGV0ZXN0IC1QIDQzQDY3OjE5MjB4MTA4MEBOVjEyIgo+Pj4gYmVmb3JlIHN0YXJ0aW5nIHRoZSBh cHA/IE9yIG90aGVyIGNvbWJpbmF0aW9ucyB0aGVyZW9mPwo+PiBTbyBpIHRyaWVkIGZvbGxvd2lu ZyBjb21iaW5hdGlvbnMKPj4KPj4gLWJvb3QKPj4gLW1vZGV0ZXN0IC1zIDY5QDY3OjE5MjB4MTA4 MCAtPiBvawo+PiAtbW9kZXRlc3QgLVAgNDNANjc6MTkyMHgxMDgwQE5WMTIgLT4gZ3JlZW4gc2Ny ZWVuCj4gSSBoYXZlIG5vIGlkZWEgd2hhdCBpcyBnb2luZyBvbiBoZXJlLiBUaGVyZSBzYW1lIGNv bW1hbmRzIHdvcmsgZm9yIG1lLgo+IFlvdSBjb3VsZCBwcm92aWRlIG1lIHlvdXIga2VybmVsIGNv bmZpZyBhbmQgdXBzdHJlYW0gY29tbWl0aXNoIHlvdSBhcmUKPiB3b3JraW5nIG9uLCBtYXliZSB0 aGF0IGdldHMgbWUgY2xvc2VyIHRvIHlvdXIgc2V0dXAuCgoKSXQncyBhIGxpdHRsZSBzdHJhbmdl LCBJIGNhbid0IHJlcHJvZHVjZSB0aGlzIGlzc3VlIG5laXRoZXIuCgpCdXQgSSBoYXZlIHByb2Js ZW0gd2l0aCB0aGlzIHR3byBzdGVwIGNvbW1hbmQgc2VxdWVuY2UuCgpzdGVwIDE6wqAgbW9kZXRl c3QgLXMgNjlANjc6MTkyMHgxMDgwIC0+IG9rCgpzdGVwIDI6wqAgbW9kZXRlc3QgLVAgNDNANjc6 MTkyMHgxMDgwQE5WMTIsCgpJIGdvdCB0aGUgZmFpbGVkIG1lc3NhZ2U6wqAgImZhaWxlZCB0byBl bmFibGUgcGxhbmU6IFBlcm1pc3Npb24gZGVuaWVkIgoKQmVjYXVzZSB0aGUgZHJtIGNvcmUgd2ls bCBzdG9wIHN0ZXAyIGJ5IGRybV9pb2N0cmxfcGVybWl0IGFzIApEUk1fSU9DVExfU0VUUExBTkUg bmVlZCBhIG1hc3RlciwKCmJ1dCB0aGUgY3VycmVudCBtYXN0ZXIgaXMgdGhlIG1vZGV0ZXN0IHJ1 biBieSBzdGVwMS4KCnN0YXRpYyBpbnQgZHJtX2lvY3RsX3Blcm1pdCh1MzIgZmxhZ3MsIHN0cnVj dCBkcm1fZmlsZSAqZmlsZV9wcml2KQp7CgogwqDCoMKgwqDCoMKgwqAgLyogUk9PVF9PTkxZIGlz IG9ubHkgZm9yIENBUF9TWVNfQURNSU4gKi8KIMKgwqDCoMKgwqDCoMKgIGlmICh1bmxpa2VseSgo ZmxhZ3MgJiBEUk1fUk9PVF9PTkxZKSAmJiAhY2FwYWJsZShDQVBfU1lTX0FETUlOKSkpIHsKIMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwcmludGsoIkRSTV9ST09UX09OTFlcbiIpOwog wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUFDQ0VTOwogwqDCoMKgwqDC oMKgwqAgfQoKIMKgwqDCoMKgwqDCoMKgIC8qIEFVVEggaXMgb25seSBmb3IgYXV0aGVudGljYXRl ZCBvciByZW5kZXIgY2xpZW50ICovCiDCoMKgwqDCoMKgwqDCoCBpZiAodW5saWtlbHkoKGZsYWdz ICYgRFJNX0FVVEgpICYmIAohZHJtX2lzX3JlbmRlcl9jbGllbnQoZmlsZV9wcml2KSAmJgogwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAhZmlsZV9wcml2LT5hdXRoZW50 aWNhdGVkKSkgewogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByaW50aygiRFJNX0FV VEhcbiIpOwogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUFDQ0VTOwog wqDCoMKgwqDCoMKgwqAgfQoKIMKgwqDCoMKgwqDCoMKgIC8qIE1BU1RFUiBpcyBvbmx5IGZvciBt YXN0ZXIgb3IgY29udHJvbCBjbGllbnRzICovCiDCoMKgwqDCoMKgwqDCoCBpZiAodW5saWtlbHko KGZsYWdzICYgRFJNX01BU1RFUikgJiYKIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgIWRybV9pc19jdXJyZW50X21hc3RlcihmaWxlX3ByaXYpKSkgewogwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIHByaW50aygiRFJNX01BU1RFUlxuIik7CiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FQUNDRVM7CiDCoMKgwqDCoMKgwqDCoCB9Cgog wqDCoMKgwqDCoMKgwqAgLyogUmVuZGVyIGNsaWVudHMgbXVzdCBiZSBleHBsaWNpdGx5IGFsbG93 ZWQgKi8KIMKgwqDCoMKgwqDCoMKgIGlmICh1bmxpa2VseSghKGZsYWdzICYgRFJNX1JFTkRFUl9B TExPVykgJiYKIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZHJtX2lz X3JlbmRlcl9jbGllbnQoZmlsZV9wcml2KSkpIHsKIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBwcmludGsoIkRSTV9SRU5ERVJfTk9UX0FMTE9XXG4iKTsKIMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCByZXR1cm4gLUVBQ0NFUzsKIMKgwqDCoMKgwqDCoMKgIH0KCiDCoMKgwqDC oMKgwqDCoCByZXR1cm4gMDsKfQoKCkFmdGVyIGJ5cGFzcyB0aGUgcGVybWlzc2lvbiBjaGVjaywg SSBjYW4gcnVuIHN0ZXAgMiAsIGJ1dCB0aGUgZGlzcGxheSBvbiAKdGhlIHNjcmVlbiB3aWxsIGhh dmUgYSBzaGlmdCBhcyB0aGUgd3JvbmcgZGx5IGNvbmZpZ3VyYXRpb24uCgpTbyBob3cgeW91IHR3 byBnb3Qgc3RlcCB0d28gcnVuIHN1Y2Nlc3M/CgpQaW90cjoKCldoYXQgc29jIGlzIG9uIHlvdSBi b2FyZD8gcmszNTY2IG9yIHJrMzU2OD8KCkkgaGF2ZSBhIHNjcmlwdHNbMF3CoCB1c2UgaW9bMV0g Y29tbWFuZCB0byBkdW1wIHRoZSBWT1AyIHJlZ2lzdGVyIHlvdSBjYW4gCnVzZSBpdCBkdW1wIHRo ZSByZWdpc3RlciBjb25maWd1cmF0aW9uIHdoZW4geW91IG1lZXQgYSBkaXNwbGF5IGZhaWx1cmUs Cgp0aGVuIHNlbmQgdGhlIGR1bXAgdG8gbWUsIG1heWJlIEkgY2FuIGZpZ3VyZSBvdXQgc29tZXRo aW5nLgoKWzBdaHR0cHM6Ly9naXRodWIuY29tL2FuZHlzaHJrL2J1aWxkcm9vdC9ibG9iLzIwMjIv Ym9hcmQvYW5keXNocmsvcm9vdGZzX292ZXJsYXkvdXNyL2Jpbi92b3AyX2R1bXAuc2gKClsxXSBo dHRwczovL2dpdGh1Yi5jb20vYW5keXNocmsvaW8KCj4KPiBTYXNjaGEKPgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=