From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BED9C4743C for ; Wed, 23 Jun 2021 08:45:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8580A610C7 for ; Wed, 23 Jun 2021 08:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbhFWIsI (ORCPT ); Wed, 23 Jun 2021 04:48:08 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:34820 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbhFWIsI (ORCPT ); Wed, 23 Jun 2021 04:48:08 -0400 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7390C9B1; Wed, 23 Jun 2021 10:45:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624437950; bh=vdil5caf9R7y+sZCCneZTTgcfclZfdMpg+nhInQs7Vc=; h=From:Subject:To:Cc:References:Date:In-Reply-To:From; b=ULHV8yQfdAxEKAdH/t90iz16PyBGMq0f9ilNegrWIS+osdgoWjIBJoeYOaY0+O22g 6+J49pQ+KiNXrN1l4D6hZGHKxXRsoDlI56KlI5+edxlUUy1J16EmTWlOv2QGpmMfrp BELta1AWAOQZEsUy0JBz/qWNqWb+Gi4e5nVujH/Q= From: Kieran Bingham Subject: Re: [PATCH] drm: rcar-du: lvds: Don't set bridge driver_private field To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org References: <20210623030545.7627-1-laurent.pinchart+renesas@ideasonboard.com> Message-ID: Date: Wed, 23 Jun 2021 09:45:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210623030545.7627-1-laurent.pinchart+renesas@ideasonboard.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Laurent, On 23/06/2021 04:05, Laurent Pinchart wrote: > The drm_bridge.driver_private field is set but never used. Don't set it. Doesn't seem harmful to keep it though.. but if it's not needed.. It looks like we get the driver context structure through container_of with bridge_to_rcar_lvds(), as the bridge is embedded there so indeed it's not needed. Reviewed-by: Kieran Bingham > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index 70dbbe44bb23..5909173b26eb 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -919,7 +919,6 @@ static int rcar_lvds_probe(struct platform_device *pdev) > if (ret < 0) > return ret; > > - lvds->bridge.driver_private = lvds; > lvds->bridge.funcs = &rcar_lvds_bridge_ops; > lvds->bridge.of_node = pdev->dev.of_node; > >