From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH 2/2] Xen: Add xen-apic support and hook it
 up.
Date: Wed, 11 Apr 2012 17:19:09 +0100
Message-ID: <alpine.DEB.2.00.1204111718310.15151@kaball-desktop>
References: <1333618350.2513.5.camel@leeds.uk.xensource.com>
	<1333618505.2513.8.camel@leeds.uk.xensource.com>
	<CAFEAcA9GJKPQBohDg-7NtcLKofH8vWRzO2KUjxNVk90exCknNw@mail.gmail.com>
	<alpine.DEB.2.00.1204111716030.15151@kaball-desktop>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1771022453-1334161164=:15151"
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <alpine.DEB.2.00.1204111716030.15151@kaball-desktop>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
To: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, xen-devel <xen-devel@lists.xensource.com>, "Wei Liu (Intern)" <wei.liu2@citrix.com>, "liuw@liuw.name" <liuw@liuw.name>, Jan Kiszka <jan.kiszka@siemens.com>, QEMU-devel <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>
List-Id: xen-devel@lists.xenproject.org

--8323329-1771022453-1334161164=:15151
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT

On Wed, 11 Apr 2012, Stefano Stabellini wrote:
> On Wed, 11 Apr 2012, Peter Maydell wrote:
> > On 5 April 2012 10:35, Wei Liu <wei.liu2@citrix.com> wrote:
> > >
> > > --- /dev/null
> > > +++ b/hw/xen_apic.c
> > > @@ -0,0 +1,90 @@
> > > +/*
> > > + * Xen basic APIC support
> > > + *
> > > + * Copyright (c) 2012 Citrix
> > > + *
> > > + * Authors:
> > > + *  Wei Liu <wei.liu2@citrix.com>
> > > + *
> > > + * This work is licensed under the terms of the GNU GPL version 2.
> > > + * See the COPYING file in the top-level directory.
> > > + */
> > 
> > Really 2-only, not 2-or-later ?
> 
> I am not a great fun of the 2-or-later clause and it doesn't look like a
> requirement from the QEMU project POV. However if it is, I'll change it
> to 2-or-later.
> 
> 
> > > +#include "hw/apic_internal.h"
> > > +#include "hw/msi.h"
> > > +#include "xen.h"
> > > +
> > > +static uint64_t xen_apic_mem_read(void *opaque, target_phys_addr_t addr,
> > > +                                  unsigned size)
> > > +{
> > > +    return -1U;
> > > +}
> > 
> > This seems a rather confusing way to write 'return 0xffffffff;'
>  
> Yep, I'll change it.

Actually it is a uint64 so it is a lot of f's
--8323329-1771022453-1334161164=:15151--