From: Julia Lawall <julia.lawall@lip6.fr>
To: dwmw2@infradead.org
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: question about fs/jffs2/readinode.c
Date: Sat, 28 Apr 2012 07:06:16 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1204280701210.1917@hadrien> (raw)
The function read_direntry in fs/jffs2/readinode.c contains the following
code:
err = jffs2_flash_read(c, (ref_offset(ref)) + read,
rd->nsize - already, &read, &fd->name[already]);
if (unlikely(read != rd->nsize - already) && likely(!err))
return -EIO;
if (unlikely(err)) {
JFFS2_ERROR("read remainder of name: error %d\n", err);
jffs2_free_full_dirent(fd);
return -EIO;
}
Is it intentional that the first if doesn't free fd? At first I thought
that that might be the case, because what would be the point of having two
conditionals if they are going to do the same thing. But I can't see why
fd should not be freed either, so maybe the two conditionals are just
there to give different error messages?
thanks,
julia
next reply other threads:[~2012-04-28 5:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 5:06 Julia Lawall [this message]
2012-05-02 12:07 ` question about fs/jffs2/readinode.c Artem Bityutskiy
2012-05-02 12:07 ` Artem Bityutskiy
2012-05-02 12:27 ` Julia Lawall
2012-05-02 12:27 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1204280701210.1917@hadrien \
--to=julia.lawall@lip6.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.