All of lore.kernel.org
 help / color / mirror / Atom feed
From: julia.lawall@lip6.fr (Julia Lawall)
To: cocci@systeme.lip6.fr
Subject: [Cocci] minor issue: pretty printing for modified functions as arguments
Date: Thu, 2 Oct 2014 08:39:05 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.02.1410020835420.2068@localhost6.localdomain6> (raw)
In-Reply-To: <20141001184054.GM14081@wotan.suse.de>

Is the problem that eg you get (indentation removed for readability):

-int (*unknown)(char *param, char *val, const char *doing))
+void *arg,int (*unknown)(char *param, char *val, const char *doing, void *arg))

instead of

-int (*unknown)(char *param, char *val, const char *doing))     
+void *arg,                                                     
+int (*unknown)(char *param, char *val,                         
+               const char *doing, void *arg))

I think that the problem is that Coccinelle does not try to respect 80
columns when there are nested parentheses.  But it seems like it could be
possible to at least have the declaration of unknown moved to the next
line.

julia

  parent reply	other threads:[~2014-10-02  6:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 18:40 [Cocci] minor issue: pretty printing for modified functions as arguments Luis R. Rodriguez
2014-10-01 19:49 ` SF Markus Elfring
2014-10-01 20:10   ` Luis R. Rodriguez
2014-10-01 22:03     ` Julia Lawall
2014-10-02  6:39 ` Julia Lawall [this message]
2014-10-02 20:47   ` Luis R. Rodriguez
2014-10-03  7:55 ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1410020835420.2068@localhost6.localdomain6 \
    --to=julia.lawall@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.