From: Scot Doyle <lkml14@scotdoyle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Daniel Mack <daniel@caiaq.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor
Date: Wed, 24 Sep 2014 17:28:36 +0000 (UTC) [thread overview]
Message-ID: <alpine.DEB.2.11.1409241632160.2600@localhost.localdomain> (raw)
In-Reply-To: <20140924052759.GB20986@kroah.com>
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote:
> On Tue, Sep 23, 2014 at 10:28:49PM +0000, Scot Doyle wrote:
>> I'd like to change this error message:
>> [ 3.325837] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409
>>
>> into an error message followed by a debug message:
>> [ 3.324726] usb 1-4: malformed string descriptor; unknown language, defaulting to English
>> [ 3.327514] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409
>>
>> in order to communicate more information from the log itself. Are there
>> any problems with this approach? Would it be better to put all the
>> information on a single line? Something else?
>
> How about just one line, why two?
>
> And something like "device not implementing langid specifier, defaulting
> to English", but cleaned up to sound a bit better?
That sounds good, I plan to submit this patch tomorrow unless anyone
prefers different wording.
---
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 0c8a7fc..5317081 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -770,9 +770,7 @@ static int usb_get_langid(struct usb_device *dev, unsigned char *tbuf)
dev->string_langid = 0x0409;
dev->have_langid = 1;
dev_err(&dev->dev,
- "string descriptor 0 malformed (err = %d), "
- "defaulting to 0x%04x\n",
- err, dev->string_langid);
+ "language id specifier not provided by device, defaulting to English");
return 0;
}
prev parent reply other threads:[~2014-09-24 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 22:28 [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor Scot Doyle
2014-09-24 5:27 ` Greg Kroah-Hartman
2014-09-24 17:28 ` Scot Doyle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1409241632160.2600@localhost.localdomain \
--to=lkml14@scotdoyle.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@caiaq.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.