From: Thomas Gleixner <tglx@linutronix.de>
To: Dave Airlie <airlied@redhat.com>
Cc: mcgrof@suse.com, torvalds@linux-foundation.org,
dan.j.williams@intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Toshi Kani <toshi.kani@hp.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Denys Vlasenko <dvlasenk@redhat.com>,
Brian Gerst <brgerst@gmail.com>
Subject: Re: [PATCH 1/2] x86/io: add interface to reserve io memtype for a resource range. (v1.1)
Date: Tue, 25 Oct 2016 13:10:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610251308560.4990@nanos> (raw)
In-Reply-To: <1477290706-7696-2-git-send-email-airlied@redhat.com>
On Mon, 24 Oct 2016, Dave Airlie wrote:
> A recent change to the mm code in:
> 87744ab3832b83ba71b931f86f9cfdb000d07da5
nit: 12 digits of the SHA1 are sufficient :)
> +int arch_io_reserve_memtype_wc(resource_size_t start, resource_size_t size)
> +{
> + enum page_cache_mode type = _PAGE_CACHE_MODE_WC;
Empty line between variable declaration and code please
> + return io_reserve_memtype(start, start + size, &type);
Other than that:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2016-10-25 11:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 6:31 x86 PAT memtype regression fixes (with extra cc's) Dave Airlie
2016-10-24 6:31 ` [PATCH 1/2] x86/io: add interface to reserve io memtype for a resource range. (v1.1) Dave Airlie
2016-10-25 9:40 ` Ingo Molnar
2016-10-25 11:10 ` Thomas Gleixner [this message]
2016-10-25 17:31 ` Luis R. Rodriguez
2016-10-26 5:49 ` Daniel Vetter
2016-10-26 6:12 ` Dave Airlie
2016-10-26 7:00 ` Daniel Vetter
2016-10-26 7:00 ` Daniel Vetter
2016-10-26 17:48 ` [PATCH] x86/pat, mm: Make track_pfn_insert() return void Borislav Petkov
2016-10-26 17:48 ` Borislav Petkov
2016-11-09 20:42 ` [tip:mm/pat] " tip-bot for Borislav Petkov
2016-10-24 6:31 ` [PATCH 2/2] drm/drivers: add support for using the arch wc mapping API Dave Airlie
2016-10-24 6:31 ` Dave Airlie
2016-10-24 9:24 ` Christian König
-- strict thread matches above, loose matches on Subject: below --
2016-10-24 6:28 x86 PAT memtype regression fixes Dave Airlie
2016-10-24 6:28 ` [PATCH 1/2] x86/io: add interface to reserve io memtype for a resource range. (v1.1) Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610251308560.4990@nanos \
--to=tglx@linutronix.de \
--cc=airlied@redhat.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mcgrof@suse.com \
--cc=torvalds@linux-foundation.org \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.