Re: [Outreachy kernel] [PATCH] media:atomisp:pci: Use error codes instead of bool variables

[Julia Lawall <julia.lawall@lip6.fr>]

On Wed, 8 Mar 2017, Georgiana Chelu wrote:

> >
> > > -     return true;
> > > +     return INPUT_SYSTEM_ERR_NO_ERROR;
> > > +
> > > +exit:
> > > +     return INPUT_SYSTEM_ERR_CREATE_CHANNEL_FAIL;
> >
> > Oh...  I was hoping for standard kernel values like -ENOMEM, -EINVAL, etc.
>
> I will further investigate this. At this moment, it seemed reasonable to me
> to use those error codes. They were defined in the module, but never used,
> which made me think that they still have a purpose. So, I chose the
> error code that seemed to be related to the name of the function.

It's a reasonable strategy, but someday the code will have to use the
kernel ones, so maybe one may as well get started on that.  The code will
be hybrid for a while, but tere is no point to try to do the whole thing
at once and make mistakes.

julia

>
> >
> > Also, watch your subject lines.  Normally there is a space after each :.
> > In any case, you should pick what has been commonly used for this driver.
> >
>
> I will take care of this in the future. Thanks!
>
> > julia
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CALta04yUrNJ2ShXUoZmHuLen%3Dj%2BrWLY7wKX2uFNXuKmCuSAiMQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>