From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1423285AbdKQXnn (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Nov 2017 18:43:43 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:53127 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S935350AbdKQXnf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Nov 2017 18:43:35 -0500
Date: Sat, 18 Nov 2017 00:43:30 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
cc: Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Prarit Bhargava <prarit@redhat.com>,
        Mark Salyzyn <salyzyn@android.com>, Petr Mladek <pmladek@suse.com>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Joe Perches <joe@perches.com>
Subject: Re: [RFC patch 4/7] timekeeping: Add NMI safe accessor to mono/boot/real
 clocks
In-Reply-To: <CA+55aFzFnQ9n=kfLCnq_mmDD3aqb+Uy_BHy9234UxCYTPPqBig@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1711180042380.2186@nanos>
References: <20171115181531.322572387@linutronix.de> <20171115182657.463124645@linutronix.de> <20171117180034.30413b64@gandalf.local.home> <CA+55aFzFnQ9n=kfLCnq_mmDD3aqb+Uy_BHy9234UxCYTPPqBig@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 17 Nov 2017, Linus Torvalds wrote:

> On Fri, Nov 17, 2017 at 3:00 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > Could you indent this better. It looks like timekeeping_delta_to_ns()
> > takes 4 arguments, when it really only takes two.
> 
> Actually, even better would be to simply not have that ugly three-line
> expression from hell.

I pondered and almost did that when I was hacking that up, but then
lazyness won :)