Re: [patch V10 08/10] Control knobs and Documentation 8

[Thomas Gleixner <tglx@linutronix.de>]

On Thu, 12 Jul 2018, speck for Josh Poimboeuf wrote:

> On Thu, Jul 12, 2018 at 04:19:10PM +0200, speck for Thomas Gleixner wrote:
> > -static int __init smt_cmdline_disable(char *str)
> > +void __init cpu_smt_disable(bool force)
> >  {
> > +	if (cpu_smt_control == CPU_SMT_FORCE_DISABLED)
> 
> Also needs to check for CPU_SMT_NOT_SUPPORTED.

For clarity sake, yes. Functional no as that is before the final decision
can be made which will set NOT_SUPPORTED.

But that made me look deeper and NOT_SUPPORTED is actually set too late
with those changes. Until now it was sufficient just to set it before the
sysfs control file is set up.

/me fixes.

> > +		return;
> > +
> >  	cpu_smt_control = CPU_SMT_DISABLED;
> > -	if (str && !strcmp(str, "force")) {
> > +	if (force) {
> >  		pr_info("SMT: Force disabled\n");
> >  		cpu_smt_control = CPU_SMT_FORCE_DISABLED;
> >  	}
> > +}
> 
> A bit weird that cpu_smt_control is written to twice in the force case.

That's to put more emphasis on it :) Fixed it up.

Thanks,

	tglx