From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52836C282E1 for ; Fri, 24 May 2019 16:02:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 299882081C for ; Fri, 24 May 2019 16:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389902AbfEXQCa (ORCPT ); Fri, 24 May 2019 12:02:30 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:43460 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389710AbfEXQC3 (ORCPT ); Fri, 24 May 2019 12:02:29 -0400 Received: from p5b06daab.dip0.t-ipconnect.de ([91.6.218.171] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hUCeJ-00072o-84; Fri, 24 May 2019 18:02:27 +0200 Date: Fri, 24 May 2019 18:02:16 +0200 (CEST) From: Thomas Gleixner To: Richard Fontana cc: linux-spdx@vger.kernel.org Subject: Re: [Batch 6 - patch 08/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 133 In-Reply-To: Message-ID: References: <20190524100345.776412942@linutronix.de> <20190524100843.594454135@linutronix.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On Fri, 24 May 2019, Richard Fontana wrote: > On Fri, May 24, 2019 at 6:12 AM Thomas Gleixner wrote: > > > > From: Thomas Gleixner tglx@linutronix.de > > > > Based on 1 normalized pattern(s): > > > > this program is free software you can redistribute it and or modify > > it under the terms of the gnu general public license as published by > > the free software foundation either version 2 of the license or at > > your option any later version this program is distributed in the > > hope that it will be useful but without any warranty without even > > the implied warranty of merchantability or fitness for a particular > > purpose see the gnu general public license for more details the full > > gnu general public license is in this distribution in the file > > called copying > > I just want to note that the final sentence/paragraph in this pattern, > alerting the user to the location of the license text ("The full GNU > General Public License is in this distribution in the file called > COPYING.") arguably raises its own sort of "keep intact" issue, > separate from the things we've been more focused on (notices of the > applicability of the license, and warranty/liability disclaimers > juxtaposed with the license notice). This may have come up in earlier > cases I looked at but if so I didn't think about it. The reference to the COPYING file is all over the place. But what's worrysome about that? I'd be worried if the boilerplate would be BSD and then point to the COPYING file in the kernel tree, but a plain GPL boiler plate? I can't see how that might change anything, the SPDX identifier is documented to be a placeholder for the full license text which is in the LICENSES directory and pointed to from the reworked COPYING file. Thanks, tglx