From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A2C8C00A89 for ; Fri, 30 Oct 2020 18:35:16 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BEF320729 for ; Fri, 30 Oct 2020 18:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ap6vKCg6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BEF320729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.16181.39517 (Exim 4.92) (envelope-from ) id 1kYZEo-0000cX-H0; Fri, 30 Oct 2020 18:34:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 16181.39517; Fri, 30 Oct 2020 18:34:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYZEo-0000cQ-Dp; Fri, 30 Oct 2020 18:34:58 +0000 Received: by outflank-mailman (input) for mailman id 16181; Fri, 30 Oct 2020 18:34:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYZEn-0000cL-74 for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 18:34:57 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d49b34e9-650e-4a92-b7ef-3743d1ebe73f; Fri, 30 Oct 2020 18:34:56 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s (c-24-130-65-46.hsd1.ca.comcast.net [24.130.65.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00B5E20729; Fri, 30 Oct 2020 18:34:54 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYZEn-0000cL-74 for xen-devel@lists.xenproject.org; Fri, 30 Oct 2020 18:34:57 +0000 X-Inumbo-ID: d49b34e9-650e-4a92-b7ef-3743d1ebe73f Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d49b34e9-650e-4a92-b7ef-3743d1ebe73f; Fri, 30 Oct 2020 18:34:56 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s (c-24-130-65-46.hsd1.ca.comcast.net [24.130.65.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00B5E20729; Fri, 30 Oct 2020 18:34:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604082895; bh=Ksm8ZRwC5xIEq+rvokHzDCtcSUrr9kI6LtAgdYmzoJA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Ap6vKCg6A6x4jtLJi01e8Tx9avEXg6iczqIuHjrdYREASK4yAdg5JrNwXOxpLEg6o 6qkAIoG+LlxDiOToUmTgkmZouUhxI9gs7G522IYzDiFp1SDGWNIFN9T3AUlW7Cxj/S Go3vD2KS8xpYdDg6Nxuv41QYKiAlRnhZfC2aN3O8= Date: Fri, 30 Oct 2020 11:34:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: Stefano Stabellini , xen-devel@lists.xenproject.org, alex.bennee@linaro.org, masami.hiramatsu@linaro.org, ehem+xen@m5p.com, bertrand.marquis@arm.com, andre.przywara@arm.com, Rahul.Singh@arm.com, Julien Grall , Volodymyr Babchuk , Wei Xu Subject: Re: [PATCH v2 2/7] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap In-Reply-To: <5a8afe57-1be5-6a0b-2ed5-e668690fc246@xen.org> Message-ID: References: <20201023154156.6593-1-julien@xen.org> <20201023154156.6593-3-julien@xen.org> <6038f41f-594c-e573-9126-f31291af9c38@xen.org> <5a8afe57-1be5-6a0b-2ed5-e668690fc246@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 30 Oct 2020, Julien Grall wrote: > Hi, > > On 30/10/2020 18:28, Stefano Stabellini wrote: > > On Fri, 30 Oct 2020, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 24/10/2020 01:16, Stefano Stabellini wrote: > > > > On Fri, 23 Oct 2020, Julien Grall wrote: > > > > > bool __acpi_unmap_table(const void *ptr, unsigned long size) > > > > > { > > > > > vaddr_t vaddr = (vaddr_t)ptr; > > > > > + unsigned int idx; > > > > > + > > > > > + /* We are only handling fixmap address in the arch code */ > > > > > + if ( (vaddr < FIXMAP_ADDR(FIXMAP_ACPI_BEGIN)) || > > > > > + (vaddr >= FIXMAP_ADDR(FIXMAP_ACPI_END)) ) > > > > > > > > Is it missing "+ PAGE_SIZE"? > > > > > > > > if ( (vaddr < FIXMAP_ADDR(FIXMAP_ACPI_BEGIN)) || > > > > (vaddr >= FIXMAP_ADDR(FIXMAP_ACPI_END) + PAGE_SIZE) ) > > > > > > Yes it should be + PAGE_SIZE. Do you mind if I fix it on commit? > > > > No, I don't mind. Go ahead. > > I technically don't have a ack for this patch. Can I consider this as a > Acked-by? :) Acked-by: Stefano Stabellini