From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754666AbbKMM4N (ORCPT ); Fri, 13 Nov 2015 07:56:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:45303 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754137AbbKMM4L (ORCPT ); Fri, 13 Nov 2015 07:56:11 -0500 Date: Fri, 13 Nov 2015 13:56:08 +0100 (CET) From: Miroslav Benes To: Jessica Yu cc: Josh Poimboeuf , Petr Mladek , Rusty Russell , Seth Jennings , Jiri Kosina , Vojtech Pavlik , linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: module: save load_info for livepatch modules In-Reply-To: Message-ID: References: <1447130755-17383-1-git-send-email-jeyu@redhat.com> <1447130755-17383-3-git-send-email-jeyu@redhat.com> <20151112053228.GD30025@packer-debian-8-amd64.digitalocean.com> <20151112102404.GL4431@pathway.suse.cz> <20151112150345.GT2599@pathway.suse.cz> <20151112170501.GD4038@treble.hsd1.ky.comcast.net> <20151112221750.GA13513@packer-debian-8-amd64.digitalocean.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Nov 2015, Miroslav Benes wrote: > I agree this seems like the best approach. So if we preserve > mod_arch_syminfo (in case of s390) we should free it not in > module_finalize, but somewhere in free_module... where > module_arch_cleanup() is called... and also module_arch_freeing_init() is > called there too. And what you find there for s390 is > > vfree(mod->arch.syminfo); > mod->arch.syminfo = NULL; > > Well, it does nothing here, because mod->arch.syminfo is already NULL. It > was freed in module_finalize. So we can even remove this code from > module_finalize and all should be fine. At least for s390. Which is not true because module_arch_freeing_init is also called from do_init_module, called from load_module. So we should move it to module_arch_cleanup. That code is like a maze without Ariadne's thread. Miroslav From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miroslav Benes Subject: Re: module: save load_info for livepatch modules Date: Fri, 13 Nov 2015 13:56:08 +0100 (CET) Message-ID: References: <1447130755-17383-1-git-send-email-jeyu@redhat.com> <1447130755-17383-3-git-send-email-jeyu@redhat.com> <20151112053228.GD30025@packer-debian-8-amd64.digitalocean.com> <20151112102404.GL4431@pathway.suse.cz> <20151112150345.GT2599@pathway.suse.cz> <20151112170501.GD4038@treble.hsd1.ky.comcast.net> <20151112221750.GA13513@packer-debian-8-amd64.digitalocean.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jessica Yu Cc: Josh Poimboeuf , Petr Mladek , Rusty Russell , Seth Jennings , Jiri Kosina , Vojtech Pavlik , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, live-patching-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Fri, 13 Nov 2015, Miroslav Benes wrote: > I agree this seems like the best approach. So if we preserve > mod_arch_syminfo (in case of s390) we should free it not in > module_finalize, but somewhere in free_module... where > module_arch_cleanup() is called... and also module_arch_freeing_init() is > called there too. And what you find there for s390 is > > vfree(mod->arch.syminfo); > mod->arch.syminfo = NULL; > > Well, it does nothing here, because mod->arch.syminfo is already NULL. It > was freed in module_finalize. So we can even remove this code from > module_finalize and all should be fine. At least for s390. Which is not true because module_arch_freeing_init is also called from do_init_module, called from load_module. So we should move it to module_arch_cleanup. That code is like a maze without Ariadne's thread. Miroslav