From: "Jürgen Groß" <jgross@suse.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: paul@xen.org, Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH RFC 0/3] xen: add hypfs per-domain abi-features
Date: Thu, 10 Dec 2020 08:49:44 +0100 [thread overview]
Message-ID: <b2118f4d-07c5-abae-2b1b-ac8f45c02563@suse.com> (raw)
In-Reply-To: <a2270efd-19d4-5d5e-2e8b-4696ba9751ab@xen.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1160 bytes --]
On 09.12.20 17:24, Julien Grall wrote:
> Hi,
>
> On 09/12/2020 16:16, Juergen Gross wrote:
>> This small series is meant as an example how to add further dynamical
>> directories to hypfs. It can be used to replace Paul's current approach
>> to specify ABI-features via domain create flags and replace those by
>> hypfs nodes.
>
> This can only work if all the ABI-features are not required at the time
> of creating the domain.
Yes. In case there is some further initialization needed this has to be
done later depending on the setting.
> Those features should also be set only once. Furthermore, HYPFS is so
> far meant to be optional.
"set once" isn't the point. They should not be able to change after the
domain has been started, and that is covered.
>
> So it feels to me Paul's approach is leaner and better for the
> ABI-features purpose.
Depends.
My approach doesn't need any tools side changes after first
implementation when adding new abi-features. And it isn't expanding an
unstable interface.
In the end this is the reason I marked this series as RFC. If using
flags is preferred, fine.
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2020-12-10 11:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 16:16 [PATCH RFC 0/3] xen: add hypfs per-domain abi-features Juergen Gross
2020-12-09 16:16 ` [PATCH RFC 1/3] xen/hypfs: add support for bool leafs in dynamic directories Juergen Gross
2021-01-08 15:38 ` Jan Beulich
2020-12-09 16:16 ` [PATCH RFC 2/3] xen/domain: add domain hypfs directories Juergen Gross
2020-12-09 16:37 ` Julien Grall
2020-12-10 7:54 ` Jürgen Groß
2020-12-10 11:51 ` Julien Grall
2020-12-10 12:46 ` Jürgen Groß
2020-12-09 16:16 ` [PATCH RFC 3/3] xen/domain: add per-domain hypfs directory abi-features Juergen Gross
2020-12-09 16:24 ` [PATCH RFC 0/3] xen: add hypfs per-domain abi-features Julien Grall
2020-12-10 7:49 ` Jürgen Groß [this message]
2020-12-10 11:57 ` Julien Grall
2021-01-08 15:44 ` Jan Beulich
2021-01-13 10:47 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2118f4d-07c5-abae-2b1b-ac8f45c02563@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=paul@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.