From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Fri, 28 May 2021 23:07:34 +0200 Subject: [Buildroot] [PATCHv3 11/15] package/sofia-sip: use BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG In-Reply-To: References: <20210525122750.5022-1-patrickdepinguin@gmail.com> <20210525122750.5022-12-patrickdepinguin@gmail.com> <0fd19bad-277f-ae7d-1928-fd4dc0bf6fcc@mind.be> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 28/05/2021 20:35, Thomas De Schampheleire wrote: > El mar, 25 may 2021 a las 23:32, Arnout Vandecappelle > () escribi?: >> >> >> On 25/05/2021 14:27, Thomas De Schampheleire wrote: >>> From: Thomas De Schampheleire >>> >>> BR2_ENABLE_DEBUG should just steer the availability of debug symbols and >>> should have no negative effect on performance. >>> >>> Introduction of 'assert' statements, 'debug'-type builds with additional >>> logging, etc. should be steered by BR2_ENABLE_RUNTIME_DEBUG instead. >>> >>> Signed-off-by: Thomas De Schampheleire >>> --- >>> package/sofia-sip/sofia-sip.mk | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/package/sofia-sip/sofia-sip.mk b/package/sofia-sip/sofia-sip.mk >>> index 5c383400ff..cb867ba0dc 100644 >>> --- a/package/sofia-sip/sofia-sip.mk >>> +++ b/package/sofia-sip/sofia-sip.mk >>> @@ -30,7 +30,7 @@ SOFIA_SIP_CONF_OPTS += \ >>> --without-openssl >>> endif >>> >>> -ifeq ($(BR2_ENABLE_DEBUG),y) >>> +ifeq ($(BR2_ENABLE_RUNTIME_DEBUG),y) >>> SOFIA_SIP_CONF_OPTS += --enable-ndebug >> Actually, the logic was inverted here (already wrong in the current situation): >> --enable-ndebug should be given when RUNTIME_DEBUG is *not* set. > Indeed, you're right. I'll add a patch to fix that first. > >> However, I think we should define -DNDEBUG in TARGET_CPPFLAGS, so it wouldn't >> be necessary to pass it explicitly here (--enable-ndebug does nothing more than >> defining NDEBUG). > In a previous iteration I basically did that, but dropped that patch > because it also had effect in the toolchain wrapper, No it doesn't... TARGET_CFLAGS isn't set in the toolchain wrapper. Only arch-specific options are there, and BR2_TARGET_OPTIMIZATION (which is intended for arch-specific -m flags). > which may be used > to build project-specific projects, and which caused compilation > failures when NDEBUG was unexpectedly set If it's built by Buildroot, then of course it *is* going to be passed in through CFLAGS. > (e.g. variables only used > for assert statements, which got compiled away with NDEBUG). Granted, > this is actually a problem in such code, but nevertheless it was my > reality and I expect those of others too. If you don't want to fix the actual issue, you can always add -UNDEBUG in the package-specific CFLAGS or in the package build system. Regards, Arnout > See http://patchwork.ozlabs.org/project/buildroot/patch/20210212135451.22786-3-patrickdepinguin at gmail.com/ > and my last comment on it.