All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 66/93] arm: Remove ot1200 board
Date: Thu, 22 Nov 2018 20:48:49 +0100	[thread overview]
Message-ID: <b65ecb51-3045-c3f3-5aaf-3173bc28c5df@gmail.com> (raw)
In-Reply-To: <b6be0e31-09f2-7af0-221e-3d84c15a5519@gmail.com>


[I've shortened the CC list a bit since this might be somewhat off-topic 
and both gmail warned be about too many CCs]

On 22.11.2018 18:01, Tom Rini wrote:
> On Thu, Nov 22, 2018 at 03:44:28PM +0100, Simon Goldschmidt wrote:
>> Am Do., 22. Nov. 2018, 14:44 hat Tom Rini <trini@konsulko.com> geschrieben:
>>
>>> On Thu, Nov 22, 2018 at 02:24:49PM +0100, Marek Vasut wrote:
>>>> On 11/22/2018 01:52 PM, Tom Rini wrote:
>>>>> On Thu, Nov 22, 2018 at 10:25:14AM +0100, Christian Gmeiner wrote:
>>>>>
>>>>>> Am Mo., 19. Nov. 2018 um 16:56 Uhr schrieb Simon Glass <
>>> sjg at chromium.org>:
>>>>>>> This board has not been converted to CONFIG_DM_BLK by the deadline.
>>>>>>> Remove it.
>>>>>>>
>>>>>> As the board is still mainted I will NAK it for the moment. Are there
>>>>>> any hints want needs to be done
>>>>>> to port thie board over to new DM stuff?
>>>>> Yes, as a start you need to switch over to using CONFIG_OF_CONTROL and
>>>>> selecting/providing a dtb file.  I see ot1200 is using DWC_AHSATA which
>>>>> needs more work, but this is the board-level work that needs doing.
>>>> Wasn't there a possibility to use platform data in board file instead of
>>>> DT ? Or is DT mandatory now , including the libfdt overhead ?
>>> In short, DT for U-Boot and platform data for SPL is what's recommended,
>>> yes.
>>>
>> This is a little confusing for me. Socfpga gen5 SPL doesn't do that. And it
>> seems a little strange or outdated overall.
>>
>> Would there be some kind of reference architecture or mach to look at
>> what's the suggested/up-to-date way to implement SPL? Also regarding code
>> flow?
> So, SPL is where things get, ahem, fuzzy.  While I don't want to
> encourage boundless growth in U-Boot proper, we aren't exactly size
> constrained (but rather, functional/logical constrained).  But in SPL,
> yes, we have many platforms with 32/64/128 kilobyte hard limits (and
> some smaller) and we can't always shove in a "TPL" before SPL either.
> So in SPL we do make use of platform data instead.  While not the
> smallest size constraint, am335x_hs_evm is a reasonable thing to look at
> in this case.

OK. My main concern here is not size regarding DTB or platform data but
really code flow. Like what should be done in which function and when.
There seem to be some implications of *when* some things are done or in
which order. And the socfpga gen5 SPL seems like a "historically grown"
one to me. I just wanted to see if there's any example of a "well
formed" SPL. I'll have a look at that am335x_hs_evm you mentioned, thanks.

Simon

       reply	other threads:[~2018-11-22 19:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b6be0e31-09f2-7af0-221e-3d84c15a5519@gmail.com>
2018-11-22 19:48 ` Simon Goldschmidt [this message]
2018-11-19 15:52 [U-Boot] [PATCH 00/93] dm: Move towards completing CONFIG_BLK migration Simon Glass
2018-11-19 15:53 ` [U-Boot] [PATCH 66/93] arm: Remove ot1200 board Simon Glass
2018-11-22  9:25   ` Christian Gmeiner
2018-11-22 12:52     ` Tom Rini
2018-11-22 13:24       ` Marek Vasut
2018-11-22 13:28         ` Tom Rini
2018-11-22 13:30           ` Marek Vasut
2018-11-22 13:32             ` Tom Rini
2018-11-22 13:40               ` Marek Vasut
2018-11-22 14:44           ` Simon Goldschmidt
2018-11-22 17:01             ` Tom Rini
2018-11-22 20:50               ` Simon Glass
2018-11-25 21:09                 ` Simon Goldschmidt
2018-11-26  3:00                   ` Simon Glass
2018-11-26  6:05                     ` Simon Goldschmidt
2018-12-05 13:21                       ` Simon Glass
2018-12-05 13:38                         ` Simon Goldschmidt
2018-12-05 13:54                           ` Simon Glass
2018-12-05 14:16                             ` Simon Goldschmidt
2018-12-05 15:55                               ` Simon Glass
2018-12-05 16:11                                 ` Simon Goldschmidt
2018-11-23  0:33     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b65ecb51-3045-c3f3-5aaf-3173bc28c5df@gmail.com \
    --to=simon.k.r.goldschmidt@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.