From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
dmaengine@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] dmaengine: ioat: depends on !UML
Date: Wed, 25 Aug 2021 15:41:04 +0200 [thread overview]
Message-ID: <b6fd5d53925712f9948a2ae3fa29cc4bc3b219fc.camel@sipsolutions.net> (raw)
In-Reply-To: <CAPcyv4j545=-9igjXjMWU_6-1COkOOejZz9ULgOmVvK1Y+8eiQ@mail.gmail.com>
On Wed, 2021-08-25 at 06:36 -0700, Dan Williams wrote:
> > > >
> > > > The problem here is that cpuid_eax() and cpuid_ebx() don't even exist on
>
[snip]
> It can't compile because the arch dependencies are not stubbed out
> like other arch specific helpers. I think this is something to revisit
> if / when concepts similar to the "enqcmd" instruction appear on other
> archs.
I think you're confusing ioat and idxd? :)
The ioat driver (which this patch is against) uses cpuid_eax() and
cpuid_ebx() above, and really if a driver uses that then it can only
possibly run on IA :)
I'm not sure it makes sense to abstract out things such as
dca_enabled_in_bios() to a general architecture thing either?
johannes
next prev parent reply other threads:[~2021-08-25 13:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 9:24 [PATCH] dmaengine: ioat: depends on !UML Johannes Berg
2021-08-09 16:02 ` Dave Jiang
2021-08-09 17:24 ` Dan Williams
2021-08-09 17:26 ` Johannes Berg
2021-08-25 13:31 ` Dan Williams
2021-08-25 13:33 ` Johannes Berg
2021-08-25 13:36 ` Dan Williams
2021-08-25 13:41 ` Johannes Berg [this message]
2021-08-25 13:53 ` Dan Williams
2021-08-25 11:31 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fd5d53925712f9948a2ae3fa29cc4bc3b219fc.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.